From patchwork Tue Feb 1 15:54:52 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 50 Return-Path: Delivered-To: unknown Received: from imap.gmail.com (74.125.159.109) by localhost6.localdomain6 with IMAP4-SSL; 08 Jun 2011 14:39:33 -0000 Delivered-To: patches@linaro.org Received: by 10.147.124.5 with SMTP id b5cs109617yan; Tue, 1 Feb 2011 07:54:56 -0800 (PST) Received: by 10.227.183.203 with SMTP id ch11mr7870006wbb.214.1296575695505; Tue, 01 Feb 2011 07:54:55 -0800 (PST) Received: from mnementh.archaic.org.uk (mnementh.archaic.org.uk [81.2.115.146]) by mx.google.com with ESMTPS id k6si22799217wbc.64.2011.02.01.07.54.54 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 01 Feb 2011 07:54:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of pm215@archaic.org.uk designates 81.2.115.146 as permitted sender) client-ip=81.2.115.146; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of pm215@archaic.org.uk designates 81.2.115.146 as permitted sender) smtp.mail=pm215@archaic.org.uk Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.69) (envelope-from ) id 1PkIZA-00064m-Gw; Tue, 01 Feb 2011 15:54:52 +0000 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org, Blue Swirl , Riku Voipio Subject: [PATCH] linux-user: avoid gcc array overrun warning for sparc Date: Tue, 1 Feb 2011 15:54:52 +0000 Message-Id: <1296575692-23335-1-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.1 Suppress a gcc array bounds overrun warning when filling in the SPARC signal frame by adjusting our definition of the structure so that the fp and callers_pc membes are part of the ins[] array rather than separate fields; since qemu has no need to access the fields individually there is no need to follow the kernel's structure field naming exactly. Signed-off-by: Peter Maydell --- This is a fix for another warning that the armel gcc gives: linux-user/signal.c:1979: error: array subscript is above array bounds so if it passes review I think it's a good candidate for putting in 0.14. linux-user/signal.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 0664770..b01bd64 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -1817,9 +1817,10 @@ struct target_sigcontext { /* A Sparc stack frame */ struct sparc_stackf { abi_ulong locals[8]; - abi_ulong ins[6]; - struct sparc_stackf *fp; - abi_ulong callers_pc; + abi_ulong ins[8]; + /* It's simpler to treat fp and callers_pc as elements of ins[] + * since we never need to access them ourselves. + */ char *structptr; abi_ulong xargs[6]; abi_ulong xxargs[1];