From patchwork Thu Aug 27 21:18:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 248454 Delivered-To: patch@linaro.org Received: by 2002:a17:906:6447:0:0:0:0 with SMTP id l7csp594218ejn; Thu, 27 Aug 2020 14:19:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwt0G4Zzr79SYKcZijGn6J7ffiWvBc2BtWjnnc6Jys//CMBDdcyLx7PCScDEEQV4G46wj8L X-Received: by 2002:a25:2451:: with SMTP id k78mr32126488ybk.335.1598563158371; Thu, 27 Aug 2020 14:19:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598563158; cv=none; d=google.com; s=arc-20160816; b=E86d1ysmuE+1G+ctrKnK0+7JJiTyiWfOjJre4+nGAmXknPPXVpsyXBylapDpHlh8rR 1AJ9pZbZEii8pWSmI2378eFbmdrmt+6iZ/RwGCaW+l7xWFa45m8bC2TxLnD9k3P73HYy kV/trjFwdZpNSr3Sz/L0GgTyAqrc6wQQ6M/9ZZsbWUx4ZKhH+6Ajov6RD87B+CimRe4X Gr+AEtT5BR11huTPBPFapGz8kLbl/9Q1FOkHLmELfvoEFo4E5wFThQKpXsVY/d7F2pRl OcKCbZ+TvP3qIMZWApbp4D1OLaFWeiRD5WaMs8c/+z5Xai3ovGoFR/089sG7YySiCdet a6Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-language:mime-version :user-agent:date:message-id:subject:from:to:dkim-signature; bh=Dt0N+ePf7hKrxt/rXK/IQVXTqKR4hijiYCr568leI9k=; b=ZvmNBxz/hmMvClXAimBNzuYmvzvHUkfhcbcUrMdd4F6cKhhpIqzxtrXfzLwiqpmCaE gJBx+B5XRnmzajhc1vZ4kiwl5C3slt/W8P2HEI4d1R2roRR97vGHpvoEvO36q2c8pl94 XPqhWzkUSvf3KuilknOP+NtIXzZaYR/ZwubhVHL4xdv/EBk1spKy2a1NQD1uwbE2voti rvFKK26M+Eno8JnJ5kcCtqdIXMcvFCcFe+QIF2WS9EhpCIHKTSgB7vStooTL5jLCNIOd R0tNqQN1+gYA874kJlJiVlmPSqjW+GEZThh5XkB4VuGKULa/bWYL/HVmRe5X9OaD9m7g JocA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uVSTBFYM; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x2si3869692ybd.119.2020.08.27.14.19.18 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 Aug 2020 14:19:18 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uVSTBFYM; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:59938 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBPIj-0003pz-Qo for patch@linaro.org; Thu, 27 Aug 2020 17:19:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58958) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBPIK-0003pq-Fb for qemu-devel@nongnu.org; Thu, 27 Aug 2020 17:18:52 -0400 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]:50239) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kBPII-0006bl-R6 for qemu-devel@nongnu.org; Thu, 27 Aug 2020 17:18:52 -0400 Received: by mail-pj1-x1032.google.com with SMTP id i13so3311351pjv.0 for ; Thu, 27 Aug 2020 14:18:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=to:from:subject:message-id:date:user-agent:mime-version :content-language; bh=Dt0N+ePf7hKrxt/rXK/IQVXTqKR4hijiYCr568leI9k=; b=uVSTBFYMtmm+2XSyr2RBOvYz9All9FAmnoeAr/XZcV06XGMqGpi1J1ht896COrw1Nt YCEWatugUVUE7JRHeo0n15Dy0XEudoqx3iAog72mS46G2pOStOVgnVOnvT08rskNxPBx pKbbJfktBusR4dxQHMAZbPe4sQ4XlUJTLcA5tDAHUdQI4nlTy5y87lypsaJcZlkWCkFc dEir+5BUMf3tul+q+qsqa58H2AfEtTh+U8nWqBKd0cX3aVWeRx2lT6ut6l8Yem8FVMei s/ya3VphWWFAz036/m72Bigx52khxHjfeseVo+CHKlGxjnri9FQ9Ynp+RVBuFYUAmZJp EgXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-language; bh=Dt0N+ePf7hKrxt/rXK/IQVXTqKR4hijiYCr568leI9k=; b=h9rSZu3SLjq5S2S0tA0dXVYpODD/ZgB/V1irMXVxry9b7bRzRanfIhgddtTpSCb22a ljwoVcVAKm7uFMEhvr6doqjCrSZkTtOpKm6Y6hezBo81LvWBK6eqPbzi+Y7p929rMaIc H2QTfnCqbFPx3W8dyUT5vof21DPyajRozB7JmeiRW1hECIzUors4P6ImPnqSZmCAGBQw YvIKfDNbmgtrBJztxmAh9h6TEL4FUKuvuvQpceDnjmzGlIstR8DF5X/WUQ6omQQkigyV 0mCXo7zGmGfqEN7WbYVl9YJ/P1ilbgbBQC8xJVGeVc0+Gp/DXQloBmt1I8wqYKXBVVdv V/2A== X-Gm-Message-State: AOAM5308i9AmxrbdrtpjgFxGIy7m81mnz/eveJOIAO8cQhpFpXQpNPNz yfYjykuoqC1D0YUofDT3ZK5dTcpOQOLLFQ== X-Received: by 2002:a17:90a:384c:: with SMTP id l12mr635410pjf.27.1598563128947; Thu, 27 Aug 2020 14:18:48 -0700 (PDT) Received: from [192.168.1.11] ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id l5sm3429899pga.43.2020.08.27.14.18.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Aug 2020 14:18:47 -0700 (PDT) To: Paolo Bonzini , qemu-devel From: Richard Henderson Subject: build broken with --enable-gcrypt Message-ID: <046eb29c-9c68-1baf-846e-decd65f567e0@linaro.org> Date: Thu, 27 Aug 2020 14:18:46 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 Content-Language: en-US Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1032.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The meson conversion seems to have not been properly accomplished for the gcrypt option: we fail to link against -lgcrypt. I tried aping the nettle bits, like the following, but it has no effect. I don't understand how the "nettle" token works, honestly, since it doesn't appear to be used at all. r~ diff --git a/configure b/configure index b1e11397a8..4fd50c0275 100755 --- a/configure +++ b/configure @@ -6972,6 +6972,8 @@ if test "$gcrypt" = "yes" ; then if test "$gcrypt_hmac" = "yes" ; then echo "CONFIG_GCRYPT_HMAC=y" >> $config_host_mak fi + echo "GCRYPT_CFLAGS=$gcrypt_cflags" >> $config_host_mak + echo "GCRYPT_LIBS=$gcrypt_libs" >> $config_host_mak fi if test "$nettle" = "yes" ; then echo "CONFIG_NETTLE=y" >> $config_host_mak diff --git a/meson.build b/meson.build index f0fe5f8799..d45c548191 100644 --- a/meson.build +++ b/meson.build @@ -108,6 +108,11 @@ if 'CONFIG_NETTLE' in config_host nettle = declare_dependency(compile_args: config_host['NETTLE_CFLAGS'].split(), link_args: config_host['NETTLE_LIBS'].split()) endif +gcrypt = not_found +if 'CONFIG_GCRYPT' in config_host + gcrypt = declare_dependency(compile_args: config_host['GCRYPT_CFLAGS'].split(), + link_args: config_host['GCRYPT_LIBS'].split()) +endif gnutls = not_found if 'CONFIG_GNUTLS' in config_host gnutls = declare_dependency(compile_args: config_host['GNUTLS_CFLAGS'].split(),