mbox series

[PATCH-for-10.0,0/5] hw/arm/virt-acpi: Do not advertise disabled GIC ITS in MADT table

Message ID 20250331221239.87150-1-philmd@linaro.org
Headers show
Series hw/arm/virt-acpi: Do not advertise disabled GIC ITS in MADT table | expand

Message

Philippe Mathieu-Daudé March 31, 2025, 10:12 p.m. UTC
GIC ITS can be disabled using '-M its=off'.
When that occurs, it shouldn't be advertised in ACPI tables.

Philippe Mathieu-Daudé (5):
  qtest/bios-tables-test: Add test for -M virt,its=off
  qtest/bios-tables-test: Whitelist aarch64/virt/APIC.its_off blob
  hw/arm/virt-acpi: Factor its_enabled() helper out
  hw/arm/virt-acpi: Do not advertise disabled GIC ITS
  qtest/bios-tables-test: Update aarch64/virt/APIC.its_off blob

 hw/arm/virt-acpi-build.c                  |  12 +++++++++---
 tests/qtest/bios-tables-test.c            |  22 ++++++++++++++++++++++
 tests/data/acpi/aarch64/virt/APIC.its_off | Bin 0 -> 164 bytes
 tests/data/acpi/aarch64/virt/FACP.its_off | Bin 0 -> 276 bytes
 tests/data/acpi/aarch64/virt/IORT.its_off | Bin 0 -> 236 bytes
 5 files changed, 31 insertions(+), 3 deletions(-)
 create mode 100644 tests/data/acpi/aarch64/virt/APIC.its_off
 create mode 100644 tests/data/acpi/aarch64/virt/FACP.its_off
 create mode 100644 tests/data/acpi/aarch64/virt/IORT.its_off

Comments

Michael S. Tsirkin April 3, 2025, 2:04 p.m. UTC | #1
On Tue, Apr 01, 2025 at 12:12:34AM +0200, Philippe Mathieu-Daudé wrote:
> GIC ITS can be disabled using '-M its=off'.
> When that occurs, it shouldn't be advertised in ACPI tables.

I doubt this is 10.0 material. How common is its=off that we
urgently need to fix it?

> Philippe Mathieu-Daudé (5):
>   qtest/bios-tables-test: Add test for -M virt,its=off
>   qtest/bios-tables-test: Whitelist aarch64/virt/APIC.its_off blob
>   hw/arm/virt-acpi: Factor its_enabled() helper out
>   hw/arm/virt-acpi: Do not advertise disabled GIC ITS
>   qtest/bios-tables-test: Update aarch64/virt/APIC.its_off blob
> 
>  hw/arm/virt-acpi-build.c                  |  12 +++++++++---
>  tests/qtest/bios-tables-test.c            |  22 ++++++++++++++++++++++
>  tests/data/acpi/aarch64/virt/APIC.its_off | Bin 0 -> 164 bytes
>  tests/data/acpi/aarch64/virt/FACP.its_off | Bin 0 -> 276 bytes
>  tests/data/acpi/aarch64/virt/IORT.its_off | Bin 0 -> 236 bytes
>  5 files changed, 31 insertions(+), 3 deletions(-)
>  create mode 100644 tests/data/acpi/aarch64/virt/APIC.its_off
>  create mode 100644 tests/data/acpi/aarch64/virt/FACP.its_off
>  create mode 100644 tests/data/acpi/aarch64/virt/IORT.its_off
> 
> -- 
> 2.47.1