mbox series

[PATCH-for-10.1,0/8] target/mips: Make 'cpu-qom.h' target agnostic

Message ID 20250325154058.92735-1-philmd@linaro.org
Headers show
Series target/mips: Make 'cpu-qom.h' target agnostic | expand

Message

Philippe Mathieu-Daudé March 25, 2025, 3:40 p.m. UTC 
- Remove the TARGET_MIPS64 use in 'cpu-qom.h' to
  make it target agnostic
- Introduce mips_cpu_is_64bit() as a runtime check
  for compile time TARGET_MIPS64 definition
- Replace the ldtul_p() gdbstub call by ldn_p()
- Rename few symbols to avoid future linkage clash

Philippe Mathieu-Daudé (8):
  cpus: Open code OBJECT_DECLARE_TYPE() in OBJECT_DECLARE_CPU_TYPE()
  target/mips: Declare CPU QOM types using DEFINE_TYPES() macro
  target/mips: Make MIPS_CPU common to new MIPS32_CPU / MIPS64_CPU types
  target/mips: Prefix MMU API with 'mips_'
  target/mips: Replace ldtul_p() -> ldn_p(sizeof(target_ulong))
  target/mips: Introduce mips_cpu_is_64bit() helper
  target/mips: Get CPU register size using mips_cpu_is_64bit()
  target/mips: Introduce mips_env_64bit_enabled() helper

 include/hw/core/cpu.h               |  7 ++++-
 target/mips/cpu-qom.h               | 14 +++++-----
 target/mips/internal.h              |  5 ++++
 target/mips/tcg/tcg-internal.h      |  2 +-
 target/mips/cpu.c                   | 42 ++++++++++++++++++++---------
 target/mips/gdbstub.c               | 14 +++++++---
 target/mips/tcg/system/tlb_helper.c |  2 +-
 7 files changed, 61 insertions(+), 25 deletions(-)

Comments

Anton Johansson March 26, 2025, 4:50 p.m. UTC | #1 
On 25/03/25, Philippe Mathieu-Daudé wrote:
> - Remove the TARGET_MIPS64 use in 'cpu-qom.h' to
>   make it target agnostic
> - Introduce mips_cpu_is_64bit() as a runtime check
>   for compile time TARGET_MIPS64 definition
> - Replace the ldtul_p() gdbstub call by ldn_p()
> - Rename few symbols to avoid future linkage clash
> 
> Philippe Mathieu-Daudé (8):
>   cpus: Open code OBJECT_DECLARE_TYPE() in OBJECT_DECLARE_CPU_TYPE()
>   target/mips: Declare CPU QOM types using DEFINE_TYPES() macro
>   target/mips: Make MIPS_CPU common to new MIPS32_CPU / MIPS64_CPU types
>   target/mips: Prefix MMU API with 'mips_'
>   target/mips: Replace ldtul_p() -> ldn_p(sizeof(target_ulong))
>   target/mips: Introduce mips_cpu_is_64bit() helper
>   target/mips: Get CPU register size using mips_cpu_is_64bit()
>   target/mips: Introduce mips_env_64bit_enabled() helper
> 
>  include/hw/core/cpu.h               |  7 ++++-
>  target/mips/cpu-qom.h               | 14 +++++-----
>  target/mips/internal.h              |  5 ++++
>  target/mips/tcg/tcg-internal.h      |  2 +-
>  target/mips/cpu.c                   | 42 ++++++++++++++++++++---------
>  target/mips/gdbstub.c               | 14 +++++++---
>  target/mips/tcg/system/tlb_helper.c |  2 +-
>  7 files changed, 61 insertions(+), 25 deletions(-)
> 
> -- 
> 2.47.1
> 

Reviewed-by: Anton Johansson <anjo@rev.ng>