From patchwork Thu Oct 3 14:00:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 832389 Delivered-To: patch@linaro.org Received: by 2002:adf:8b52:0:b0:367:895a:4699 with SMTP id v18csp277440wra; Thu, 3 Oct 2024 07:01:18 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUa1JfG5/AM8MDPZ4ygS7e2+5On2m/pepcq+sX1UTBHYc1cNYD0TDtXhjPS0P7fe1A2AkJVIg==@linaro.org X-Google-Smtp-Source: AGHT+IGCeXh106Ym6+/a2FAa2W+E9FnWyeRsLBi7KXlrGkUhcKTrqMNuhsaFRnfP/LGaY6VH3Whf X-Received: by 2002:a05:6122:32c2:b0:50c:4eb7:90ef with SMTP id 71dfb90a1353d-50c5813a57bmr5355377e0c.4.1727964067227; Thu, 03 Oct 2024 07:01:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727964067; cv=none; d=google.com; s=arc-20240605; b=Vu2otGrhVRGLSU+RJ1oA/C1M4K2XvKIDyzGMuMfwKmqGkpxVIjsRzE0gm8to9zJDvP KCAjZI9fFhMVyHP06nKBVXXhLcGk8UVb2Ms6LPITu07hhjFAAQIvK3lt8KIU2GHHo/el 4w40aZB4iWd4cqU4dxc0QtC2r2HsATGfhP7J8Sy0eQuwEeL1ILSbVqnm6PlqtjEmcvbG Koh9lAFOMonI9Qq6/jSEDpenQcWJW6Y2ou56sfD6eb+5N2C9Dw1ZCkSYiaY1Uv9L3J2E LLQQRJz03fUQeVX8TskoeCjWjBQf1y2h2mBqHe4KdPw3o3fyQIY9uvmemI3FZtFZW7uZ FFdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=Pv5cgA5tzehOzZwhcqZ8BLb8c5W4q5Yxc57Fkm02PHw=; fh=CK/qNOnYmpPVBV462x4bGxZvvvD3l6GkOCMpf/fX+oE=; b=EI7LReI8+ZJoqoBNS+u6Iwq5Fs2Z1+7o3rEXz9VW3TiqKdG5x1FXGx4FNW79giuOk+ fnOANUtLri5hbwfOceTxQu3m8ky1SIbreweoygJLHlbGUf64bA/cX3suzxxvB0puodKX MouXl360J5HupVTa1/JGcjGQA7B+eqb1lyrzs5YppqUR3ffbA4gU4lis5HQTQBOAW9Jd kQgoNERgPhs/lbYxw0dRDLd61Z/sJOQ7JA7pCSQLUeG4tSGGqhkc4G2+H7xhXVno2U5u Sy43hDopEUQ98KaUWawAiAQsrWh877aq4CuGodanhrNLxOT6H6tECOadMzsyFe875aBK 2L0w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jlH4uxJj; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 71dfb90a1353d-50c72c1bbd6si194517e0c.125.2024.10.03.07.01.06 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Oct 2024 07:01:06 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jlH4uxJj; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1swMNX-000473-Tf; Thu, 03 Oct 2024 10:00:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swMNN-00046c-CB for qemu-devel@nongnu.org; Thu, 03 Oct 2024 10:00:18 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1swMNK-0002qf-2S for qemu-devel@nongnu.org; Thu, 03 Oct 2024 10:00:16 -0400 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-37ccfada422so658132f8f.2 for ; Thu, 03 Oct 2024 07:00:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1727964012; x=1728568812; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Pv5cgA5tzehOzZwhcqZ8BLb8c5W4q5Yxc57Fkm02PHw=; b=jlH4uxJjZwzeD4eCeQGQkwjo2S6US9lqh/lubGv2ipoY9BNwiZtJbCIFiZYVIv4rdG mjYC6lNgFMUii+NT5XxRgECDAWoz5AZhWvpIjVN/5LTpeCmWFCBR+6Lp8uaTUzqUfGL3 VAXWQ2k05gAKmCrybaGCoeszhxGoXR5ksJy7TMGyup2SBKFNvgH1XrAdbOBw8UmApOtW sKL8YilT6sTtls+nAkMoa3Uq3GSD6z1UkzORB0JAAflEvhrxKlnzNvWEJPA5cs3xNCH2 HqIlvfNo1v6fYNEuKAJf0/8Q10cU0Eg4fCEoF8bkJNQvtlsLvC22Bwhsc4H5wMHTjnzE Enug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727964012; x=1728568812; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Pv5cgA5tzehOzZwhcqZ8BLb8c5W4q5Yxc57Fkm02PHw=; b=PPRxohx+PiWIixJjGeWPfWvuRLHDrIcuJF8nIGSMDwAwB7mMvUmXlpKOzp+YdV0e/G Is+/RsOWPPI6MY/gNP2gyYUToNzcQ3tboJOVPg91ayzyeTDXb/iWW9ktD0gyBr2RwvUb 6XECUuF7loVZlVizMzFsDJh3npWfvO7ddSoNmfcSFIBskh5ZbayiP5NX3CK4LtEJKjCa ftDrXV7CO5MqLO3k+7Y9Odh+FBQpXjKvQ0dOQGodjaR8DOsHeW37BbrAMbu/sZdn64Vs jxZlGbTneuKatYDF4TI4G5qwJBXorg8qUVi6MJBbxHpNoUqep3bLqGXFihRQTEyZYju/ dEdQ== X-Forwarded-Encrypted: i=1; AJvYcCUdo5QdcX26hJ8p1z4dvpzn+HxRJI37GYWA8sknJITGl4Dsg80xTWd3wfRSvlKTr3zLwLlwcCius6BY@nongnu.org X-Gm-Message-State: AOJu0Yw+Uaelwy0z+TrGkV3gzFusVX8kpZK31DsVHQRi0/cEn4r4s4Pk KPzquKLvRzOF4AEnifSokrTsgzBJoirAcz6YV6z2lqed+wlt+qAz5cxtbdnU1qg= X-Received: by 2002:a5d:584c:0:b0:377:6073:48df with SMTP id ffacd0b85a97d-37cfba1832amr5298622f8f.58.1727964012190; Thu, 03 Oct 2024 07:00:12 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d0822bc38sm1340255f8f.45.2024.10.03.07.00.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Oct 2024 07:00:11 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Guenter Roeck , Paolo Bonzini Subject: [PATCH v2 0/6] arm: drop last bits from deprecated boards Date: Thu, 3 Oct 2024 15:00:04 +0100 Message-Id: <20241003140010.1653808-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org This series is the remaining patches not yet applied from my "arm: Drop deprecated boards" series; this is essentially the device removals which didn't get review in that series and/or which had some discussion about whether we should remove them. To summarise the remaining removals: * max1110 and max1111 are SSI devices so in theory could be created by users on the command line. However I found no evidence of doing this when I did a web search for "device max1110", and the utility of doing so is unclear to me since it's not possible for the command line device to have its ADC inputs or its interrupt line output wired up to anything. * max7310 is an I2C GPIO controller, so it has the same "in theory a user could create this on the command line but in practice it's pretty useless because there's no way to wire up the GPIO lines to anything" status. * the microdrive device can only be used with our PCMCIA bus emulation, and we no longer have any boards using that, so I think these are uncontroversially deleteable. Some boards we still have should in theory have a PCMCIA controller (strongarm, kzm, sh7750), but we don't model those controllers and none of those boards are sufficiently interesting or active that it's likely anybody will ever add one. * The ECC code is entirely unused now; this is an uncontroversial removal of dead code, and I only didn't put it in my pullreq because it wasn't reviewed yet. * Consensus on the v1 series was that we could get rid of -portrait/-rotate even though in theory you could use them on a non-pxa2xx machine type to achieve the odd effect of rotating mouse input. I've added a section to removed-features.rst about this and beefed up the patch commit message. Of these, I think we should definitely be dropping microdrive, pcmcia, ecc, and the portrait/rotate options, and I didn't hear any dissenting opinions on v1. For max111x and max7310: these are fairly small (a couple of hundred lines each) and not too badly behind the curve for code quality/API usage (in particular they're both QOM devices), so I could fairly easily be persuaded that they should stay. However I would like in that case to see: (a) what's the use case/user ? (e.g. examples of "I'm actually using this on the command line, like this" or "I'm using this in the machine model I plan to submit in the next six months") (b) some kind of testing of them (which we can write based on the answer to a.) thanks -- PMM Peter Maydell (6): hw/adc: Remove MAX111X device hw/gpio: Remove MAX7310 device hw/ide: Remove DSCM-1XXXX microdrive device model hw: Remove PCMCIA subsystem hw/block: Remove ecc vl.c: Remove pxa2xx-specific -portrait and -rotate options docs/about/removed-features.rst | 22 ++ include/hw/adc/max111x.h | 56 --- include/hw/block/flash.h | 11 - include/hw/pcmcia.h | 66 ---- include/sysemu/sysemu.h | 1 - hw/adc/max111x.c | 236 ------------ hw/block/ecc.c | 91 ----- hw/gpio/max7310.c | 217 ----------- hw/ide/microdrive.c | 644 -------------------------------- hw/pcmcia/pcmcia.c | 24 -- system/globals.c | 1 - system/vl.c | 11 - ui/input.c | 36 -- hw/Kconfig | 1 - hw/adc/Kconfig | 3 - hw/adc/meson.build | 1 - hw/arm/Kconfig | 1 - hw/block/Kconfig | 3 - hw/block/meson.build | 1 - hw/gpio/Kconfig | 4 - hw/gpio/meson.build | 1 - hw/ide/Kconfig | 6 - hw/ide/meson.build | 1 - hw/meson.build | 1 - hw/misc/Kconfig | 1 - hw/pcmcia/Kconfig | 2 - hw/pcmcia/meson.build | 1 - qemu-options.hx | 16 - 28 files changed, 22 insertions(+), 1437 deletions(-) delete mode 100644 include/hw/adc/max111x.h delete mode 100644 include/hw/pcmcia.h delete mode 100644 hw/adc/max111x.c delete mode 100644 hw/block/ecc.c delete mode 100644 hw/gpio/max7310.c delete mode 100644 hw/ide/microdrive.c delete mode 100644 hw/pcmcia/pcmcia.c delete mode 100644 hw/pcmcia/Kconfig delete mode 100644 hw/pcmcia/meson.build