mbox series

[0/2] tests/qtest: Fix problems running with make vm-build-openbsd

Message ID 20240905165554.320577-1-peter.maydell@linaro.org
Headers show
Series tests/qtest: Fix problems running with make vm-build-openbsd | expand

Message

Peter Maydell Sept. 5, 2024, 4:55 p.m. UTC 
I noticed that 'make vm-build-openbsd' had bitrotted a bit:
 * two tests for the stm32l4x5 forgot a qtest_quit(), which meant
   they would pass all their subtests but then timeout because the
   underlying QEMU process never exited
 * the ahci-test timeout was a bit aggressive

This patchset fixes these.

thanks
-- PMM

Peter Maydell (2):
  tests/qtest: Add missing qtest_quit() to stm32 tests
  tests/qtest: Bump timeout on ahci-test

 tests/qtest/dm163-test.c           | 2 ++
 tests/qtest/stm32l4x5_usart-test.c | 2 ++
 tests/qtest/meson.build            | 1 +
 3 files changed, 5 insertions(+)

Comments

Peter Maydell Sept. 6, 2024, 2:28 p.m. UTC | #1 
On Thu, 5 Sept 2024 at 17:55, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> I noticed that 'make vm-build-openbsd' had bitrotted a bit:
>  * two tests for the stm32l4x5 forgot a qtest_quit(), which meant
>    they would pass all their subtests but then timeout because the
>    underlying QEMU process never exited
>  * the ahci-test timeout was a bit aggressive
>
> This patchset fixes these.
>
> thanks
> -- PMM
>
> Peter Maydell (2):
>   tests/qtest: Add missing qtest_quit() to stm32 tests
>   tests/qtest: Bump timeout on ahci-test

I've applied these directly to master to fix the
test failures when I apply a pullreq.

thanks
-- PMM