mbox series

[for-9.2,0/6] arm: xlnx: fix minor memory leaks

Message ID 20240822162127.705879-1-peter.maydell@linaro.org
Headers show
Series arm: xlnx: fix minor memory leaks | expand

Message

Peter Maydell Aug. 22, 2024, 4:21 p.m. UTC 
This patchset fixes a collection of minor memory leaks in
various xlnx devices, all detected by clang LeakSanitizer
when running 'make check'. Since these are longstanding
and not very important leaks, this is 9.2 material.

thanks
-- PMM

Peter Maydell (6):
  hw/misc/xlnx-versal-cfu: destroy fifo in finalize
  hw/misc/xlnx-versal-trng: Free s->prng in finalize, not unrealize
  hw/nvram/xlnx-bbram: Call register_finalize_block
  hw/nvram/xlnx-zynqmp-efuse: Call register_finalize_block
  hw/misc/xlnx-versal-trng: Call register_finalize_block
  hm/nvram/xlnx-versal-efuse-ctrl: Call register_finalize_block

 include/hw/misc/xlnx-versal-trng.h   |  1 +
 include/hw/nvram/xlnx-bbram.h        |  1 +
 include/hw/nvram/xlnx-versal-efuse.h |  1 +
 include/hw/nvram/xlnx-zynqmp-efuse.h |  1 +
 hw/misc/xlnx-versal-cfu.c            |  8 ++++++++
 hw/misc/xlnx-versal-trng.c           | 12 ++++++------
 hw/nvram/xlnx-bbram.c                | 13 ++++++++++---
 hw/nvram/xlnx-versal-efuse-ctrl.c    |  6 +++---
 hw/nvram/xlnx-zynqmp-efuse.c         | 13 ++++++++++---
 9 files changed, 41 insertions(+), 15 deletions(-)

Comments

Edgar E. Iglesias Aug. 23, 2024, 10:02 a.m. UTC | #1 
On Thu, Aug 22, 2024 at 6:21 PM Peter Maydell <peter.maydell@linaro.org>
wrote:

> This patchset fixes a collection of minor memory leaks in
> various xlnx devices, all detected by clang LeakSanitizer
> when running 'make check'. Since these are longstanding
> and not very important leaks, this is 9.2 material.
>
>
All of it looks good to me:
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@amd.com>



> thanks
> -- PMM
>
> Peter Maydell (6):
>   hw/misc/xlnx-versal-cfu: destroy fifo in finalize
>   hw/misc/xlnx-versal-trng: Free s->prng in finalize, not unrealize
>   hw/nvram/xlnx-bbram: Call register_finalize_block
>   hw/nvram/xlnx-zynqmp-efuse: Call register_finalize_block
>   hw/misc/xlnx-versal-trng: Call register_finalize_block
>   hm/nvram/xlnx-versal-efuse-ctrl: Call register_finalize_block
>
>  include/hw/misc/xlnx-versal-trng.h   |  1 +
>  include/hw/nvram/xlnx-bbram.h        |  1 +
>  include/hw/nvram/xlnx-versal-efuse.h |  1 +
>  include/hw/nvram/xlnx-zynqmp-efuse.h |  1 +
>  hw/misc/xlnx-versal-cfu.c            |  8 ++++++++
>  hw/misc/xlnx-versal-trng.c           | 12 ++++++------
>  hw/nvram/xlnx-bbram.c                | 13 ++++++++++---
>  hw/nvram/xlnx-versal-efuse-ctrl.c    |  6 +++---
>  hw/nvram/xlnx-zynqmp-efuse.c         | 13 ++++++++++---
>  9 files changed, 41 insertions(+), 15 deletions(-)
>
> --
> 2.34.1
>
>