mbox series

[0/2] target/i386: Fix carry flag for BLSI

Message ID 20240801075845.573075-1-richard.henderson@linaro.org
Headers show
Series target/i386: Fix carry flag for BLSI | expand

Message

Richard Henderson Aug. 1, 2024, 7:58 a.m. UTC 
Fix #2175.

r~

Richard Henderson (2):
  target/i386: Split out gen_prepare_val_nz
  target/i386: Fix carry flag for BLSI

 target/i386/cpu.h                        |  5 +++++
 target/i386/tcg/cc_helper.c              | 18 ++++++++++++++++
 target/i386/tcg/translate.c              | 27 +++++++++++++++++-------
 tests/tcg/x86_64/test-2175.c             | 24 +++++++++++++++++++++
 target/i386/tcg/cc_helper_template.h.inc | 18 ++++++++++++++++
 target/i386/tcg/emit.c.inc               |  2 +-
 tests/tcg/x86_64/Makefile.target         |  1 +
 7 files changed, 86 insertions(+), 9 deletions(-)
 create mode 100644 tests/tcg/x86_64/test-2175.c

Comments

Richard Henderson Aug. 7, 2024, 5:41 a.m. UTC | #1 
On 8/1/24 17:58, Richard Henderson wrote:
> Fix #2175.
> 
> r~
> 
> Richard Henderson (2):
>    target/i386: Split out gen_prepare_val_nz
>    target/i386: Fix carry flag for BLSI
> 
>   target/i386/cpu.h                        |  5 +++++
>   target/i386/tcg/cc_helper.c              | 18 ++++++++++++++++
>   target/i386/tcg/translate.c              | 27 +++++++++++++++++-------
>   tests/tcg/x86_64/test-2175.c             | 24 +++++++++++++++++++++
>   target/i386/tcg/cc_helper_template.h.inc | 18 ++++++++++++++++
>   target/i386/tcg/emit.c.inc               |  2 +-
>   tests/tcg/x86_64/Makefile.target         |  1 +
>   7 files changed, 86 insertions(+), 9 deletions(-)
>   create mode 100644 tests/tcg/x86_64/test-2175.c
> 

Ping.


r~
Philippe Mathieu-Daudé Aug. 7, 2024, 4:49 p.m. UTC | #2 
On 7/8/24 07:41, Richard Henderson wrote:
> On 8/1/24 17:58, Richard Henderson wrote:
>> Fix #2175.
>>
>> r~
>>
>> Richard Henderson (2):
>>    target/i386: Split out gen_prepare_val_nz
>>    target/i386: Fix carry flag for BLSI
>>
>>   target/i386/cpu.h                        |  5 +++++
>>   target/i386/tcg/cc_helper.c              | 18 ++++++++++++++++
>>   target/i386/tcg/translate.c              | 27 +++++++++++++++++-------
>>   tests/tcg/x86_64/test-2175.c             | 24 +++++++++++++++++++++
>>   target/i386/tcg/cc_helper_template.h.inc | 18 ++++++++++++++++
>>   target/i386/tcg/emit.c.inc               |  2 +-
>>   tests/tcg/x86_64/Makefile.target         |  1 +
>>   7 files changed, 86 insertions(+), 9 deletions(-)
>>   create mode 100644 tests/tcg/x86_64/test-2175.c
>>
> 
> Ping.

Too x86 specific so I'll pass for now, sorry :(
Richard Henderson Aug. 14, 2024, 10:31 a.m. UTC | #3 
On 8/7/24 15:41, Richard Henderson wrote:
> On 8/1/24 17:58, Richard Henderson wrote:
>> Fix #2175.
>>
>> r~
>>
>> Richard Henderson (2):
>>    target/i386: Split out gen_prepare_val_nz
>>    target/i386: Fix carry flag for BLSI
>>
>>   target/i386/cpu.h                        |  5 +++++
>>   target/i386/tcg/cc_helper.c              | 18 ++++++++++++++++
>>   target/i386/tcg/translate.c              | 27 +++++++++++++++++-------
>>   tests/tcg/x86_64/test-2175.c             | 24 +++++++++++++++++++++
>>   target/i386/tcg/cc_helper_template.h.inc | 18 ++++++++++++++++
>>   target/i386/tcg/emit.c.inc               |  2 +-
>>   tests/tcg/x86_64/Makefile.target         |  1 +
>>   7 files changed, 86 insertions(+), 9 deletions(-)
>>   create mode 100644 tests/tcg/x86_64/test-2175.c
>>
> 
> Ping.

Ping 2.


r~