| Message ID | 20240507123025.93391-1-philmd@linaro.org |
|---|---|
| Headers | show |
| Series | system/physmem: Propagate AddressSpace to MapClient helpers | expand |
On Tue, May 7, 2024 at 2:30 PM Philippe Mathieu-Daudé <philmd@linaro.org> wrote: > > Respin of Mattias patch [1 split to ease review. > Preliminary use QEMU_LOCK_GUARD to simplify. > > I'm OK to include this and the endianness fix [2] > if Mattias agrees, once first patch is reviewed. To be honest, given that this patch series has been lingering for almost a year now, I'm fine with whatever gets us closer to getting this landed. I believe Peter was also considering doing a pull request for the series, so you may want to coordinate with him if you haven't already. > > > Regards, > > Phil. > > [1 https://lore.kernel.org/qemu-devel/20240507094210.300566-2-mnissler@rivosinc.com/ > [2] https://lore.kernel.org/qemu-devel/20240507094210.300566-6-mnissler@rivosinc.com/ > > Mattias Nissler (2): > system/physmem: Propagate AddressSpace to MapClient helpers > system/physmem: Per-AddressSpace bounce buffering > > Philippe Mathieu-Daudé (1): > system/physmem: Replace qemu_mutex_lock() calls with QEMU_LOCK_GUARD > > include/exec/cpu-common.h | 2 - > include/exec/memory.h | 45 +++++++++++++++++- > system/dma-helpers.c | 4 +- > system/memory.c | 7 +++ > system/physmem.c | 98 +++++++++++++++------------------------ > 5 files changed, 90 insertions(+), 66 deletions(-) > > -- > 2.41.0 >
On 7/5/24 14:47, Mattias Nissler wrote: > On Tue, May 7, 2024 at 2:30 PM Philippe Mathieu-Daudé <philmd@linaro.org> wrote: >> >> Respin of Mattias patch [1 split to ease review. >> Preliminary use QEMU_LOCK_GUARD to simplify. >> >> I'm OK to include this and the endianness fix [2] >> if Mattias agrees, once first patch is reviewed. > > To be honest, given that this patch series has been lingering for > almost a year now, I'm fine with whatever gets us closer to getting > this landed. I believe Peter was also considering doing a pull request > for the series, so you may want to coordinate with him if you haven't > already. Well I'm sorry, today is the first time I've been looking at it, and was trying to help reviewing. I see I was Cc'ed on earlier versions but missed them. OK, I'll see with Peter. Phil.
On Tue, May 7, 2024 at 4:02 PM Philippe Mathieu-Daudé <philmd@linaro.org> wrote: > > On 7/5/24 14:47, Mattias Nissler wrote: > > On Tue, May 7, 2024 at 2:30 PM Philippe Mathieu-Daudé <philmd@linaro.org> wrote: > >> > >> Respin of Mattias patch [1 split to ease review. > >> Preliminary use QEMU_LOCK_GUARD to simplify. > >> > >> I'm OK to include this and the endianness fix [2] > >> if Mattias agrees, once first patch is reviewed. > > > > To be honest, given that this patch series has been lingering for > > almost a year now, I'm fine with whatever gets us closer to getting > > this landed. I believe Peter was also considering doing a pull request > > for the series, so you may want to coordinate with him if you haven't > > already. > > Well I'm sorry, today is the first time I've been looking at it, > and was trying to help reviewing. I see I was Cc'ed on earlier > versions but missed them. OK, I'll see with Peter. It's fine, sorry for being a bit negative.