From patchwork Tue Apr 9 13:37:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 787202 Delivered-To: patch@linaro.org Received: by 2002:adf:fdd2:0:b0:346:15ad:a2a with SMTP id i18csp221549wrs; Tue, 9 Apr 2024 06:39:07 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXPhFQ+3EWihM6vsaIdyC8wAPVuGNJhicKvyIwbfpAyc+m/Xf9NTUF8o5Ba96Almv52LB+8QLJmb8lckcnLTqnH X-Google-Smtp-Source: AGHT+IHHqEWHrIFrVOlawR0RPJxZLl/k8+k+UPzGq9rNa2sDUgCxJepWdZTJnDL4sY7SCP/Ni/43 X-Received: by 2002:a05:6214:d06:b0:699:1ece:9def with SMTP id 6-20020a0562140d0600b006991ece9defmr4028443qvh.22.1712669947339; Tue, 09 Apr 2024 06:39:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1712669947; cv=none; d=google.com; s=arc-20160816; b=q7IHRwDF3+WlZrZsfWB2Z2oEVd8SAvCfKh2h/me4LGJ7FI6L6zHChocaT8RYHK4P+6 kvYTuIqn4s7B5cw/qtAnAWS49TSJEGzi2ru3DVqGN6FmvK+XXpbkRxTHBQjjSinR/zTN 6FyROFTO79WYEwBw3yy+76kUQbccxal6FK1foCzSFHVsblulCvKeqvOk284tYYw0lGSF A2DWrSo/b9fXswIU4FLxVOqAb7wejAyGZiHXQBO65T8+wNzYoudNZMgcA+y+Kvo+IJcC +VJ9rWvBD8p0W3OPR+5qKUnsJcnJEPL4eus6XsRVwquNCWe80TmFOOWlyd5MDFiDNbM8 lgmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=vC3gmGFS//wOnrZqSqcK6FVhjByf7WW2EZPOHgM5S+0=; fh=QOl9Xi9nQ721K4qxGgLCqy+fNk/yfBHdpOYFmb4mu2g=; b=LqH9lUFP13K7DWnT8mX0oPyGwBlbX1xaxwpPe9WIrTHeTh1mgjra1TizcAoAWf9pV7 Xxe2RzJiheTqJ8cWy3LuEkADwcQnCB1J1Sh35o79uMpnZ3jti+J1lglqnJ5pPulUI3kE 88mGhzzdqYM2cq8XNQMLgsDyZR2s8B0MZS9PSrTZYtmiMiU+BZrWF917Kb/nxzU/0aXL pdCMHjjvSNGlBOO61676pMRNXY5ApznHM7o8CzBsJGwqHg86V1t8gFsoCs3O9OLbDkdk rXchLrTcIFxEFlvfi7xon9nSQJgi0uLmEiuXGsh7n1autlW5BaM4CV9+LYJjRLZ6tCPF aTUw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ns31C5AE; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id j2-20020a0cae82000000b006967a8daf00si10285374qvd.78.2024.04.09.06.39.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Apr 2024 06:39:07 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ns31C5AE; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ruBfs-0005mH-Op; Tue, 09 Apr 2024 09:38:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ruBfr-0005lw-Bg for qemu-devel@nongnu.org; Tue, 09 Apr 2024 09:38:07 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ruBfp-0008AA-N6 for qemu-devel@nongnu.org; Tue, 09 Apr 2024 09:38:07 -0400 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-343bccc0b2cso4086314f8f.1 for ; Tue, 09 Apr 2024 06:38:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712669884; x=1713274684; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vC3gmGFS//wOnrZqSqcK6FVhjByf7WW2EZPOHgM5S+0=; b=Ns31C5AE2r0CgJit01MP77FDt3WX9hYin4EO+OrHAVNoUORdE2elo+Ywt7p4XWljQO ImMz9LpekzwcOkydDu0dDFLcxTHTaFZOUbZIwrmq0voZ5lJsjGtTsiinKP1okDPdNS7M icUYO//FeAhphweoCha9RXEc8LHsAHgzThLwjLV9f6NSothG4IyVfPKUeny7wY41EMhf PCcZqlMY63YNJY66qJN5u/JlTihHHFzXAZGP87dUIOqCspwCAR9vTa0FJxI6YGXSe2Eg vwbkYVUSidqx4GJDZd9RMmKwcFCEGNpgEQueaWDyi00uZ2/l/L41Bo8XJ9HKzClnGsRA rf2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712669884; x=1713274684; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vC3gmGFS//wOnrZqSqcK6FVhjByf7WW2EZPOHgM5S+0=; b=uZrtPecDoCns2Bopq6rQ1Na2y0oYiiMlpSpucFqKD+R911cLFzm1RRKzLrR5YaaMaz VY+4wrhzBK6Uoc8f28W5m2rEVB9lbP6RawvnDPBygeJTs5Shlbhy/wKYL+XdEfFrFJIi AVz2gFVH4qtwlkQH8a0J8tzjNzmIYNCv4HTumGNwAEtvQ2rHj0/DUTQrj99QNiqzTKBy XMRJao6pDwoxvF9TuiCOB0gu3CoLaNueCJsPwkL+GpVPxMEXjh9QGMemNhdTGHc4DI5u 0592Ufvm6IF1cZzdfAYsghCPo2SBqio5jfSG5KQsT7VzU8zYCF66pwJa0nVuH0bY+DIL jBBg== X-Gm-Message-State: AOJu0YyE6NPzV+CrKM+FZmbWNTRoRQZYcS9LG+5+eky9iDqm1O/7Zdo5 bwMP7XVszAxyPsIrrDgZNstEI6ub6lJIQSYi8gkqeHqM6gALsSMVFuUsx7E+l3naTmayzQpodoa Q X-Received: by 2002:a05:6000:544:b0:346:311c:32f1 with SMTP id b4-20020a056000054400b00346311c32f1mr1308231wrf.50.1712669883810; Tue, 09 Apr 2024 06:38:03 -0700 (PDT) Received: from m1x-phil.lan ([176.176.160.134]) by smtp.gmail.com with ESMTPSA id p9-20020adff209000000b003432d61d6b7sm11468603wro.51.2024.04.09.06.38.02 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 09 Apr 2024 06:38:03 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chuhong Yuan , Jason Wang , Alexander Bulekov , qemu-arm@nongnu.org, =?utf-8?q?Philippe_?= =?utf-8?q?Mathieu-Daud=C3=A9?= Subject: [PATCH-for-9.0 v2 00/11] hw/net/lan9118: Fix overflow in TX FIFO Date: Tue, 9 Apr 2024 15:37:49 +0200 Message-ID: <20240409133801.23503-1-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=philmd@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Fix for https://gitlab.com/qemu-project/qemu/-/issues/2267 Since v1: - Renamed definition as MIL_TXFIFO_SIZE - Addressed Peter review comments in patches 1 & 2 (add comment, return TXE INT) - Trivial patches while digesting Peter's analysis [*] More work expected during 9.1. [*] https://lore.kernel.org/qemu-devel/CAFEAcA8vvURMn2FaDP9tXtP5eCMs6-XFOCR9ypo=WBH+6g5prw@mail.gmail.com/ Philippe Mathieu-Daudé (11): hw/net/lan9118: Replace magic '2048' value by MIL_TXFIFO_SIZE definition hw/net/lan9118: Fix overflow in MIL TX FIFO hw/net/lan9118: Remove duplicated assignment hw/net/lan9118: Replace magic '5' value by TX_FIF_SZ_RESET definition hw/net/lan9118: Add definitions for FIFO allocated sizes hw/net/lan9118: Use TX_DATA_FIFO_BYTES definition hw/net/lan9118: Rename tx_fifo_size -> tx_fifo_bytes hw/net/lan9118: Use RX_STATUS_FIFO_BYTES definition hw/net/lan9118: Rename rx_status_fifo_size -> rx_status_fifo_wordcount hw/net/lan9118: Use RX_DATA_FIFO_BYTES definition hw/net/lan9118: Rename rx_fifo_size -> rx_fifo_wordcount hw/net/lan9118.c | 104 +++++++++++++++++++++++++++++++---------------- 1 file changed, 70 insertions(+), 34 deletions(-)