From patchwork Tue Mar 12 18:38:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 779770 Delivered-To: patch@linaro.org Received: by 2002:a5d:604e:0:b0:33e:7753:30bd with SMTP id j14csp2168047wrt; Tue, 12 Mar 2024 11:39:16 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCU0mAxZ0Fhgy5GKx0OVrTcjsyXhKNkYqfXtRseDbs7NfGbYHETw4MaY+HJm1D9IH3RtCm9rHlu8T+/8A69ltHUC X-Google-Smtp-Source: AGHT+IEXuCZ4nP4dcoLTBHjbnS7iuDkVYN0KZZbBbnwgpvcc2w02/7TYiCL3Pzd3MY5aEIPtnrGI X-Received: by 2002:a05:6808:10cb:b0:3c1:cb68:1e87 with SMTP id s11-20020a05680810cb00b003c1cb681e87mr2911362ois.41.1710268755815; Tue, 12 Mar 2024 11:39:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1710268755; cv=none; d=google.com; s=arc-20160816; b=qsmoiq/DpoBNoHaCY97MEw64wwi8Y3XWpWxSI9Sr5UqQmfTZFF4YpxJiJqVFpo8zPO fDwl1vpPCJV3j6fbqPL0j/7+8p5HXPT/v/5aJgBI6f/VadNlLoziH1a/K9fdHk8fM2EX j5BJ/Zxsryr46Y5sguDeoNY+LqhLAYNzaEElHZ4TRalk4YTprVWqR5d/2YlwdrATVTAS 3jqesCAB7SNTvlRpvvxHQoZlI+uVNinQHTWkJ9696FRbIv8Wn5Ejw3uvppPCtUvaReDi aFsZYV9oJ3/150YG6t3M1Ecod3hGLnfMj5drVSd2M6UL3oY9aV9KcuKwaCQpYzA+0+RA xSew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:dkim-signature; bh=4gPCByx8mAmPa3WgEs07nx3Ff/naJHLFmK+kpZLMiRY=; fh=PnYt+qEB9tAfMKoqBm2xjKOFpYyFFGPudh5cVIoieJM=; b=z/m6tEq1uWZNGo0quSH46a3pw11hU+jNdnACWi0KrKQmkCjX576CvdIfPPG48Yj9j8 lYF1wEZ1VixTY9OwlwsS3As3uA19kiF9+4fa+8NRq9OflXrxPjI8crSxSoBnKTsn/kOB uh7xZmyfjaxA7G1Wr6G5LS6/ouCYor0yVuaqMHr+ySUvGNYjlji9A8LUL6iOAxdBMsip XDCgw4WpXVRhAz66EosleNX7uLGAUzj56S8uLywu9URohVeagEmcl7OWQ3rNOTLSt3vl vAleo5b0BMk2MBat3Hbcmw+M6Yc+joDRP3LYK2yo0GW74ixwGpn8g/v5Fa8iG9G/iO2d kzOA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bTP0Ep5b; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id s7-20020a05622a178700b0042ef2fb6a35si8160519qtk.360.2024.03.12.11.39.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Mar 2024 11:39:15 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bTP0Ep5b; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rk711-0003N1-3C; Tue, 12 Mar 2024 14:38:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rk70x-0003MR-HN for qemu-devel@nongnu.org; Tue, 12 Mar 2024 14:38:15 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rk70v-0000c5-Fp for qemu-devel@nongnu.org; Tue, 12 Mar 2024 14:38:15 -0400 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-41331166961so8584225e9.1 for ; Tue, 12 Mar 2024 11:38:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710268691; x=1710873491; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=4gPCByx8mAmPa3WgEs07nx3Ff/naJHLFmK+kpZLMiRY=; b=bTP0Ep5b0C4QE5i4b/f9ebCKKS6ilIrhQJHrSePMYIviVi95d3/gWeVCOg6clt3MJp xO2DbkjuqxVBkzlXdvx/qI5X2NUErt5T37dPqTLxciGYhk8v5Vy7aM4Vn01mkvtLq14K Asa1WtLb53TLAfmqeWotiuvJV6Dbcr2jiJ5mjy0SwO9dPAI7VDmUDA/aO37Pp8T1BxWB P/X2edtreZPc0zU2DydJjtMKmzQwpYpEqJloThD6caqXn2fkBrw0wWhLuzRm62SCFALH c6O5zp3KgLXt8TwFCDGQ09Z77ZuavOQ8H0VwoxpBLxWX03fnCwXu4DKS1xStsFnj0fFF 4qjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710268691; x=1710873491; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4gPCByx8mAmPa3WgEs07nx3Ff/naJHLFmK+kpZLMiRY=; b=Cl+rY1WEH9W5zZnNLHq/yGWQYJPW6vebisLiz4QEdRaTwuAMgBYfgfz4AxFXOd9emT gZH8RgEpVIuqNexg48uUOkVAWMPgGXIImEsdc+S3KJOsV+m5QmxhjnS9n0fenqaMrgDR JEqIz5x1fKiHNR+DIMu5I84KIh3JepNMKZikPVkC9x8qnr60gSjMDVZ4SWeca7m5p1MZ i6AtiQxBb+mWsruyw5OAmCr8n+MQffwZuuon/R9EuPTAsFaJkCFy0sRCKxNQL0prwqe6 dLXuM429o4srgxjNq60ZHkSFg8GWEYczWlKGlza5W2jQMtANMUzRPcZ5y5S+AZh3QU0C vkAg== X-Gm-Message-State: AOJu0Yz+7O1RPFW83enZXqYFxeYO5kUAKANH90ivJm85hCslex92FJVn 0pJMEC6oXMvxowh5xB/A24xOQJYXL+JCYcP+vgGBmIDZX+au3Q1olWK7MquWSMPALaEnhxSWZhq 0 X-Received: by 2002:a05:600c:1d0e:b0:412:f6ce:8152 with SMTP id l14-20020a05600c1d0e00b00412f6ce8152mr7656123wms.31.1710268691506; Tue, 12 Mar 2024 11:38:11 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id v17-20020a05600c471100b00412ee8e2f2asm19836337wmo.9.2024.03.12.11.38.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 11:38:11 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH 0/7] various: 7 minor Coverity fixes Date: Tue, 12 Mar 2024 18:38:03 +0000 Message-Id: <20240312183810.557768-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org This patchset fixes seven minor Coverity issues: * four minor nits in test code * a happens-once memory leak in the af-xdp netdev * a harmless wrong-bounds-check in pca9554 * add a report-write-errors-to-user in mac_nvram I don't think any of these are worth backporting to stable; I just picked them as easy fixes that reduce the number of open Coverity issues we have. thanks -- PMM Peter Maydell (7): tests/qtest/npcm7xx_emc_test: Don't leak cmd_line tests/unit/socket-helpers: Don't close(-1) net/af-xdp.c: Don't leak sock_fds array in net_init_af_xdp() hw/misc/pca9554: Correct error check bounds in get/set pin functions hw/nvram/mac_nvram: Report failure to write data tests/unit/test-throttle: Avoid unintended integer division tests/qtest/libqtest.c: Check for g_setenv() failure hw/misc/pca9554.c | 4 ++-- hw/nvram/mac_nvram.c | 5 ++++- net/af-xdp.c | 3 +-- tests/qtest/libqtest.c | 6 +++++- tests/qtest/npcm7xx_emc-test.c | 4 ++-- tests/unit/socket-helpers.c | 4 +++- tests/unit/test-throttle.c | 4 ++-- 7 files changed, 19 insertions(+), 11 deletions(-) Reviewed-by: Richard Henderson