From patchwork Thu Oct 19 09:56:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 735529 Delivered-To: patch@linaro.org Received: by 2002:adf:f0cd:0:b0:32d:baff:b0ca with SMTP id x13csp1426818wro; Thu, 19 Oct 2023 02:57:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHj/+ovINJgZoMpkezCAvW9/4zVR6K8iDz/uVRKqm8Fz+lpW5/AV+FR9MoEGfWjFEg/Y/PK X-Received: by 2002:a05:6214:3bc8:b0:66d:2d80:800 with SMTP id ng8-20020a0562143bc800b0066d2d800800mr2088872qvb.7.1697709432704; Thu, 19 Oct 2023 02:57:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697709432; cv=none; d=google.com; s=arc-20160816; b=SJnJjpwQ43qFhE11OZQhWwgZ4dsfWVDgPmS7kn+OTb1+z6EmATMR8FS4HFoU7UEDAa RuhWb4uaiiv/nBZVNUmUKSB7dLix1fThX6M1oNBd8w+T/O56D6evOM1Qh+sz497yYb8T otSLg5X4C3h3KnFA6KpvhH5Hm4UqnHGQLePB7N085Qno/P2Vs7yxPVhrKOTqk5sqTYAT cLftGbtMZAxC8fsiee6yEaMlbzxoMeqV+BPhioqTAN1jZ9RnMz8+b3krFELzssaPrwsP ts0uEao1g0hMjxs+vMCUY9a5PncD605pxl+xbWcpHozW7jw/6hunsyXXrvz+bLccQgc4 SwIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=98S7NRPtEG2gZGbwqDI/I8OEUT2IsSiJuqGaCj8Lgnk=; fh=1w790CBgLcLdIkDw35JqGhdtBYTwXI0w98QYpcKDX3M=; b=u8rDr2t6WL7pcBPDKdv/DSYM6BT+hbZLm0PoTLxfXsR0nmXoTrAkRvP2rUemiOUG05 o2bhUAyIOZjYL0BOnHE/Gyht3wTLtQJ3slu7ru+EwwVmaI7e3dMUOc4P0ySD1ECto8Nh nkKXg0oBK15DZqUb6FROH4tLOYDCM2QcBug/u1zPaX5X08H1vezN+oCazc2p+JcXn7jk 0TQOxcCEhygbBNsOG2mWtqiMomE5QIPEn42GIroAmnq9mW2DStI3+8LG1dhVr2Z1suAY GhqL3znKdZG+pNWjHRgo84V0SgX27GZFEDAbNrpPo9W43i2cAUzccZnZjPDN/I4ut01q mQFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HDGSeuu1; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ld31-20020a056214419f00b0066b0f53b19asi1358194qvb.242.2023.10.19.02.57.12 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Oct 2023 02:57:12 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HDGSeuu1; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qtPlJ-0004zh-LG; Thu, 19 Oct 2023 05:56:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtPlH-0004yx-Kq for qemu-devel@nongnu.org; Thu, 19 Oct 2023 05:56:15 -0400 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qtPlF-0006Qi-P7 for qemu-devel@nongnu.org; Thu, 19 Oct 2023 05:56:15 -0400 Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-507bd19eac8so4193310e87.0 for ; Thu, 19 Oct 2023 02:56:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697709371; x=1698314171; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=98S7NRPtEG2gZGbwqDI/I8OEUT2IsSiJuqGaCj8Lgnk=; b=HDGSeuu1PsO041wBI2mO4GLFRZc4+yJ1L2b1MiUShdEaB8pKv3ii4H2U/RODGgj9xd vpa4qeoOCF7H/tbnPO8acumzv/IZKQlIlfEuOKpjjdyMqzD7no+/PX/D9NDfAzIalMi9 gY5/wyaJQ4kjia/nftd0FsNUg1tnvmwtjUZwL76zoQ4FL/yQe28ENKOhf1qyZJlKNKtG Hh12dC1oZOruRWDG9eoobAXaHqBqXcwsmCGNu1mV1uI3khcBf0N86m4iyZMe6/kvsH/7 c6D8s7nworAaqxMNeOe8zIKKbzXKjPHGJjb2oVZvjWVmoyX5nAdFT5ee7zLHGo7wx4Bb 1h9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697709371; x=1698314171; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=98S7NRPtEG2gZGbwqDI/I8OEUT2IsSiJuqGaCj8Lgnk=; b=dOrgYUQ+56uQHEnTmcnZNA9QjMRnPLEiTsJX2TNyiXKHyRqsZAyFFk8v8bIhksJZ+a 6KqHN5/Z69jYx+eVFZpWrA/sgvq3IErnePOX/kTfoX4CcwN/ZCANU3axNW0kMHoz82F6 o1sek1h20aYHO191B+GHQ6pZgJil0KhiTkGXkD5CstuflH/uHsptpKK2NitQ1vdHF7N4 NldqsXCoI+AS+atnVgzyxxR437oDRWi2Nkfi7bVBPGb2Cocx6N9OH0/P1JALwchbcjJG c2zHgveq2b28e1VgAz7y3vbaFZqL2ONvb0/N9eZwhp731obwOrE8cnSRPNoH3OnnFUPa nNhw== X-Gm-Message-State: AOJu0Yyr1RTaWSypgyh1BGKoje47h0b8126il13t6eJe64hCos1jnevd OXhQyDuZkv0uemGA0iF+uwb1mg== X-Received: by 2002:ac2:530c:0:b0:503:2555:d1e7 with SMTP id c12-20020ac2530c000000b005032555d1e7mr1159361lfh.45.1697709371041; Thu, 19 Oct 2023 02:56:11 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id bg14-20020a05600c3c8e00b00401e32b25adsm4122886wmb.4.2023.10.19.02.56.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 02:56:10 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 45B331FFBB; Thu, 19 Oct 2023 10:56:10 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , virtio-fs@redhat.com, =?utf-8?q?Alex_Benn=C3=A9e?= , Eduardo Habkost , Fam Zheng , Mark Cave-Ayland , qemu-block@nongnu.org, Stefan Hajnoczi , Gerd Hoffmann , Erik Schilling , "Michael S. Tsirkin" , Hanna Reitz , Eric Blake , Kevin Wolf , Jason Wang , Raphael Norwitz , Paolo Bonzini , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Markus Armbruster , Mathieu Poirier , Viresh Kumar , "Gonglei (Arei)" Subject: [PATCH v5 0/6] virtio: cleanup vhost-user-generic and reduce c&p Date: Thu, 19 Oct 2023 10:56:04 +0100 Message-Id: <20231019095610.2818087-1-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::131; envelope-from=alex.bennee@linaro.org; helo=mail-lf1-x131.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org A lot of our vhost-user stubs are large chunks of boilerplate that do (mostly) the same thing. This series continues the cleanups by splitting the vhost-user-base and vhost-user-generic implementations. After adding a new vq_size property the rng, gpio and i2c vhost-user devices become simple specialisations of the common base defining the ID, number of queues and potentially the config handling. I've also added Manos' vhost-user-sound while I was at it. Changes ------- v5 - addressing comments and tags - improved the docs v4 - dropped the F_TRANSPORT work for another series - added vhost-user-sound Alex Bennée (5): virtio: split into vhost-user-base and vhost-user-device hw/virtio: derive vhost-user-rng from vhost-user-base hw/virtio: derive vhost-user-gpio from vhost-user-base hw/virtio: derive vhost-user-i2c from vhost-user-base docs/system: add a basic enumeration of vhost-user devices Manos Pitsidianakis (1): hw/virtio: add vhost-user-snd and virtio-snd-pci devices docs/system/devices/vhost-user-rng.rst | 2 + docs/system/devices/vhost-user.rst | 60 ++- ...{vhost-user-device.h => vhost-user-base.h} | 21 +- include/hw/virtio/vhost-user-gpio.h | 23 +- include/hw/virtio/vhost-user-i2c.h | 14 +- include/hw/virtio/vhost-user-rng.h | 11 +- include/hw/virtio/vhost-user-snd.h | 26 ++ hw/virtio/vhost-user-base.c | 345 +++++++++++++++ hw/virtio/vhost-user-device-pci.c | 10 +- hw/virtio/vhost-user-device.c | 335 +------------- hw/virtio/vhost-user-gpio.c | 407 +----------------- hw/virtio/vhost-user-i2c.c | 272 +----------- hw/virtio/vhost-user-rng.c | 278 +----------- hw/virtio/vhost-user-snd-pci.c | 75 ++++ hw/virtio/vhost-user-snd.c | 67 +++ hw/virtio/Kconfig | 5 + hw/virtio/meson.build | 23 +- 17 files changed, 683 insertions(+), 1291 deletions(-) rename include/hw/virtio/{vhost-user-device.h => vhost-user-base.h} (71%) create mode 100644 include/hw/virtio/vhost-user-snd.h create mode 100644 hw/virtio/vhost-user-base.c create mode 100644 hw/virtio/vhost-user-snd-pci.c create mode 100644 hw/virtio/vhost-user-snd.c