mbox series

[0/4] hw: Minor simplifications using proper QOM getter macros

Message ID 20230523061207.48818-1-philmd@linaro.org
Headers show
Series hw: Minor simplifications using proper QOM getter macros | expand

Message

Philippe Mathieu-Daudé May 23, 2023, 6:12 a.m. UTC 
Enforce QOM style. Besides, using the proper QOM macros
slightly simplifies the code.

Philippe Mathieu-Daudé (4):
  hw/core/cpu: Simplify realize() using MACHINE_GET_CLASS() macro
  hw/i386/microvm: Simplify using object_dynamic_cast()
  hw/pci/pci: Simplify pci_bar_address() using MACHINE_GET_CLASS() macro
  hw/usb/hcd-ehci-pci: Simplify using DEVICE_GET_CLASS() macro

 hw/core/cpu-common.c  | 3 +--
 hw/i386/microvm.c     | 3 +--
 hw/pci/pci.c          | 4 +---
 hw/usb/hcd-ehci-pci.c | 2 +-
 4 files changed, 4 insertions(+), 8 deletions(-)

Comments

Michael Tokarev June 8, 2023, 6:41 p.m. UTC | #1 
23.05.2023 09:12, Philippe Mathieu-Daudé wrote:
> Enforce QOM style. Besides, using the proper QOM macros
> slightly simplifies the code.

Applied to my trivial-patches branch (Maybe it's time to resurrect it).

Thanks,

/mjt
Michael S. Tsirkin June 22, 2023, 8:33 p.m. UTC | #2 
On Thu, Jun 08, 2023 at 09:41:58PM +0300, Michael Tokarev wrote:
> 23.05.2023 09:12, Philippe Mathieu-Daudé wrote:
> > Enforce QOM style. Besides, using the proper QOM macros
> > slightly simplifies the code.
> 
> Applied to my trivial-patches branch (Maybe it's time to resurrect it).
> 
> Thanks,
> 
> /mjt

pci things:

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Michael Tokarev June 23, 2023, 7 a.m. UTC | #3 
22.06.2023 23:33, Michael S. Tsirkin wrote:
> On Thu, Jun 08, 2023 at 09:41:58PM +0300, Michael Tokarev wrote:

>> Applied to my trivial-patches branch (Maybe it's time to resurrect it).

> pci things:
> 
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

It's been merged to master on Jun-11 already. But thank you for the review anyway! :)

/mjt