From patchwork Mon Apr 24 15:27:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 676575 Delivered-To: patch@linaro.org Received: by 2002:a5d:4a41:0:0:0:0:0 with SMTP id v1csp2222063wrs; Mon, 24 Apr 2023 08:29:05 -0700 (PDT) X-Google-Smtp-Source: AKy350Yx6Vs+ukVFmDHABapi6CI53sCoWGdvGRd9TQH5vqEkNhS8nNe0uu+ZBlghynFmFPcEdyF5 X-Received: by 2002:ac8:5786:0:b0:3ef:2c3a:faa3 with SMTP id v6-20020ac85786000000b003ef2c3afaa3mr24778262qta.17.1682350145272; Mon, 24 Apr 2023 08:29:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682350145; cv=none; d=google.com; s=arc-20160816; b=tBMB8B7fdGOY0j8WMbDYzBl2Chmouz+lC3BMvdvePPHmBL1ber3RFMeTdQJGYmnww+ OlOjdacNYV5JK25ZJjKgrku8ywXc9XQXGq4sCjvZJ06tG2M1jGWkg5rp1ZveEhMzQjOb mXGXOQUj+zgVboakG4KPssCbTS/Xzg+ViPthfwz/BsgJK3U+Vbeajntg/CdNkDb9VT+I bqJfz38gcp1ODRGReZHTktaoduyc4nZTwzRwMYVxtiQ/GKxOA0dYezNCpHzZ80S8vrBT XTVGqmOFdKmueV2JpixGrkIEmP7qktFhUBKpAbayfrD7ufEQw5lUF8Hj972kkTjT3PZG iouQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=xSalvfnQsVLK8I+FBXVViucc3wM/l9KF4EOKeg2PWAM=; b=Lo1NewQr7WT7XYmpn0dXIx6oV+Q+OKIgT9aefpJx49aMEsTdWZfQw2yKiUnJan0bZ1 BuwuGW0Ixm7krfovRbdE+nJvohk5U2Zb1YmBsZSLldKRpppUkaGzJE6eXEVviUhcKdU0 Gdh/QW61q7Q6LQRMU83mX0ub/W3BhdzvuH7NHJZlRmAHF81XybLyFffeJt/PwEuNkjtw kNwkTW4f9KJD69zlIKt2kQPSagXnSn8fOYzK9aK3rt5G4ok9MPe1Izn294JXBTR0jSoE xXkH2KYL04CAcVPGhK6Hr/xwrxCrqh/Dy8G2M/KxIrZ4G/b//QvaYgCUxtKLF+bMliI4 NXeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=aLhL1UN5; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id m12-20020a05622a054c00b003ec48dc4622si7370831qtx.673.2023.04.24.08.29.05 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 24 Apr 2023 08:29:05 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=aLhL1UN5; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pqy6K-0006ni-HU; Mon, 24 Apr 2023 11:27:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqy6G-0006kx-E7 for qemu-devel@nongnu.org; Mon, 24 Apr 2023 11:27:32 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pqy64-0006sI-MT for qemu-devel@nongnu.org; Mon, 24 Apr 2023 11:27:32 -0400 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-2fe3fb8e25fso2762975f8f.0 for ; Mon, 24 Apr 2023 08:27:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682350039; x=1684942039; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xSalvfnQsVLK8I+FBXVViucc3wM/l9KF4EOKeg2PWAM=; b=aLhL1UN59zoeWERsyjR2sb2Uiw8sG9JvFRm4FNGE+Koyx6G+UdkE2lvKoDBsSrAXV0 R+PbpY4ZeSZB1vYQdZUm3G0VFfdwSfD8R1hfZtooqkRPIteS75o+XEomYtV7CDdolqd0 3DNmDRWXqn8pE62ku1KXW7GlXOgkROCkbVklVvLzWr3UF96A3Xi62eYxf9eRQb8s6GJB 2mEbzTPXE9ec7sMfV/XZnNEG114q9+BSfWKOvBSPgpzMAtWUeQxT/EBeVaugWpwrE82Z lXI0R9IgaA4dBWLlCTtZMtdAedSEtIihP9K/b4UJfixGUh92ljdegK965FuNuuDkGmE2 hRbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682350039; x=1684942039; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xSalvfnQsVLK8I+FBXVViucc3wM/l9KF4EOKeg2PWAM=; b=c5XAjldLgBhXGSzd6aGloFg9O2r2bd4P81HW8MU7dmbcoQwc9tF+AsBbyitGs+kPWt gmzWADpTWyryBx/vZxU5QxLX4LhRKN1aYLpsXwfDsWy1oSQNUcYaAzgM74IoNI7v+nh/ dWu2yndaVG9Ub8D4E4qcGKmPw3Dmw1rby5oymaK1nKWDFhPQb3IfUlmm7Rm8dk/V2WoY NnIWQRtCEWh8G9Xy5eA1e8EP5gRfGUfS8ZghrJZo6PK5Wg3AWRlXVRapbzjhgNqlIzHB Qo+abU5uyUA7ejeXEdKQoTs7tD6Yq2CQKtDM4RUY+oMukAD7SPg0YiWqtGUe+gyh/18Z tlhw== X-Gm-Message-State: AAQBX9cMc+Pyo74Ko8cPIOm0GI2z3Gdv8TUHXEHaTLE/6arRY6gk5aNi 35/GLzvq4tanOh+md68H/mD20A== X-Received: by 2002:adf:fdd1:0:b0:2fb:ca40:e433 with SMTP id i17-20020adffdd1000000b002fbca40e433mr9340408wrs.35.1682350039207; Mon, 24 Apr 2023 08:27:19 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id b1-20020a5d45c1000000b002fdeafcb132sm10971517wrs.107.2023.04.24.08.27.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Apr 2023 08:27:18 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Andrew Jeffery , Joel Stanley , =?utf-8?q?C=C3=A9dric_Le_Goater?= Subject: [PATCH 0/3] hw/arm: Fix raspi, aspeed bootloaders on big-endian hosts Date: Mon, 24 Apr 2023 16:27:14 +0100 Message-Id: <20230424152717.1333930-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Both the raspi and aspeed boards load their secondary CPU bootloader code in a way that only works on little-endian hosts. This patchset fixes that by making them both use the write_bootloader() function in boot.c, which gets endianness-handling right. Patches 1 and 2 are essentially a patch from Cédric from a few months ago: https://patchew.org/QEMU/20230119123449.531826-1-clg@kaod.org/20230119123449.531826-9-clg@kaod.org/ I've split it into two patches and tweaked it a bit. These fixes let us run the avocado tests for these boards on big-endian hosts. thanks -- PMM Cédric Le Goater (2): hw/arm/boot: Make write_bootloader() public as arm_write_bootloader() hw/arm/aspeed: Use arm_write_bootloader() to write the bootloader Peter Maydell (1): hw/arm/raspi: Use arm_write_bootloader() to write boot code include/hw/arm/boot.h | 49 +++++++++++++++++++++++++++++++++ hw/arm/aspeed.c | 38 +++++++++++++------------ hw/arm/boot.c | 35 ++++++----------------- hw/arm/raspi.c | 64 +++++++++++++++++++++++-------------------- 4 files changed, 111 insertions(+), 75 deletions(-) Tested-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé