From patchwork Tue Mar 28 16:02:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 667862 Delivered-To: patch@linaro.org Received: by 2002:a5d:4d08:0:0:0:0:0 with SMTP id z8csp1743083wrt; Tue, 28 Mar 2023 09:03:21 -0700 (PDT) X-Google-Smtp-Source: AK7set8USR/8KAytVm8Rb5d/RLAtbW3HFTwnD/7SexurKM7KNFIvFNqR+XYLbbonXhGpMmHqhBpo X-Received: by 2002:ac8:5cc3:0:b0:3e4:488c:9325 with SMTP id s3-20020ac85cc3000000b003e4488c9325mr29046064qta.15.1680019401076; Tue, 28 Mar 2023 09:03:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680019401; cv=none; d=google.com; s=arc-20160816; b=tPNelDXmIKIjrr0wjg8xr7QVDPhK7y9DL01gXl0Vo13/rX+gTZ00ax0PyYFtGcjkwa FBpaQFrB+rm/79Eiv3jCRcGqMgAI9noh+2M5lichUtMd/7OGclS/5WZfr5yqeHGIPrUs Oq4V2lJpkaiOz6mb0k7K3iIDldSCCEt7FpIMpx3WOhvkmV4CQHQKSa7zbh6O+jIGLd6V bGEDCZF5q++NR/TLVtma+mDx9G2YXOPMhOBy7IyFfk7GpvNKXlwzwyGs3WgEq7T2LL89 fNdPQEwOy7YN4mlTi94urPFKs4YHzO7YHRVUfNw1pJKzeiAbdaZarZ8otlVWxUBV/n2+ TFKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=NmsSjup+xEQ0gc2TIeG2hC6j/mKEA8p4JNIyDCKCDnk=; b=ReghgyBawETQ91i95cyvddMJnmLmBev5yq/VLvtpocDHEYALneDlLYhR8KLDhTKMUt yguUj3yz13bHWMru+p+nCMqSQcPmiubfgKEimDKgLfycOSrfwgJq6mIhVT/fPKYcHfBL E0BBxf8GyEzc7wtdGUobE6ltpq6bgCaMFYkWyGCDXinG0CvzIPHcdly86kHkFcaQDpkg 8RYbNVUBLJcfTzD0D0iG1Bq0LzHt9o90ubvqTtuxR4xwwS1bHuHBF3LI/m1Tqg5cm+W4 /MaAuiwqlIE0d2bXnwIoFPpWKdz9E/PiSmdlOqWa0p0Y2v7eCQFOAadjDAdlL8dL7nsT FXDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TXS+Ym0G; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id b20-20020ac85bd4000000b003e4e4aab0a8si4910669qtb.285.2023.03.28.09.03.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Mar 2023 09:03:21 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TXS+Ym0G; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1phBm7-00084X-Qf; Tue, 28 Mar 2023 12:02:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phBm5-000802-Qh for qemu-devel@nongnu.org; Tue, 28 Mar 2023 12:02:17 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1phBly-0004C9-CE for qemu-devel@nongnu.org; Tue, 28 Mar 2023 12:02:17 -0400 Received: by mail-wm1-x32d.google.com with SMTP id bg13-20020a05600c3c8d00b003ef90adc168so96378wmb.5 for ; Tue, 28 Mar 2023 09:02:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680019327; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=NmsSjup+xEQ0gc2TIeG2hC6j/mKEA8p4JNIyDCKCDnk=; b=TXS+Ym0GCybLQ+ER+7Oa64F9rrGVRrgJJHHwtCwuS35WZ4qfoTxmWr9K11Xw/xLIvC HyxDht7nCxqWeRQn1c1jnzfl4FIZs5Ue0uZY5GHM0kvyX4ai9P/BjvtiQVoHf+gEuaS+ vffYGdeuaiGR7ecdBjMu0x0rXTwgv3MukciKmf7Ne52JOIHM8mNxZIDRZ7Gh8ZYeQcWO lzeM6dSuSYR1E02pRPkzet5emj1HYJk5xqrlMEhfihx2P1itD0KWD1HlqqDIeVUoMkhE pOhST29TgROk1lCDEy6wQ5b9G2A5T/uG2wGWxO/ZDPuPfSBsc7NugKZoE1BAtT8x9K/s IXYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680019327; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NmsSjup+xEQ0gc2TIeG2hC6j/mKEA8p4JNIyDCKCDnk=; b=wyHdyvVwtlYNvH9j5sU3vKoFnb4CWg50MYX1HuKEhkjX/JbbhKOYB23Hv6/nzEj49c W+hDvWxteom97LZMDeA2Ul+KBpE0veZg16VBp6sDRszmzEt8LthJMRPrLyt8v9NFDfjf 4/gP97ZuacCB2iDFT8eHgZPkDeprdHloNnf2vKF9VHY4MbFu71WQJKWWUn6RMEcY1ocX BbJCk+qxY8bmncZvZlzJ2N6zty5Tz8Qd4wVe8FrXqn0TIjRKjAqyPLA6lw+OmIeRWPrC j9E5jGFoV/1UKwx/zzfXCrEWedz9GJa4cbp6sejMgcA2cod2oB4h741l9FOwYIok9H9C 4hbA== X-Gm-Message-State: AO0yUKVdztvLwIQZmO8QavMnY6YVHXxgL2cK4FRcSwfiW7L4w6Dwie8K 01SEdtkIGwVljvP4smel+ETLrLKoE2krLG7hymE= X-Received: by 2002:a7b:ce08:0:b0:3ee:da1:135f with SMTP id m8-20020a7bce08000000b003ee0da1135fmr12778012wmc.7.1680019327311; Tue, 28 Mar 2023 09:02:07 -0700 (PDT) Received: from localhost.localdomain ([176.187.210.212]) by smtp.gmail.com with ESMTPSA id hg13-20020a05600c538d00b003ed793d9de0sm2937626wmb.1.2023.03.28.09.02.05 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 28 Mar 2023 09:02:06 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Eduardo Habkost , kvm@vger.kernel.org, qemu-s390x@nongnu.org, Fabiano Rosas , David Hildenbrand , Marcel Apfelbaum , Paolo Bonzini , Greg Kurz , Christian Borntraeger , Thomas Huth , Peter Maydell , Richard Henderson , Ilya Leoshkevich , Halil Pasic , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Daniel Henrique Barboza , David Gibson , Yanan Wang , qemu-ppc@nongnu.org, =?utf-8?q?Alex_Be?= =?utf-8?q?nn=C3=A9e?= , qemu-arm@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH-for-8.0 0/3] softmmu: Restore use of CPU watchpoint for non-TCG accelerators Date: Tue, 28 Mar 2023 18:02:00 +0200 Message-Id: <20230328160203.13510-1-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Commit 2609ec2868 ("softmmu: Extract watchpoint API from physmem.c") restricted CPU watchpoints to TCG accelerator. This is wrong, as other accelerators such KVM do use watchpoints. Revert (partially) this commit. https://lore.kernel.org/qemu-devel/4784948c-1a92-1991-d6a2-b4d1ee23136c@redhat.com/ Philippe Mathieu-Daudé (3): softmmu/watchpoint: Add missing 'qemu/error-report.h' include softmmu: Restrict cpu_check_watchpoint / address_matches to TCG accel softmmu: Restore use of CPU watchpoint for all accelerators include/hw/core/cpu.h | 39 +------------------------------ include/hw/core/tcg-cpu-ops.h | 43 +++++++++++++++++++++++++++++++++++ softmmu/watchpoint.c | 5 ++++ softmmu/meson.build | 2 +- 4 files changed, 50 insertions(+), 39 deletions(-)