From patchwork Thu Mar 2 22:40:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 658164 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp145240wrb; Thu, 2 Mar 2023 14:43:06 -0800 (PST) X-Google-Smtp-Source: AK7set8RYFpmOy82nSYgQOpz3m0KPtIm7y1G4fN1va5xFQXYHExfwMvxA0o6rKbs2X6HyZsxmsBe X-Received: by 2002:ad4:5ba7:0:b0:537:6416:fc2b with SMTP id 7-20020ad45ba7000000b005376416fc2bmr20271246qvq.52.1677796986622; Thu, 02 Mar 2023 14:43:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677796986; cv=none; d=google.com; s=arc-20160816; b=l0Cq9eUHJ/gyjOXhKeWSL/miYtkMy6iOaX2fFnQNKyNzFZyzgFV3txgBuQamNullNZ ET0alSbijDm7uYa+2lsFYycvS/VaCXbYKqc+kuaf/5cN0vmwSKfBpydqeCa9tZ35Bq2r k0q0vTWMA6NydX2rxP3p4n6LkkaBQAz5A97g2Q6aeJNjn0QtoJMMl6aYxht32Hj23PkD 990/4mlSGXX6ZAxFBhQCYz15deX1iV8/rfZMonrnqmApjXLqHUOI7aNEI1NYL1SUsayk 8bOfUjxJtGHWp8z03+5sXlMT/IC1MxnU1ILtPgT2qw1TuTg/bxNdl+9gmvt4ki5HG5Yw AqWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=2Vg5Dt0fxYxqjbPBqU25BqgXLbiKq4Pw5rFRUK025+c=; b=hfavw5Em4DivDtj8nYTmZVBmqBiDhvgCOsNpCc1W711m4dkE+AOrfJ6/NVOpGPoHcu DgQsH+gA2nVYNguL/fhcWOnU7C9TPRpHPASPSHN/aHz/LZf75SznWLFSR7DGEtNVpm74 Z9vdE09vy6+1HIx/Z8F1YrdLRH3GeT2xH9ECxKuTZA0TK4f6U9DYatGVJEwnnj51Dwnq Z/Hmqpqiu+4Rf0UoB3H3Zr3Y1/n2R4tdZNPFWdmEFjSEcqAITDUG9D2mk4d9DuvMwzJZ APmteAImKZVrXzK9N0dtb3p20omt+rmr3cov3Kf6GYrtNYUMgTHtF2SWarfW19GG/nyH ftdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=daCSfWH2; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u13-20020a0cdd0d000000b0056eddf64fc5si258113qvk.591.2023.03.02.14.43.06 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Mar 2023 14:43:06 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=daCSfWH2; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXrbs-0006x8-KF; Thu, 02 Mar 2023 17:41:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXrbp-0006wO-NM for qemu-devel@nongnu.org; Thu, 02 Mar 2023 17:41:09 -0500 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pXrbn-0008Ml-1t for qemu-devel@nongnu.org; Thu, 02 Mar 2023 17:41:09 -0500 Received: by mail-wm1-x32c.google.com with SMTP id t25-20020a1c7719000000b003eb052cc5ccso2819319wmi.4 for ; Thu, 02 Mar 2023 14:41:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1677796863; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=2Vg5Dt0fxYxqjbPBqU25BqgXLbiKq4Pw5rFRUK025+c=; b=daCSfWH2+pzs+wZrPhRk1lsT4C3YwUXmmdqfRAqx3SIDL8BVC1aiXQQfi3jqyrHGgc 3Ve8vDfh8fgj4IQ3zgFmT809MPWVeZFZVwobNcjfz0WyAKDEqCSGasLE/2rFA1JCeV/F KtJDULD/Bogt6/OZYJ817KPy50dAmAZnyzj9fGu+wBJJ1slFz0hxak5GT20gZJePE0n/ WcEFREho/lhGVCwJOCdD4c/vEILfvVlcXkG90TSjeT/8zqldnKOEeyKCJPbmN8CgqzZb upN8rapKfU8BEFhGC/HLni6TG/jvN8HXbQFS4X4ZAtaBTyb71G/GOp6uh7ab15pHBACj KQCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677796863; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2Vg5Dt0fxYxqjbPBqU25BqgXLbiKq4Pw5rFRUK025+c=; b=e9bq8nAeSTbWj6Ect3wB6aEOHPjNTgeMMwkoo3R8e/RUtgGaV9F6D93p+mWSqnP5y2 3M6r4ucIUc1nPV/u/Cyd9ByGlCkskSQbfViwOsbiuxitE6PUPxN+L5ZgBSx2Hr3lRwpG 7ifYRyPM9N60dvDmXvNEO+2QN0INmc/vk1GzgjfB2Zp8gugfYcYWKOljeu/wYI4XgPUT CyMM1BOVyz3+ihn2tiArCF9W0DFaGbjNu2TU6XM3APZPR3BHV9Kod3r3YZCdQlaOzIhq 3p7VBIqHGjb5OWqOf3Rf04jrrJJPj0e/x3jvQLRXFQX5T7TNS2WzHP5/Uryz73inBxO1 rXUw== X-Gm-Message-State: AO0yUKWkTWMqW+Nk/suDeDCyrdE4BzOgEvGfPCU+apF9BtlV4P+L/0GA arUTCI+PhioaJcsDGHunnXUqxeh+y0K6zk5h X-Received: by 2002:a05:600c:2215:b0:3e2:1368:e3a0 with SMTP id z21-20020a05600c221500b003e21368e3a0mr8440459wml.18.1677796863306; Thu, 02 Mar 2023 14:41:03 -0800 (PST) Received: from localhost.localdomain (43.red-95-127-39.staticip.rima-tde.net. [95.127.39.43]) by smtp.gmail.com with ESMTPSA id x8-20020a1c7c08000000b003eb2e33f327sm7211935wmc.2.2023.03.02.14.41.01 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 02 Mar 2023 14:41:02 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Bernhard Beschow Cc: John Snow , David Woodhouse , BALATON Zoltan , =?utf-8?q?Herv=C3=A9_Poussineau?= , qemu-ppc@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v3 00/18] hw/ide: Untangle ISA/PCI abuses of ide_init_ioport() Date: Thu, 2 Mar 2023 23:40:40 +0100 Message-Id: <20230302224058.43315-1-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Since v2: rebased I'm posting this series as it to not block Bernhard's PIIX cleanup work. I don't have code change planned, but eventually reword / improve commit descriptions. Tested commit after commit to be sure it is bisectable. Sadly this was before Zoltan & Thomas report a problem with commit bb98e0f59c ("hw/isa/vt82c686: Remove intermediate IRQ forwarder"). Background thread: https://lore.kernel.org/qemu-devel/5095dffc-309b-6c72-d255-8cdaa6fd3d52@ilande.co.uk/ Philippe Mathieu-Daudé (18): hw/ide/piix: Expose output IRQ as properties for late object population hw/ide/piix: Allow using PIIX3-IDE as standalone PCI function hw/i386/pc_piix: Wire PIIX3 IDE ouput IRQs to ISA bus IRQs 14/15 hw/isa/piix4: Wire PIIX4 IDE ouput IRQs to ISA bus IRQs 14/15 hw/ide: Rename ISA specific ide_init_ioport -> ide_bus_init_ioport_isa hw/ide/piix: Ensure IDE output IRQs are wired at realization hw/isa: Deprecate isa_get_irq() in favor of isa_bus_get_irq() hw/ide: Introduce generic ide_init_ioport() hw/ide/piix: Use generic ide_bus_init_ioport() hw/isa: Ensure isa_register_portio_list() do not get NULL ISA device hw/isa: Simplify isa_address_space[_io]() hw/isa: Reduce 'isabus' singleton scope to isa_bus_new() exec/ioport: Factor portio_list_register_flush_coalesced() out exec/ioport: Factor portio_list_register() out hw/southbridge/piix: Use OBJECT_DECLARE_SIMPLE_TYPE() macro hw/isa/piix: Batch register QOM types using DEFINE_TYPES() macro hw/isa/piix: Unify QOM type name of PIIX ISA function hw/isa/piix: Unify PIIX-ISA QOM type names using qdev aliases hw/audio/adlib.c | 4 +-- hw/display/qxl.c | 7 ++-- hw/display/vga.c | 9 +++-- hw/dma/i82374.c | 7 ++-- hw/i386/pc_piix.c | 13 +++++--- hw/ide/ioport.c | 15 +++++++-- hw/ide/isa.c | 2 +- hw/ide/piix.c | 54 +++++++++++++++++++++++------- hw/isa/isa-bus.c | 36 ++++++++------------ hw/isa/piix3.c | 63 +++++++++++++++-------------------- hw/isa/piix4.c | 12 ++++--- hw/mips/malta.c | 2 +- hw/watchdog/wdt_ib700.c | 4 +-- include/exec/ioport.h | 15 +++++---- include/hw/ide/internal.h | 3 +- include/hw/ide/isa.h | 3 ++ include/hw/ide/piix.h | 4 +++ include/hw/isa/isa.h | 3 +- include/hw/southbridge/piix.h | 14 ++++---- softmmu/ioport.c | 48 +++++++++++++++++++------- softmmu/qdev-monitor.c | 3 ++ 21 files changed, 190 insertions(+), 131 deletions(-) Acked-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin