mbox series

[0/2] target/s390x: s390_probe_access fixes

Message ID 20220823213805.1970804-1-richard.henderson@linaro.org
Headers show
Series target/s390x: s390_probe_access fixes | expand

Message

Richard Henderson Aug. 23, 2022, 9:38 p.m. UTC 
First, as pointed out by David; second by inspection.

I really wish there were a better way to structure this,
but alas, I don't see any alternatives that aren't just
different but similar amounts of ugly.


r~


Richard Henderson (2):
  Revert "target/s390x: Use probe_access_flags in s390_probe_access"
  target/s390x: Align __excp_addr in s390_probe_access

 target/s390x/tcg/mem_helper.c | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

Comments

David Hildenbrand Aug. 24, 2022, 7:33 a.m. UTC | #1 
On 23.08.22 23:38, Richard Henderson wrote:
> First, as pointed out by David; second by inspection.
> 
> I really wish there were a better way to structure this,
> but alas, I don't see any alternatives that aren't just
> different but similar amounts of ugly.
> 

The only feasible way would be having a arch-specific callback from
inside the probe code that would, similarly to tlb_fill code for !USER
store these values in the cpu environment -- then we could similarly
just look them up after the probe access.