Message ID | 20210512102051.12134-1-alex.bennee@linaro.org |
---|---|
Headers | show |
Series | testing/next pre-PR (hexagon, tricore, misc) | expand |
Patchew URL: https://patchew.org/QEMU/20210512102051.12134-1-alex.bennee@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210512102051.12134-1-alex.bennee@linaro.org Subject: [PATCH v3 00/31] testing/next pre-PR (hexagon, tricore, misc) === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210512102051.12134-1-alex.bennee@linaro.org -> patchew/20210512102051.12134-1-alex.bennee@linaro.org Switched to a new branch 'test' e7bd49f configure: use cc, not host_cc to set cross_cc for build arch 3dcf3cf tests/tcg: don't allow clang as a cross compiler ee9ba65 tests/tcg: fix missing return b860a57 cirrus.yml: Fix the MSYS2 task a7a5e80 tests/tcg/ppc64le: tests for brh/brw/brd 60d3f4f tests/docker: gcc-10 based images for ppc64{, le} tests 0b2b9cb tests/tcg/tricore: Add muls test 0b649c6 tests/tcg/tricore: Add msub test 45acb9d tests/tcg/tricore: Add madd test 114aa34 tests/tcg/tricore: Add ftoi test e08fcae tests/tcg/tricore: Add fmul test a096072 tests/tcg/tricore: Add fadd test d580c2d tests/tcg/tricore: Add dvstep test 369ed0a tests/tcg/tricore: Add clz test cfd2a18 tests/tcg/tricore: Add bmerge test 108adc7 tests/tcg/tricore: Add macros to create tests and first test 'abs' cb4437e configure: Emit HOST_CC to config-host.mak b03652f tests/tcg/tricore: Add build infrastructure 29e8ff9 hw/tricore: Add testdevice for tests in tests/tcg/ b23c92a tests/tcg: Run timeout cmds using --foreground 8d98a61 tests/tcg: Add docker_as and docker_ld cmds 0b0afe40 tests/docker: Added libbpf library to the docker files. 5f09853 tests/tcg: don't iterate through other arch compilers 5a780e7 gitlab: add build-user-hexagon test b386bd2 tests/tcg: Use Hexagon Docker image 350135e docker: Add Hexagon image 22642bb tests/docker: add "fetch" sub-command f3c5046 tests/docker: allow "update" to add the current user 8ec0745 tests/docker: make executable an optional argument to "update" 01c0c12 tests/docker: fix copying of executable in "update" ca48f01 checkpatch: Fix use of uninitialized value === OUTPUT BEGIN === 1/31 Checking commit ca48f0165862 (checkpatch: Fix use of uninitialized value) 2/31 Checking commit 01c0c129fccb (tests/docker: fix copying of executable in "update") 3/31 Checking commit 8ec0745f8035 (tests/docker: make executable an optional argument to "update") 4/31 Checking commit f3c504680bcf (tests/docker: allow "update" to add the current user) 5/31 Checking commit 22642bb42b61 (tests/docker: add "fetch" sub-command) 6/31 Checking commit 350135e182b4 (docker: Add Hexagon image) WARNING: line over 80 characters #206: FILE: tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:63: + -DCMAKE_ASM_FLAGS="-G0 -mlong-calls -fno-pic --target=hexagon-unknown-linux-musl " \ ERROR: line over 90 characters #233: FILE: tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:90: + CROSS_CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math --target=hexagon-unknown-linux-musl" \ ERROR: line over 90 characters #270: FILE: tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:127: + CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math --target=hexagon-unknown-linux-musl" \ total: 2 errors, 1 warnings, 222 lines checked Patch 6/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/31 Checking commit b386bd284d74 (tests/tcg: Use Hexagon Docker image) 8/31 Checking commit 5a780e77a09c (gitlab: add build-user-hexagon test) 9/31 Checking commit 5f098530f1c8 (tests/tcg: don't iterate through other arch compilers) 10/31 Checking commit 0b0afe40a65b (tests/docker: Added libbpf library to the docker files.) 11/31 Checking commit 8d98a6130d5d (tests/tcg: Add docker_as and docker_ld cmds) 12/31 Checking commit b23c92afecd8 (tests/tcg: Run timeout cmds using --foreground) 13/31 Checking commit 29e8ff9ac6f1 (hw/tricore: Add testdevice for tests in tests/tcg/) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #68: new file mode 100644 total: 0 errors, 1 warnings, 152 lines checked Patch 13/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/31 Checking commit b03652f669a8 (tests/tcg/tricore: Add build infrastructure) 15/31 Checking commit cb4437e73344 (configure: Emit HOST_CC to config-host.mak) 16/31 Checking commit 108adc7d03ee (tests/tcg/tricore: Add macros to create tests and first test 'abs') WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #61: new file mode 100644 ERROR: Macros with multiple statements should be enclosed in a do - while loop #67: FILE: tests/tcg/tricore/macros.h:2: +#define LI(reg, val) \ + mov.u reg, lo:val; \ + movh DREG_TEMP_LI, up:val; \ + or reg, reg, DREG_TEMP_LI; \ + ERROR: spaces required around that ':' (ctx:VxV) #68: FILE: tests/tcg/tricore/macros.h:3: + mov.u reg, lo:val; \ ^ ERROR: spaces required around that ':' (ctx:VxV) #69: FILE: tests/tcg/tricore/macros.h:4: + movh DREG_TEMP_LI, up:val; \ ^ ERROR: spaces required around that '%' (ctx:WxV) #75: FILE: tests/tcg/tricore/macros.h:10: +#define DREG_RS1 %d0 ^ ERROR: Macros with complex values should be enclosed in parenthesis #75: FILE: tests/tcg/tricore/macros.h:10: +#define DREG_RS1 %d0 ERROR: spaces required around that '%' (ctx:WxV) #76: FILE: tests/tcg/tricore/macros.h:11: +#define DREG_CALC_RESULT %d1 ^ ERROR: Macros with complex values should be enclosed in parenthesis #76: FILE: tests/tcg/tricore/macros.h:11: +#define DREG_CALC_RESULT %d1 ERROR: spaces required around that '%' (ctx:WxV) #77: FILE: tests/tcg/tricore/macros.h:12: +#define DREG_TEMP_LI %d10 ^ ERROR: Macros with complex values should be enclosed in parenthesis #77: FILE: tests/tcg/tricore/macros.h:12: +#define DREG_TEMP_LI %d10 ERROR: spaces required around that '%' (ctx:WxV) #78: FILE: tests/tcg/tricore/macros.h:13: +#define DREG_TEMP %d11 ^ ERROR: Macros with complex values should be enclosed in parenthesis #78: FILE: tests/tcg/tricore/macros.h:13: +#define DREG_TEMP %d11 ERROR: spaces required around that '%' (ctx:WxV) #79: FILE: tests/tcg/tricore/macros.h:14: +#define DREG_TEST_NUM %d14 ^ ERROR: Macros with complex values should be enclosed in parenthesis #79: FILE: tests/tcg/tricore/macros.h:14: +#define DREG_TEST_NUM %d14 ERROR: spaces required around that '%' (ctx:WxV) #80: FILE: tests/tcg/tricore/macros.h:15: +#define DREG_CORRECT_RESULT %d15 ^ ERROR: Macros with complex values should be enclosed in parenthesis #80: FILE: tests/tcg/tricore/macros.h:15: +#define DREG_CORRECT_RESULT %d15 ERROR: spaces required around that '%' (ctx:WxV) #82: FILE: tests/tcg/tricore/macros.h:17: +#define DREG_DEV_ADDR %a15 ^ ERROR: Macros with complex values should be enclosed in parenthesis #82: FILE: tests/tcg/tricore/macros.h:17: +#define DREG_DEV_ADDR %a15 ERROR: Macros with multiple statements should be enclosed in a do - while loop #85: FILE: tests/tcg/tricore/macros.h:20: +#define TEST_CASE(num, testreg, correct, code...) \ +test_ ## num: \ + code; \ + LI(DREG_CORRECT_RESULT, correct) \ + mov DREG_TEST_NUM, num; \ + jne testreg, DREG_CORRECT_RESULT, fail \ + ERROR: spaces required around that ':' (ctx:VxE) #86: FILE: tests/tcg/tricore/macros.h:21: +test_ ## num: \ ^ WARNING: Block comments use a leading /* on a separate line #92: FILE: tests/tcg/tricore/macros.h:27: +/* Actual test case type ERROR: Macros with multiple statements should be enclosed in a do - while loop #104: FILE: tests/tcg/tricore/macros.h:39: +#define TEST_PASSFAIL \ + j pass; \ +fail: \ + LI(DREG_TEMP, TESTDEV_ADDR) \ + mov.a DREG_DEV_ADDR, DREG_TEMP; \ + st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\ + debug; \ + j fail; \ +pass: \ + LI(DREG_TEMP, TESTDEV_ADDR) \ + mov.a DREG_DEV_ADDR, DREG_TEMP; \ + mov DREG_TEST_NUM, 0; \ + st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\ + debug; \ + j pass; ERROR: space prohibited before open square bracket '[' #109: FILE: tests/tcg/tricore/macros.h:44: + st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\ ERROR: space prohibited before open square bracket '[' #116: FILE: tests/tcg/tricore/macros.h:51: + st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\ total: 22 errors, 2 warnings, 80 lines checked Patch 16/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/31 Checking commit cfd2a1864f8c (tests/tcg/tricore: Add bmerge test) ERROR: spaces required around that '%' (ctx:WxV) #38: FILE: tests/tcg/tricore/macros.h:11: +#define DREG_RS2 %d1 ^ ERROR: Macros with complex values should be enclosed in parenthesis #38: FILE: tests/tcg/tricore/macros.h:11: +#define DREG_RS2 %d1 ERROR: spaces required around that '%' (ctx:WxV) #40: FILE: tests/tcg/tricore/macros.h:13: +#define DREG_CALC_PSW %d2 ^ ERROR: Macros with complex values should be enclosed in parenthesis #40: FILE: tests/tcg/tricore/macros.h:13: +#define DREG_CALC_PSW %d2 ERROR: spaces required around that '%' (ctx:WxV) #41: FILE: tests/tcg/tricore/macros.h:14: +#define DREG_CORRECT_PSW %d3 ^ ERROR: Macros with complex values should be enclosed in parenthesis #41: FILE: tests/tcg/tricore/macros.h:14: +#define DREG_CORRECT_PSW %d3 ERROR: spaces required around that ':' (ctx:VxE) #50: FILE: tests/tcg/tricore/macros.h:31: +test_ ## num: \ ^ WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #81: new file mode 100644 total: 7 errors, 1 warnings, 58 lines checked Patch 17/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/31 Checking commit 369ed0a5553d (tests/tcg/tricore: Add clz test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 total: 0 errors, 1 warnings, 16 lines checked Patch 18/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/31 Checking commit d580c2db2b76 (tests/tcg/tricore: Add dvstep test) ERROR: spaces required around that '%' (ctx:WxV) #38: FILE: tests/tcg/tricore/macros.h:22: +#define EREG_RS1 %e6 ^ ERROR: Macros with complex values should be enclosed in parenthesis #38: FILE: tests/tcg/tricore/macros.h:22: +#define EREG_RS1 %e6 ERROR: spaces required around that '%' (ctx:WxV) #39: FILE: tests/tcg/tricore/macros.h:23: +#define EREG_RS1_LO %d6 ^ ERROR: Macros with complex values should be enclosed in parenthesis #39: FILE: tests/tcg/tricore/macros.h:23: +#define EREG_RS1_LO %d6 ERROR: spaces required around that '%' (ctx:WxV) #40: FILE: tests/tcg/tricore/macros.h:24: +#define EREG_RS1_HI %d7 ^ ERROR: Macros with complex values should be enclosed in parenthesis #40: FILE: tests/tcg/tricore/macros.h:24: +#define EREG_RS1_HI %d7 ERROR: spaces required around that '%' (ctx:WxV) #41: FILE: tests/tcg/tricore/macros.h:25: +#define EREG_RS2 %e8 ^ ERROR: Macros with complex values should be enclosed in parenthesis #41: FILE: tests/tcg/tricore/macros.h:25: +#define EREG_RS2 %e8 ERROR: spaces required around that '%' (ctx:WxV) #42: FILE: tests/tcg/tricore/macros.h:26: +#define EREG_RS2_LO %d8 ^ ERROR: Macros with complex values should be enclosed in parenthesis #42: FILE: tests/tcg/tricore/macros.h:26: +#define EREG_RS2_LO %d8 ERROR: spaces required around that '%' (ctx:WxV) #43: FILE: tests/tcg/tricore/macros.h:27: +#define EREG_RS2_HI %d9 ^ ERROR: Macros with complex values should be enclosed in parenthesis #43: FILE: tests/tcg/tricore/macros.h:27: +#define EREG_RS2_HI %d9 ERROR: spaces required around that '%' (ctx:WxV) #44: FILE: tests/tcg/tricore/macros.h:28: +#define EREG_CALC_RESULT %e8 ^ ERROR: Macros with complex values should be enclosed in parenthesis #44: FILE: tests/tcg/tricore/macros.h:28: +#define EREG_CALC_RESULT %e8 ERROR: spaces required around that '%' (ctx:WxV) #45: FILE: tests/tcg/tricore/macros.h:29: +#define EREG_CALC_RESULT_HI %d9 ^ ERROR: Macros with complex values should be enclosed in parenthesis #45: FILE: tests/tcg/tricore/macros.h:29: +#define EREG_CALC_RESULT_HI %d9 ERROR: spaces required around that '%' (ctx:WxV) #46: FILE: tests/tcg/tricore/macros.h:30: +#define EREG_CALC_RESULT_LO %d8 ^ ERROR: Macros with complex values should be enclosed in parenthesis #46: FILE: tests/tcg/tricore/macros.h:30: +#define EREG_CALC_RESULT_LO %d8 ERROR: spaces required around that '%' (ctx:WxV) #47: FILE: tests/tcg/tricore/macros.h:31: +#define EREG_CORRECT_RESULT_LO %d0 ^ ERROR: Macros with complex values should be enclosed in parenthesis #47: FILE: tests/tcg/tricore/macros.h:31: +#define EREG_CORRECT_RESULT_LO %d0 ERROR: spaces required around that '%' (ctx:WxV) #48: FILE: tests/tcg/tricore/macros.h:32: +#define EREG_CORRECT_RESULT_HI %d1 ^ ERROR: Macros with complex values should be enclosed in parenthesis #48: FILE: tests/tcg/tricore/macros.h:32: +#define EREG_CORRECT_RESULT_HI %d1 ERROR: spaces required around that ':' (ctx:VxE) #58: FILE: tests/tcg/tricore/macros.h:43: +test_ ## num: \ ^ WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #85: new file mode 100644 total: 23 errors, 1 warnings, 69 lines checked Patch 19/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/31 Checking commit a0960727fb9c (tests/tcg/tricore: Add fadd test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #30: new file mode 100644 total: 0 errors, 1 warnings, 23 lines checked Patch 20/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/31 Checking commit e08fcae7a168 (tests/tcg/tricore: Add fmul test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #30: new file mode 100644 total: 0 errors, 1 warnings, 15 lines checked Patch 21/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/31 Checking commit 114aa340c3a0 (tests/tcg/tricore: Add ftoi test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #49: new file mode 100644 total: 0 errors, 1 warnings, 30 lines checked Patch 22/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 23/31 Checking commit 45acb9d26762 (tests/tcg/tricore: Add madd test) ERROR: spaces required around that '%' (ctx:WxV) #38: FILE: tests/tcg/tricore/macros.h:12: +#define DREG_RS3 %d4 ^ ERROR: Macros with complex values should be enclosed in parenthesis #38: FILE: tests/tcg/tricore/macros.h:12: +#define DREG_RS3 %d4 WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #67: new file mode 100644 total: 2 errors, 1 warnings, 48 lines checked Patch 23/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 24/31 Checking commit 0b649c627941 (tests/tcg/tricore: Add msub test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #30: new file mode 100644 total: 0 errors, 1 warnings, 16 lines checked Patch 24/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 25/31 Checking commit 0b2b9cb78c02 (tests/tcg/tricore: Add muls test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #30: new file mode 100644 total: 0 errors, 1 warnings, 16 lines checked Patch 25/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 26/31 Checking commit 60d3f4f92252 (tests/docker: gcc-10 based images for ppc64{, le} tests) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #83: deleted file mode 100644 total: 0 errors, 1 warnings, 96 lines checked Patch 26/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 27/31 Checking commit a7a5e8093836 (tests/tcg/ppc64le: tests for brh/brw/brd) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #66: new file mode 100644 total: 0 errors, 1 warnings, 55 lines checked Patch 27/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 28/31 Checking commit b860a576a820 (cirrus.yml: Fix the MSYS2 task) 29/31 Checking commit ee9ba6514b64 (tests/tcg: fix missing return) 30/31 Checking commit 3dcf3cf4bee6 (tests/tcg: don't allow clang as a cross compiler) WARNING: line over 80 characters #84: FILE: tests/tcg/configure.sh:236: + # For host systems we might get away with building without -static WARNING: line over 80 characters #89: FILE: tests/tcg/configure.sh:241: + echo "CROSS_CC_GUEST=$target_compiler" >> $config_target_mak total: 0 errors, 2 warnings, 67 lines checked Patch 30/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/31 Checking commit e7bd49f2df16 (configure: use cc, not host_cc to set cross_cc for build arch) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210512102051.12134-1-alex.bennee@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com