mbox series

[0/2] linux-user: sigaction fixes/cleanups

Message ID 20210422180819.252121-1-richard.henderson@linaro.org
Headers show
Series linux-user: sigaction fixes/cleanups | expand

Message

Richard Henderson April 22, 2021, 6:08 p.m. UTC 
Alpha had two bugs, one with the non-ka_restorer fallback
using the wrong offset, and the other with the ka_restorer
value getting lost in do_sigaction.

Because do_sigaction didn't see TARGET_ARCH_HAS_SA_RESTORER
(which is correct for alpha, as the field isn't present in
the structure), we didn't copy the field into our syscall
table.  Which meant that the extra code present in do_syscall
to stash the ka_restorer value was wasted.

I believe that Sparc has a similar bug, but this one was
worse because it was modifying the user's sigaction struct
that was passed in.


r~


Richard Henderson (2):
  linux-user/alpha: Fix rt sigframe return
  linux-user: Clean up sigaction ka_restorer

 linux-user/syscall_defs.h | 17 +++-----
 linux-user/alpha/signal.c | 10 ++---
 linux-user/signal.c       |  4 +-
 linux-user/syscall.c      | 90 ++++++++++++---------------------------
 4 files changed, 42 insertions(+), 79 deletions(-)

-- 
2.25.1

Comments

no-reply@patchew.org April 22, 2021, 6:18 p.m. UTC | #1 
Patchew URL: https://patchew.org/QEMU/20210422180819.252121-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210422180819.252121-1-richard.henderson@linaro.org
Subject: [PATCH 0/2] linux-user: sigaction fixes/cleanups

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210422154427.13038-1-alex.bennee@linaro.org -> patchew/20210422154427.13038-1-alex.bennee@linaro.org
 * [new tag]         patchew/20210422180819.252121-1-richard.henderson@linaro.org -> patchew/20210422180819.252121-1-richard.henderson@linaro.org
Switched to a new branch 'test'
0bea0eb linux-user: Clean up sigaction ka_restorer
edde716 linux-user/alpha: Fix rt sigframe return

=== OUTPUT BEGIN ===
1/2 Checking commit edde716f548d (linux-user/alpha: Fix rt sigframe return)
2/2 Checking commit 0bea0eb16300 (linux-user: Clean up sigaction ka_restorer)
ERROR: code indent should never use tabs
#107: FILE: linux-user/syscall.c:9021:
+^I    ret = get_errno(do_sigaction(arg1, pact, &oact, 0));$

ERROR: space prohibited between function name and open parenthesis '('
#173: FILE: linux-user/syscall.c:9075:
+#elif defined (TARGET_SPARC)

total: 2 errors, 0 warnings, 214 lines checked

Patch 2/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210422180819.252121-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com