| Message ID | 20210311002156.253711-1-richard.henderson@linaro.org |
|---|---|
| Headers | show |
| Series | tcg: Workaround macOS 11.2 mprotect bug | expand |
Patchew URL: https://patchew.org/QEMU/20210311002156.253711-1-richard.henderson@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210311002156.253711-1-richard.henderson@linaro.org Subject: [PATCH 00/26] tcg: Workaround macOS 11.2 mprotect bug === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210311002156.253711-1-richard.henderson@linaro.org -> patchew/20210311002156.253711-1-richard.henderson@linaro.org Switched to a new branch 'test' 6270444 tcg: When allocating for !splitwx, begin with PROT_NONE 20dd554 tcg: Merge buffer protection and guard page protection 996417b util/osdep: Add qemu_mprotect_rw f390fd1 tcg: Do not set guard pages in the rx buffer cec5119 tcg: Sink qemu_madvise call to common code ef8fa42 tcg: Return the map protection from alloc_code_gen_buffer 3c9cf4e tcg: Allocate code_gen_buffer into struct tcg_region_state 1d71ed2 tcg: Tidy split_cross_256mb f288a3a tcg: Tidy tcg_n_regions af5f973 tcg: Replace region.end with region.total_size 436e7dd tcg: Move MAX_CODE_GEN_BUFFER_SIZE to tcg-target.h 9d9a3a8 tcg: Introduce tcg_max_ctxs c907f41 accel/tcg: Pass down max_cpus to tcg_init cadcc5d accel/tcg: Merge tcg_exec_init into tcg_init_machine 39b8dcc tcg: Create tcg_init f194472 accel/tcg: Rename tcg_init to tcg_init_machine 752c003 accel/tcg: Move alloc_code_gen_buffer to tcg/region.c 88e88ed accel/tcg: Inline cpu_gen_init 68c020a tcg: Split out region.c f2468f3 tcg: Split out tcg_region_prologue_set 9260a2b tcg: Split out tcg_region_initial_alloc d3885f1 tcg: Remove error return from tcg_region_initial_alloc__locked 39905cc tcg: Re-order tcg_region_init vs tcg_prologue_init 56a4e11 meson: Split out fpu/meson.build bc597a2 meson: Move disas/tci.c to disas/meson.build 90e5198 meson: Split out tcg/meson.build === OUTPUT BEGIN === 1/26 Checking commit 90e51984ec1e (meson: Split out tcg/meson.build) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 35 lines checked Patch 1/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/26 Checking commit bc597a225ec0 (meson: Move disas/tci.c to disas/meson.build) 3/26 Checking commit 56a4e116d3ed (meson: Split out fpu/meson.build) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 total: 0 errors, 1 warnings, 17 lines checked Patch 3/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/26 Checking commit 39905cc9e118 (tcg: Re-order tcg_region_init vs tcg_prologue_init) 5/26 Checking commit d3885f17f769 (tcg: Remove error return from tcg_region_initial_alloc__locked) 6/26 Checking commit 9260a2be69f4 (tcg: Split out tcg_region_initial_alloc) 7/26 Checking commit f2468f31fb8e (tcg: Split out tcg_region_prologue_set) 8/26 Checking commit 68c020a8c929 (tcg: Split out region.c) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 1189 lines checked Patch 8/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/26 Checking commit 88e88ed26587 (accel/tcg: Inline cpu_gen_init) 10/26 Checking commit 752c0035d065 (accel/tcg: Move alloc_code_gen_buffer to tcg/region.c) WARNING: Block comments use a leading /* on a separate line #499: FILE: tcg/region.c:411: +/* Minimum size of the code gen buffer. This number is randomly chosen, WARNING: Block comments use * on subsequent lines #500: FILE: tcg/region.c:412: +/* Minimum size of the code gen buffer. This number is randomly chosen, + but not so small that we can't have a fair number of TB's live. */ WARNING: Block comments use a trailing */ on a separate line #500: FILE: tcg/region.c:412: + but not so small that we can't have a fair number of TB's live. */ WARNING: Block comments use a leading /* on a separate line #503: FILE: tcg/region.c:415: +/* Maximum size of the code gen buffer we'd like to use. Unless otherwise WARNING: Block comments use * on subsequent lines #504: FILE: tcg/region.c:416: +/* Maximum size of the code gen buffer we'd like to use. Unless otherwise + indicated, this is constrained by the range of direct branches on the WARNING: Block comments use a trailing */ on a separate line #505: FILE: tcg/region.c:417: + host cpu, as used by the TCG implementation of goto_tb. */ WARNING: architecture specific defines should be avoided #506: FILE: tcg/region.c:418: +#if defined(__x86_64__) WARNING: Block comments use a leading /* on a separate line #520: FILE: tcg/region.c:432: + /* We have a 256MB branch region, but leave room to make sure the WARNING: Block comments use * on subsequent lines #521: FILE: tcg/region.c:433: + /* We have a 256MB branch region, but leave room to make sure the + main executable is also within that region. */ WARNING: Block comments use a trailing */ on a separate line #521: FILE: tcg/region.c:433: + main executable is also within that region. */ WARNING: architecture specific defines should be avoided #579: FILE: tcg/region.c:491: +#ifdef __mips__ WARNING: Block comments use a leading /* on a separate line #580: FILE: tcg/region.c:492: +/* In order to use J and JAL within the code_gen_buffer, we require WARNING: Block comments use * on subsequent lines #581: FILE: tcg/region.c:493: +/* In order to use J and JAL within the code_gen_buffer, we require + that the buffer not cross a 256MB boundary. */ WARNING: Block comments use a trailing */ on a separate line #581: FILE: tcg/region.c:493: + that the buffer not cross a 256MB boundary. */ WARNING: Block comments use a leading /* on a separate line #587: FILE: tcg/region.c:499: +/* We weren't able to allocate a buffer without crossing that boundary, WARNING: Block comments use * on subsequent lines #588: FILE: tcg/region.c:500: +/* We weren't able to allocate a buffer without crossing that boundary, + so make do with the larger portion of the buffer that doesn't cross. WARNING: Block comments use a trailing */ on a separate line #589: FILE: tcg/region.c:501: + Returns the new base of the buffer, and adjusts code_gen_buffer_size. */ WARNING: architecture specific defines should be avoided #634: FILE: tcg/region.c:546: +#ifdef __mips__ WARNING: architecture specific defines should be avoided #686: FILE: tcg/region.c:598: +#ifdef __mips__ WARNING: architecture specific defines should be avoided #736: FILE: tcg/region.c:648: +#ifdef __mips__ WARNING: architecture specific defines should be avoided #753: FILE: tcg/region.c:665: +#ifdef __mips__ ERROR: externs should be avoided in .c files #795: FILE: tcg/region.c:707: +extern kern_return_t mach_vm_remap(vm_map_t target_task, total: 1 errors, 21 warnings, 895 lines checked Patch 10/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/26 Checking commit f194472e4202 (accel/tcg: Rename tcg_init to tcg_init_machine) 12/26 Checking commit 39b8dcc13889 (tcg: Create tcg_init) 13/26 Checking commit cadcc5d3a699 (accel/tcg: Merge tcg_exec_init into tcg_init_machine) WARNING: Block comments use a leading /* on a separate line #56: FILE: accel/tcg/tcg-all.c:121: + /* There's no guest base to take into account, so go ahead and WARNING: Block comments use * on subsequent lines #57: FILE: accel/tcg/tcg-all.c:122: + /* There's no guest base to take into account, so go ahead and + initialize the prologue now. */ WARNING: Block comments use a trailing */ on a separate line #57: FILE: accel/tcg/tcg-all.c:122: + initialize the prologue now. */ total: 0 errors, 3 warnings, 81 lines checked Patch 13/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/26 Checking commit c907f418aad9 (accel/tcg: Pass down max_cpus to tcg_init) 15/26 Checking commit 9d9a3a8ae652 (tcg: Introduce tcg_max_ctxs) 16/26 Checking commit 436e7dd93a75 (tcg: Move MAX_CODE_GEN_BUFFER_SIZE to tcg-target.h) 17/26 Checking commit af5f973c1c2b (tcg: Replace region.end with region.total_size) 18/26 Checking commit f288a3a8b8bd (tcg: Tidy tcg_n_regions) 19/26 Checking commit 1d71ed202671 (tcg: Tidy split_cross_256mb) 20/26 Checking commit 3c9cf4e7ef12 (tcg: Allocate code_gen_buffer into struct tcg_region_state) 21/26 Checking commit ef8fa4273239 (tcg: Return the map protection from alloc_code_gen_buffer) 22/26 Checking commit cec511957553 (tcg: Sink qemu_madvise call to common code) 23/26 Checking commit f390fd189d0a (tcg: Do not set guard pages in the rx buffer) 24/26 Checking commit 996417b0e3f2 (util/osdep: Add qemu_mprotect_rw) 25/26 Checking commit 20dd5546c917 (tcg: Merge buffer protection and guard page protection) 26/26 Checking commit 6270444cc180 (tcg: When allocating for !splitwx, begin with PROT_NONE) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210311002156.253711-1-richard.henderson@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Supercedes: 20210210105527.74943-1-r.bolshakov@yadro.com ("util/osdep: Avoid mprotect() RWX->NONE on Big Sur 11.2") It took a few more patches than imagined to unify the two places in which we manipulate the tcg code_gen buffer, but the result is surely cleaner. There's a lot more that could be done to clean up this part of tcg too. I tried to not get too side-tracked, but didn't wholly succeed. r~ Richard Henderson (26): meson: Split out tcg/meson.build meson: Move disas/tci.c to disas/meson.build meson: Split out fpu/meson.build tcg: Re-order tcg_region_init vs tcg_prologue_init tcg: Remove error return from tcg_region_initial_alloc__locked tcg: Split out tcg_region_initial_alloc tcg: Split out tcg_region_prologue_set tcg: Split out region.c accel/tcg: Inline cpu_gen_init accel/tcg: Move alloc_code_gen_buffer to tcg/region.c accel/tcg: Rename tcg_init to tcg_init_machine tcg: Create tcg_init accel/tcg: Merge tcg_exec_init into tcg_init_machine accel/tcg: Pass down max_cpus to tcg_init tcg: Introduce tcg_max_ctxs tcg: Move MAX_CODE_GEN_BUFFER_SIZE to tcg-target.h tcg: Replace region.end with region.total_size tcg: Tidy tcg_n_regions tcg: Tidy split_cross_256mb tcg: Allocate code_gen_buffer into struct tcg_region_state tcg: Return the map protection from alloc_code_gen_buffer tcg: Sink qemu_madvise call to common code tcg: Do not set guard pages in the rx buffer util/osdep: Add qemu_mprotect_rw tcg: Merge buffer protection and guard page protection tcg: When allocating for !splitwx, begin with PROT_NONE meson.build | 12 +- accel/tcg/internal.h | 2 + include/qemu/osdep.h | 1 + include/sysemu/tcg.h | 2 - include/tcg/tcg.h | 3 +- tcg/aarch64/tcg-target.h | 1 + tcg/arm/tcg-target.h | 1 + tcg/i386/tcg-target.h | 2 + tcg/internal.h | 39 ++ tcg/mips/tcg-target.h | 6 + tcg/ppc/tcg-target.h | 2 + tcg/riscv/tcg-target.h | 1 + tcg/s390/tcg-target.h | 3 + tcg/sparc/tcg-target.h | 1 + tcg/tci/tcg-target.h | 1 + accel/tcg/tcg-all.c | 33 +- accel/tcg/translate-all.c | 436 +---------------- bsd-user/main.c | 1 - linux-user/main.c | 1 - tcg/region.c | 959 ++++++++++++++++++++++++++++++++++++++ tcg/tcg.c | 610 ++---------------------- util/osdep.c | 9 + disas/meson.build | 2 + fpu/meson.build | 1 + tcg/meson.build | 14 + 25 files changed, 1104 insertions(+), 1039 deletions(-) create mode 100644 tcg/internal.h create mode 100644 tcg/region.c create mode 100644 fpu/meson.build create mode 100644 tcg/meson.build -- 2.25.1