mbox series

[PULL,00/47] tcg patch queue

Message ID 20210107201448.1152301-1-richard.henderson@linaro.org
Headers show
Series tcg patch queue | expand

Message

Richard Henderson Jan. 7, 2021, 8:14 p.m. UTC
The following changes since commit 470dd6bd360782f5137f7e3376af6a44658eb1d3:

  Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-060121-4' into staging (2021-01-06 22:18:36 +0000)

are available in the Git repository at:

  https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20210107

for you to fetch changes up to e5e2e4c73926f6f3c1f5da24a350e4345d5ad232:

  tcg: Constify TCGLabelQemuLdst.raddr (2021-01-07 05:09:42 -1000)

----------------------------------------------------------------
Build fix for ppc64 centos7.
Reduce the use of scratch registers for tcg/i386.
Use _aligned_malloc for Win32.
Enable split w^x code gen buffers.

----------------------------------------------------------------
Philippe Mathieu-Daudé (1):
      util/oslib: Assert qemu_try_memalign() alignment is a power of 2

Richard Henderson (46):
      linux-user: Conditionalize TUNSETVNETLE
      tcg/i386: Adjust TCG_TARGET_HAS_MEMORY_BSWAP
      tcg: Introduce INDEX_op_qemu_st8_i32
      util/oslib-win32: Use _aligned_malloc for qemu_try_memalign
      tcg: Do not flush icache for interpreter
      util: Enhance flush_icache_range with separate data pointer
      util: Specialize flush_idcache_range for aarch64
      tcg: Move tcg prologue pointer out of TCGContext
      tcg: Move tcg epilogue pointer out of TCGContext
      tcg: Add in_code_gen_buffer
      tcg: Introduce tcg_splitwx_to_{rx,rw}
      tcg: Adjust TCGLabel for const
      tcg: Adjust tcg_out_call for const
      tcg: Adjust tcg_out_label for const
      tcg: Adjust tcg_register_jit for const
      tcg: Adjust tb_target_set_jmp_target for split-wx
      tcg: Make DisasContextBase.tb const
      tcg: Make tb arg to synchronize_from_tb const
      tcg: Use Error with alloc_code_gen_buffer
      tcg: Add --accel tcg,split-wx property
      accel/tcg: Support split-wx for linux with memfd
      accel/tcg: Support split-wx for darwin/iOS with vm_remap
      tcg: Return the TB pointer from the rx region from exit_tb
      tcg/i386: Support split-wx code generation
      tcg/aarch64: Use B not BL for tcg_out_goto_long
      tcg/aarch64: Support split-wx code generation
      disas: Push const down through host disassembly
      tcg/tci: Push const down through bytecode reading
      tcg: Introduce tcg_tbrel_diff
      tcg/ppc: Use tcg_tbrel_diff
      tcg/ppc: Use tcg_out_mem_long to reset TCG_REG_TB
      tcg/ppc: Support split-wx code generation
      tcg/sparc: Use tcg_tbrel_diff
      tcg/sparc: Support split-wx code generation
      tcg/s390: Use tcg_tbrel_diff
      tcg/s390: Support split-wx code generation
      tcg/riscv: Fix branch range checks
      tcg/riscv: Remove branch-over-branch fallback
      tcg/riscv: Support split-wx code generation
      accel/tcg: Add mips support to alloc_code_gen_buffer_splitwx_memfd
      tcg/mips: Do not assert on relocation overflow
      tcg/mips: Support split-wx code generation
      tcg/arm: Support split-wx code generation
      tcg: Remove TCG_TARGET_SUPPORT_MIRROR
      tcg: Constify tcg_code_gen_epilogue
      tcg: Constify TCGLabelQemuLdst.raddr

 accel/tcg/tcg-runtime.h      |   2 +-
 include/disas/dis-asm.h      |   4 +-
 include/disas/disas.h        |   2 +-
 include/exec/exec-all.h      |   2 +-
 include/exec/gen-icount.h    |   4 +-
 include/exec/log.h           |   2 +-
 include/exec/translator.h    |   2 +-
 include/hw/core/cpu.h        |   3 +-
 include/qemu/cacheflush.h    |  15 ++-
 include/sysemu/tcg.h         |   3 +-
 include/tcg/tcg-op.h         |   2 +-
 include/tcg/tcg-opc.h        |   5 +
 include/tcg/tcg.h            |  61 +++++++--
 linux-user/ioctls.h          |   2 +
 tcg/aarch64/tcg-target.h     |   3 +-
 tcg/arm/tcg-target.h         |   3 +-
 tcg/i386/tcg-target.h        |  12 +-
 tcg/mips/tcg-target.h        |   3 +-
 tcg/ppc/tcg-target.h         |   3 +-
 tcg/riscv/tcg-target.h       |   3 +-
 tcg/s390/tcg-target.h        |   9 +-
 tcg/sparc/tcg-target.h       |   3 +-
 tcg/tci/tcg-target.h         |   7 +-
 accel/tcg/cpu-exec.c         |  41 +++---
 accel/tcg/tcg-all.c          |  26 +++-
 accel/tcg/tcg-runtime.c      |   4 +-
 accel/tcg/translate-all.c    | 311 ++++++++++++++++++++++++++++++++++---------
 accel/tcg/translator.c       |   4 +-
 bsd-user/main.c              |   2 +-
 disas.c                      |   2 +-
 disas/capstone.c             |   2 +-
 linux-user/main.c            |   2 +-
 softmmu/physmem.c            |   2 +-
 target/arm/cpu.c             |   3 +-
 target/arm/translate-a64.c   |   2 +-
 target/avr/cpu.c             |   3 +-
 target/hppa/cpu.c            |   3 +-
 target/i386/tcg/tcg-cpu.c    |   3 +-
 target/microblaze/cpu.c      |   3 +-
 target/mips/cpu.c            |   3 +-
 target/riscv/cpu.c           |   3 +-
 target/rx/cpu.c              |   3 +-
 target/sh4/cpu.c             |   3 +-
 target/sparc/cpu.c           |   3 +-
 target/tricore/cpu.c         |   2 +-
 tcg/optimize.c               |   1 +
 tcg/tcg-op.c                 |  21 ++-
 tcg/tcg.c                    |  94 ++++++++++---
 tcg/tci.c                    |  62 +++++----
 util/cacheflush.c            | 107 ++++++++++++---
 util/cacheinfo.c             |   8 +-
 util/oslib-posix.c           |   2 +
 util/oslib-win32.c           |  12 +-
 tcg/aarch64/tcg-target.c.inc |  75 ++++++-----
 tcg/arm/tcg-target.c.inc     |  41 +++---
 tcg/i386/tcg-target.c.inc    | 174 +++++++++++-------------
 tcg/mips/tcg-target.c.inc    |  97 ++++++--------
 tcg/ppc/tcg-target.c.inc     |  88 ++++++------
 tcg/riscv/tcg-target.c.inc   | 125 ++++++-----------
 tcg/s390/tcg-target.c.inc    |  91 ++++++-------
 tcg/sparc/tcg-target.c.inc   |  58 ++++----
 tcg/tcg-ldst.c.inc           |   2 +-
 tcg/tcg-pool.c.inc           |   6 +-
 tcg/tci/tcg-target.c.inc     |   2 +-
 accel/tcg/trace-events       |   2 +-
 qemu-options.hx              |   7 +
 tcg/README                   |   5 +
 67 files changed, 1035 insertions(+), 630 deletions(-)

Comments

no-reply@patchew.org Jan. 7, 2021, 9:03 p.m. UTC | #1
Patchew URL: https://patchew.org/QEMU/20210107201448.1152301-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210107201448.1152301-1-richard.henderson@linaro.org
Subject: [PULL 00/47] tcg patch queue

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20201217004349.3740927-1-wuhaotsh@google.com -> patchew/20201217004349.3740927-1-wuhaotsh@google.com
 * [new tag]         patchew/20210107201448.1152301-1-richard.henderson@linaro.org -> patchew/20210107201448.1152301-1-richard.henderson@linaro.org
 * [new tag]         patchew/20210107202135.52379-1-david@redhat.com -> patchew/20210107202135.52379-1-david@redhat.com
Switched to a new branch 'test'
baaf0fe tcg: Constify TCGLabelQemuLdst.raddr
11b7ecd tcg: Constify tcg_code_gen_epilogue
1cbfe80 tcg: Remove TCG_TARGET_SUPPORT_MIRROR
8293de7 tcg/arm: Support split-wx code generation
ee981fc tcg/mips: Support split-wx code generation
cc886de tcg/mips: Do not assert on relocation overflow
7edccfc accel/tcg: Add mips support to alloc_code_gen_buffer_splitwx_memfd
cd1d197 tcg/riscv: Support split-wx code generation
1e9023f tcg/riscv: Remove branch-over-branch fallback
918423b tcg/riscv: Fix branch range checks
9b4c46d tcg/s390: Support split-wx code generation
f4f6bfe tcg/s390: Use tcg_tbrel_diff
eeb5902 tcg/sparc: Support split-wx code generation
0063296 tcg/sparc: Use tcg_tbrel_diff
726a8d5 tcg/ppc: Support split-wx code generation
178b2f8 tcg/ppc: Use tcg_out_mem_long to reset TCG_REG_TB
34eddea tcg/ppc: Use tcg_tbrel_diff
5c598e3 tcg: Introduce tcg_tbrel_diff
49f2bb2 tcg/tci: Push const down through bytecode reading
b7dcd21 disas: Push const down through host disassembly
2f4fa86 tcg/aarch64: Support split-wx code generation
2281570 tcg/aarch64: Use B not BL for tcg_out_goto_long
3eb009f tcg/i386: Support split-wx code generation
ff582bc tcg: Return the TB pointer from the rx region from exit_tb
ff8cda4 accel/tcg: Support split-wx for darwin/iOS with vm_remap
3d11126 accel/tcg: Support split-wx for linux with memfd
3a0321d tcg: Add --accel tcg,split-wx property
7ad4a3c tcg: Use Error with alloc_code_gen_buffer
aa126e3 tcg: Make tb arg to synchronize_from_tb const
0fcb800 tcg: Make DisasContextBase.tb const
3cb9250 tcg: Adjust tb_target_set_jmp_target for split-wx
1aec9d3 tcg: Adjust tcg_register_jit for const
ad05d6b tcg: Adjust tcg_out_label for const
c2c5c8d tcg: Adjust tcg_out_call for const
5ee9e81 tcg: Adjust TCGLabel for const
853af37 tcg: Introduce tcg_splitwx_to_{rx,rw}
fe3436a tcg: Add in_code_gen_buffer
26546a3 tcg: Move tcg epilogue pointer out of TCGContext
ff316eb tcg: Move tcg prologue pointer out of TCGContext
9ad8166 util: Specialize flush_idcache_range for aarch64
b3a9807 util: Enhance flush_icache_range with separate data pointer
09ac14d tcg: Do not flush icache for interpreter
e561da4 util/oslib: Assert qemu_try_memalign() alignment is a power of 2
3ee9998 util/oslib-win32: Use _aligned_malloc for qemu_try_memalign
7acb88f tcg: Introduce INDEX_op_qemu_st8_i32
72e8b56 tcg/i386: Adjust TCG_TARGET_HAS_MEMORY_BSWAP
988e336 linux-user: Conditionalize TUNSETVNETLE

=== OUTPUT BEGIN ===
1/47 Checking commit 988e33623c3a (linux-user: Conditionalize TUNSETVNETLE)
2/47 Checking commit 72e8b5670ce2 (tcg/i386: Adjust TCG_TARGET_HAS_MEMORY_BSWAP)
3/47 Checking commit 7acb88f4c360 (tcg: Introduce INDEX_op_qemu_st8_i32)
4/47 Checking commit 3ee99982f56b (util/oslib-win32: Use _aligned_malloc for qemu_try_memalign)
5/47 Checking commit e561da41def8 (util/oslib: Assert qemu_try_memalign() alignment is a power of 2)
6/47 Checking commit 09ac14d3ad89 (tcg: Do not flush icache for interpreter)
7/47 Checking commit b3a9807019f1 (util: Enhance flush_icache_range with separate data pointer)
8/47 Checking commit 9ad81668d136 (util: Specialize flush_idcache_range for aarch64)
ERROR: externs should be avoided in .c files
#38: FILE: util/cacheflush.c:21:
+extern void sys_icache_invalidate(void *start, size_t len);

ERROR: externs should be avoided in .c files
#39: FILE: util/cacheflush.c:22:
+extern void sys_dcache_flush(void *start, size_t len);

total: 2 errors, 0 warnings, 81 lines checked

Patch 8/47 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

9/47 Checking commit ff316eb2ba9b (tcg: Move tcg prologue pointer out of TCGContext)
10/47 Checking commit 26546a391bfe (tcg: Move tcg epilogue pointer out of TCGContext)
11/47 Checking commit fe3436a9375c (tcg: Add in_code_gen_buffer)
12/47 Checking commit 853af37d0a4a (tcg: Introduce tcg_splitwx_to_{rx,rw})
13/47 Checking commit 5ee9e81f56c4 (tcg: Adjust TCGLabel for const)
14/47 Checking commit c2c5c8ddafc6 (tcg: Adjust tcg_out_call for const)
15/47 Checking commit ad05d6b7833f (tcg: Adjust tcg_out_label for const)
16/47 Checking commit 1aec9d3f57cb (tcg: Adjust tcg_register_jit for const)
17/47 Checking commit 3cb9250fdeea (tcg: Adjust tb_target_set_jmp_target for split-wx)
18/47 Checking commit 0fcb800d5272 (tcg: Make DisasContextBase.tb const)
19/47 Checking commit aa126e3b7567 (tcg: Make tb arg to synchronize_from_tb const)
20/47 Checking commit 7ad4a3ccda6d (tcg: Use Error with alloc_code_gen_buffer)
21/47 Checking commit 3a0321da4934 (tcg: Add --accel tcg,split-wx property)
22/47 Checking commit 3d11126f5823 (accel/tcg: Support split-wx for linux with memfd)
23/47 Checking commit ff8cda4b85c6 (accel/tcg: Support split-wx for darwin/iOS with vm_remap)
ERROR: externs should be avoided in .c files
#25: FILE: accel/tcg/translate-all.c:1172:
+extern kern_return_t mach_vm_remap(vm_map_t target_task,

total: 1 errors, 0 warnings, 82 lines checked

Patch 23/47 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

24/47 Checking commit ff582bc22d67 (tcg: Return the TB pointer from the rx region from exit_tb)
25/47 Checking commit 3eb009f0f317 (tcg/i386: Support split-wx code generation)
26/47 Checking commit 22815702bde3 (tcg/aarch64: Use B not BL for tcg_out_goto_long)
27/47 Checking commit 2f4fa8684093 (tcg/aarch64: Support split-wx code generation)
28/47 Checking commit b7dcd21caa66 (disas: Push const down through host disassembly)
29/47 Checking commit 49f2bb2556a8 (tcg/tci: Push const down through bytecode reading)
30/47 Checking commit 5c598e359fde (tcg: Introduce tcg_tbrel_diff)
31/47 Checking commit 34eddeae98fa (tcg/ppc: Use tcg_tbrel_diff)
32/47 Checking commit 178b2f810ed4 (tcg/ppc: Use tcg_out_mem_long to reset TCG_REG_TB)
33/47 Checking commit 726a8d5a085c (tcg/ppc: Support split-wx code generation)
34/47 Checking commit 00632966fcd9 (tcg/sparc: Use tcg_tbrel_diff)
35/47 Checking commit eeb5902862c5 (tcg/sparc: Support split-wx code generation)
36/47 Checking commit f4f6bfe64c07 (tcg/s390: Use tcg_tbrel_diff)
37/47 Checking commit 9b4c46d08827 (tcg/s390: Support split-wx code generation)
38/47 Checking commit 918423b9c915 (tcg/riscv: Fix branch range checks)
39/47 Checking commit 1e9023f5733d (tcg/riscv: Remove branch-over-branch fallback)
40/47 Checking commit cd1d1978bd2f (tcg/riscv: Support split-wx code generation)
41/47 Checking commit 7edccfcfd8fb (accel/tcg: Add mips support to alloc_code_gen_buffer_splitwx_memfd)
WARNING: architecture specific defines should be avoided
#25: FILE: accel/tcg/translate-all.c:1143:
+#ifdef __mips__

WARNING: architecture specific defines should be avoided
#43: FILE: accel/tcg/translate-all.c:1160:
+#ifdef __mips__

total: 0 errors, 2 warnings, 68 lines checked

Patch 41/47 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
42/47 Checking commit cc886dec0795 (tcg/mips: Do not assert on relocation overflow)
43/47 Checking commit ee981fc1aad9 (tcg/mips: Support split-wx code generation)
44/47 Checking commit 8293de76dcc3 (tcg/arm: Support split-wx code generation)
45/47 Checking commit 1cbfe801dcf7 (tcg: Remove TCG_TARGET_SUPPORT_MIRROR)
46/47 Checking commit 11b7ecdd90cc (tcg: Constify tcg_code_gen_epilogue)
47/47 Checking commit baaf0fe5cc02 (tcg: Constify TCGLabelQemuLdst.raddr)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210107201448.1152301-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Peter Maydell Jan. 8, 2021, 10:28 a.m. UTC | #2
On Thu, 7 Jan 2021 at 20:14, Richard Henderson
<richard.henderson@linaro.org> wrote:
>

> The following changes since commit 470dd6bd360782f5137f7e3376af6a44658eb1d3:

>

>   Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-060121-4' into staging (2021-01-06 22:18:36 +0000)

>

> are available in the Git repository at:

>

>   https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20210107

>

> for you to fetch changes up to e5e2e4c73926f6f3c1f5da24a350e4345d5ad232:

>

>   tcg: Constify TCGLabelQemuLdst.raddr (2021-01-07 05:09:42 -1000)

>

> ----------------------------------------------------------------

> Build fix for ppc64 centos7.

> Reduce the use of scratch registers for tcg/i386.

> Use _aligned_malloc for Win32.

> Enable split w^x code gen buffers.

>



Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/6.0
for any user-visible changes.

-- PMM