| Message ID | 20201223060204.576856-1-richard.henderson@linaro.org |
|---|---|
| Headers | show |
| Series | tcg: backend constraints cleanup | expand |
Patchew URL: https://patchew.org/QEMU/20201223060204.576856-1-richard.henderson@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201223060204.576856-1-richard.henderson@linaro.org Subject: [PATCH 00/22] tcg: backend constraints cleanup === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20201223060204.576856-1-richard.henderson@linaro.org -> patchew/20201223060204.576856-1-richard.henderson@linaro.org Switched to a new branch 'test' 8b65955 tcg: Remove TCG_TARGET_CONSET_H 3a9c766 tcg/tci: Convert to tcg-target-conset.h 7e3d876 tcg/sparc: Convert to tcg-target-conset.h 759b112 tcg/s390: Convert to tcg-target-conset.h c9e097a tcg/riscv: Convert to tcg-target-conset.h 6b86815 tcg/ppc: Convert to tcg-target-conset.h 5b5b4b5 tcg/mips: Convert to tcg-target-conset.h 8664281 tcg/arm: Convert to tcg-target-conset.h 80ce8a8 tcg/aarch64: Convert to tcg-target-conset.h fbe649c tcg: Split out constraint sets to tcg-target-conset.h c3f9af7 tcg: Remove TCG_TARGET_CONSTR_H 758fd8b tcg/sparc: Convert to tcg-target-constr.h 0c2e793 tcg/s390: Convert to tcg-target-constr.h 9c409ea tcg/riscv: Convert to tcg-target-constr.h 54c599f tcg/mips: Convert to tcg-target-constr.h 7231211 tcg/tci: Convert to tcg-target-constr.h c641c2e tcg/ppc: Convert to tcg-target-constr.h dc946e3 tcg/aarch64: Convert to tcg-target-constr.h 8cef9ef tcg/arm: Convert to tcg-target-constr.h 00f2363 tcg: Split out target constraints to tcg-target-constr.h a23958f tcg/i386: Move constraint type check to tcg_target_const_match 940927d tcg/tci: Drop L and S constraints === OUTPUT BEGIN === 1/22 Checking commit 940927ddc8e8 (tcg/tci: Drop L and S constraints) 2/22 Checking commit a23958fc7bde (tcg/i386: Move constraint type check to tcg_target_const_match) 3/22 Checking commit 00f236316045 (tcg: Split out target constraints to tcg-target-constr.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 ERROR: Macros with multiple statements should be enclosed in a do - while loop #187: FILE: tcg/tcg.c:2295: +#define CONST(CASE, MASK) \ + case CASE: def->args_ct[i].ct |= MASK; ct_str++; break; ERROR: trailing statements should be on next line #188: FILE: tcg/tcg.c:2296: + case CASE: def->args_ct[i].ct |= MASK; ct_str++; break; ERROR: Macros with multiple statements should be enclosed in a do - while loop #189: FILE: tcg/tcg.c:2297: +#define REGS(CASE, MASK) \ + case CASE: def->args_ct[i].regs |= MASK; ct_str++; break; ERROR: trailing statements should be on next line #190: FILE: tcg/tcg.c:2298: + case CASE: def->args_ct[i].regs |= MASK; ct_str++; break; total: 4 errors, 1 warnings, 177 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit 8cef9ef1733f (tcg/arm: Convert to tcg-target-constr.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 103 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit dc946e3eef6d (tcg/aarch64: Convert to tcg-target-constr.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 85 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit c641c2e55a80 (tcg/ppc: Convert to tcg-target-constr.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 107 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit 72312113a5a2 (tcg/tci: Convert to tcg-target-constr.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 35 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit 54c599f39de4 (tcg/mips: Convert to tcg-target-constr.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 99 lines checked Patch 8/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/22 Checking commit 9c409ea55307 (tcg/riscv: Convert to tcg-target-constr.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 75 lines checked Patch 9/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/22 Checking commit 0c2e793db503 (tcg/s390: Convert to tcg-target-constr.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 67 lines checked Patch 10/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/22 Checking commit 758fd8bea2ca (tcg/sparc: Convert to tcg-target-constr.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 67 lines checked Patch 11/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/22 Checking commit c3f9af77c862 (tcg: Remove TCG_TARGET_CONSTR_H) 13/22 Checking commit fbe649c12074 (tcg: Split out constraint sets to tcg-target-conset.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #14: new file mode 100644 ERROR: Macros with complex values should be enclosed in parenthesis #423: FILE: tcg/tcg.c:357: +#define C_O0_I1(I1) C_PFX1(c_o0_i1_, I1), ERROR: Macros with complex values should be enclosed in parenthesis #424: FILE: tcg/tcg.c:358: +#define C_O0_I2(I1, I2) C_PFX2(c_o0_i2_, I1, I2), ERROR: Macros with complex values should be enclosed in parenthesis #425: FILE: tcg/tcg.c:359: +#define C_O0_I3(I1, I2, I3) C_PFX3(c_o0_i3_, I1, I2, I3), ERROR: Macros with complex values should be enclosed in parenthesis #426: FILE: tcg/tcg.c:360: +#define C_O0_I4(I1, I2, I3, I4) C_PFX4(c_o0_i4_, I1, I2, I3, I4), ERROR: Macros with complex values should be enclosed in parenthesis #428: FILE: tcg/tcg.c:362: +#define C_O1_I1(O1, I1) C_PFX2(c_o1_i1_, O1, I1), ERROR: Macros with complex values should be enclosed in parenthesis #429: FILE: tcg/tcg.c:363: +#define C_O1_I2(O1, I1, I2) C_PFX3(c_o1_i2_, O1, I1, I2), ERROR: Macros with complex values should be enclosed in parenthesis #430: FILE: tcg/tcg.c:364: +#define C_O1_I3(O1, I1, I2, I3) C_PFX4(c_o1_i3_, O1, I1, I2, I3), ERROR: Macros with complex values should be enclosed in parenthesis #431: FILE: tcg/tcg.c:365: +#define C_O1_I4(O1, I1, I2, I3, I4) C_PFX5(c_o1_i4_, O1, I1, I2, I3, I4), ERROR: Macros with complex values should be enclosed in parenthesis #433: FILE: tcg/tcg.c:367: +#define C_N1_I2(O1, I1, I2) C_PFX3(c_n1_i2_, O1, I1, I2), ERROR: Macros with complex values should be enclosed in parenthesis #435: FILE: tcg/tcg.c:369: +#define C_O2_I1(O1, O2, I1) C_PFX3(c_o2_i1_, O1, O2, I1), ERROR: Macros with complex values should be enclosed in parenthesis #436: FILE: tcg/tcg.c:370: +#define C_O2_I2(O1, O2, I1, I2) C_PFX4(c_o2_i2_, O1, O2, I1, I2), ERROR: Macros with complex values should be enclosed in parenthesis #437: FILE: tcg/tcg.c:371: +#define C_O2_I3(O1, O2, I1, I2, I3) C_PFX5(c_o2_i3_, O1, O2, I1, I2, I3), ERROR: Macros with complex values should be enclosed in parenthesis #438: FILE: tcg/tcg.c:372: +#define C_O2_I4(O1, O2, I1, I2, I3, I4) \ + C_PFX6(c_o2_i4_, O1, O2, I1, I2, I3, I4), total: 13 errors, 1 warnings, 506 lines checked Patch 13/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/22 Checking commit 80ce8a8cce5c (tcg/aarch64: Convert to tcg-target-conset.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 219 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit 86642819eb3e (tcg/arm: Convert to tcg-target-conset.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 187 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit 5b5b4b527edd (tcg/mips: Convert to tcg-target-conset.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 203 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit 6b8681521e36 (tcg/ppc: Convert to tcg-target-conset.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 265 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit c9e097afd8a3 (tcg/riscv: Convert to tcg-target-conset.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 175 lines checked Patch 18/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/22 Checking commit 759b11287ddc (tcg/s390: Convert to tcg-target-conset.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 223 lines checked Patch 19/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/22 Checking commit 7e3d876c1fff (tcg/sparc: Convert to tcg-target-conset.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 178 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit 3a9c766171ee (tcg/tci: Convert to tcg-target-conset.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 total: 0 errors, 1 warnings, 387 lines checked Patch 21/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/22 Checking commit 8b65955e39e2 (tcg: Remove TCG_TARGET_CONSET_H) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20201223060204.576856-1-richard.henderson@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com