| Message ID | 20201214140314.18544-1-richard.henderson@linaro.org |
|---|---|
| Headers | show |
| Series | Mirror map JIT memory for TCG | expand |
Patchew URL: https://patchew.org/QEMU/20201214140314.18544-1-richard.henderson@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20201214140314.18544-1-richard.henderson@linaro.org
Subject: [PATCH v4 00/43] Mirror map JIT memory for TCG
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
37f04b7..aa14de0 master -> master
- [tag update] patchew/20201211220529.2290218-1-ehabkost@redhat.com -> patchew/20201211220529.2290218-1-ehabkost@redhat.com
* [new tag] patchew/20201214140314.18544-1-richard.henderson@linaro.org -> patchew/20201214140314.18544-1-richard.henderson@linaro.org
* [new tag] patchew/20201214155733.207430-1-laurent@vivier.eu -> patchew/20201214155733.207430-1-laurent@vivier.eu
* [new tag] patchew/20201214200713.3886611-1-keithp@keithp.com -> patchew/20201214200713.3886611-1-keithp@keithp.com
Switched to a new branch 'test'
5861ba1 tcg: Constify TCGLabelQemuLdst.raddr
8b66138 tcg: Constify tcg_code_gen_epilogue
b60ae50 tcg: Remove TCG_TARGET_SUPPORT_MIRROR
ceb2ae8 tcg/arm: Support split-wx code generation
ddb32ce tcg/mips: Support split-wx code generation
d286278 tcg/mips: Do not assert on relocation overflow
c6603c2 accel/tcg: Add mips support to alloc_code_gen_buffer_splitwx_memfd
f472d2a tcg/riscv: Support split-wx code generation
c7b4c9e tcg/riscv: Remove branch-over-branch fallback
5a73605 tcg/riscv: Fix branch range checks
b07237d tcg/s390: Support split-wx code generation
1b609a5 tcg/s390: Use tcg_tbrel_diff
ab6c76a tcg/sparc: Support split-wx code generation
eeb9f35 tcg/sparc: Use tcg_tbrel_diff
5d2fb73 tcg/ppc: Support split-wx code generation
54626b4 tcg/ppc: Use tcg_out_mem_long to reset TCG_REG_TB
a810384 tcg/ppc: Use tcg_tbrel_diff
4327613 tcg: Introduce tcg_tbrel_diff
b5817c5 tcg/tci: Push const down through bytecode reading
3a0b856 disas: Push const down through host disasassembly
875346c tcg/aarch64: Support split-wx code generation
d8fca0b tcg/aarch64: Use B not BL for tcg_out_goto_long
5c1da59 tcg/i386: Support split-wx code generation
cf974dc tcg: Return the TB pointer from the rx region from exit_tb
4e63180 accel/tcg: Support split-wx for darwin/iOS with vm_remap
2acd41d accel/tcg: Support split-wx for linux with memfd
43dc2fc tcg: Add --accel tcg,split-wx property
a93d787 tcg: Use Error with alloc_code_gen_buffer
14f4dae tcg: Make tb arg to synchronize_from_tb const
6d2cbe3 tcg: Make DisasContextBase.tb const
1ff4e38 tcg: Adjust tb_target_set_jmp_target for split-wx
9163383 tcg: Adjust tcg_register_jit for const
ef98b3c tcg: Adjust tcg_out_label for const
ff58797 tcg: Adjust tcg_out_call for const
204f5dd tcg: Adjust TCGLabel for const
3a0629b tcg: Introduce tcg_splitwx_to_{rx,rw}
e69b13a tcg: Add in_code_gen_buffer
0c55fbc tcg: Move tcg epilogue pointer out of TCGContext
5b1eb71 tcg: Move tcg prologue pointer out of TCGContext
22fc3b0 util: Specialize flush_idcache_range for aarch64
4a47d91 util: Enhance flush_icache_range with separate data pointer
722b23b util: Extract flush_icache_range to cacheflush.c
2a3aaed tcg: Do not flush icache for interpreter
=== OUTPUT BEGIN ===
1/43 Checking commit 2a3aaedef170 (tcg: Do not flush icache for interpreter)
2/43 Checking commit 722b23b5bb81 (util: Extract flush_icache_range to cacheflush.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#28:
new file mode 100644
WARNING: architecture specific defines should be avoided
#43: FILE: include/qemu/cacheflush.h:11:
+#if defined(__i386__) || defined(__x86_64__) || defined(__s390__)
WARNING: architecture specific defines should be avoided
#277: FILE: util/cacheflush.c:12:
+#if defined(__i386__) || defined(__x86_64__) || defined(__s390__)
WARNING: architecture specific defines should be avoided
#283: FILE: util/cacheflush.c:18:
+#ifdef __OpenBSD__
total: 0 errors, 4 warnings, 232 lines checked
Patch 2/43 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/43 Checking commit 4a47d9160cc1 (util: Enhance flush_icache_range with separate data pointer)
4/43 Checking commit 22fc3b028090 (util: Specialize flush_idcache_range for aarch64)
ERROR: externs should be avoided in .c files
#38: FILE: util/cacheflush.c:21:
+extern void sys_icache_invalidate(void *start, size_t len);
ERROR: externs should be avoided in .c files
#39: FILE: util/cacheflush.c:22:
+extern void sys_dcache_flush(void *start, size_t len);
total: 2 errors, 0 warnings, 81 lines checked
Patch 4/43 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/43 Checking commit 5b1eb71d0d3a (tcg: Move tcg prologue pointer out of TCGContext)
6/43 Checking commit 0c55fbc2c214 (tcg: Move tcg epilogue pointer out of TCGContext)
7/43 Checking commit e69b13a6c541 (tcg: Add in_code_gen_buffer)
8/43 Checking commit 3a0629b80930 (tcg: Introduce tcg_splitwx_to_{rx,rw})
9/43 Checking commit 204f5dd20af1 (tcg: Adjust TCGLabel for const)
10/43 Checking commit ff58797d1164 (tcg: Adjust tcg_out_call for const)
11/43 Checking commit ef98b3c104ed (tcg: Adjust tcg_out_label for const)
12/43 Checking commit 91633839ff16 (tcg: Adjust tcg_register_jit for const)
13/43 Checking commit 1ff4e38e1db3 (tcg: Adjust tb_target_set_jmp_target for split-wx)
14/43 Checking commit 6d2cbe338b4c (tcg: Make DisasContextBase.tb const)
15/43 Checking commit 14f4daed4c08 (tcg: Make tb arg to synchronize_from_tb const)
16/43 Checking commit a93d787bb9c9 (tcg: Use Error with alloc_code_gen_buffer)
17/43 Checking commit 43dc2fccc410 (tcg: Add --accel tcg,split-wx property)
18/43 Checking commit 2acd41d2d9f5 (accel/tcg: Support split-wx for linux with memfd)
19/43 Checking commit 4e63180ada66 (accel/tcg: Support split-wx for darwin/iOS with vm_remap)
ERROR: externs should be avoided in .c files
#25: FILE: accel/tcg/translate-all.c:1172:
+extern kern_return_t mach_vm_remap(vm_map_t target_task,
total: 1 errors, 0 warnings, 80 lines checked
Patch 19/43 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/43 Checking commit cf974dcd5791 (tcg: Return the TB pointer from the rx region from exit_tb)
21/43 Checking commit 5c1da59df861 (tcg/i386: Support split-wx code generation)
22/43 Checking commit d8fca0b8d088 (tcg/aarch64: Use B not BL for tcg_out_goto_long)
23/43 Checking commit 875346c2f10b (tcg/aarch64: Support split-wx code generation)
24/43 Checking commit 3a0b856585ee (disas: Push const down through host disasassembly)
25/43 Checking commit b5817c5ffe00 (tcg/tci: Push const down through bytecode reading)
26/43 Checking commit 43276137bef1 (tcg: Introduce tcg_tbrel_diff)
27/43 Checking commit a81038425cc1 (tcg/ppc: Use tcg_tbrel_diff)
28/43 Checking commit 54626b45773b (tcg/ppc: Use tcg_out_mem_long to reset TCG_REG_TB)
29/43 Checking commit 5d2fb73b63eb (tcg/ppc: Support split-wx code generation)
30/43 Checking commit eeb9f35b5237 (tcg/sparc: Use tcg_tbrel_diff)
31/43 Checking commit ab6c76aedab4 (tcg/sparc: Support split-wx code generation)
32/43 Checking commit 1b609a5e826c (tcg/s390: Use tcg_tbrel_diff)
33/43 Checking commit b07237ddf5df (tcg/s390: Support split-wx code generation)
34/43 Checking commit 5a73605068a9 (tcg/riscv: Fix branch range checks)
35/43 Checking commit c7b4c9ef06e0 (tcg/riscv: Remove branch-over-branch fallback)
36/43 Checking commit f472d2a9a4ed (tcg/riscv: Support split-wx code generation)
37/43 Checking commit c6603c22b80e (accel/tcg: Add mips support to alloc_code_gen_buffer_splitwx_memfd)
WARNING: architecture specific defines should be avoided
#25: FILE: accel/tcg/translate-all.c:1143:
+#ifdef __mips__
WARNING: architecture specific defines should be avoided
#43: FILE: accel/tcg/translate-all.c:1160:
+#ifdef __mips__
total: 0 errors, 2 warnings, 68 lines checked
Patch 37/43 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
38/43 Checking commit d2862788fc63 (tcg/mips: Do not assert on relocation overflow)
39/43 Checking commit ddb32ce98dcc (tcg/mips: Support split-wx code generation)
40/43 Checking commit ceb2ae8c947b (tcg/arm: Support split-wx code generation)
41/43 Checking commit b60ae504f046 (tcg: Remove TCG_TARGET_SUPPORT_MIRROR)
42/43 Checking commit 8b66138f4c23 (tcg: Constify tcg_code_gen_epilogue)
43/43 Checking commit 5861ba146e9c (tcg: Constify TCGLabelQemuLdst.raddr)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20201214140314.18544-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Changes for v4: * Move flush_icache_range to util/. The fixme that I added before to softmmu/physmem.c actually happened now that we're building aarch64 xen in gitlab-ci. * Fix ifdefs for "Remove TCG_TARGET_SUPPORT_MIRROR". r~ Richard Henderson (43): tcg: Do not flush icache for interpreter util: Extract flush_icache_range to cacheflush.c util: Enhance flush_icache_range with separate data pointer util: Specialize flush_idcache_range for aarch64 tcg: Move tcg prologue pointer out of TCGContext tcg: Move tcg epilogue pointer out of TCGContext tcg: Add in_code_gen_buffer tcg: Introduce tcg_splitwx_to_{rx,rw} tcg: Adjust TCGLabel for const tcg: Adjust tcg_out_call for const tcg: Adjust tcg_out_label for const tcg: Adjust tcg_register_jit for const tcg: Adjust tb_target_set_jmp_target for split-wx tcg: Make DisasContextBase.tb const tcg: Make tb arg to synchronize_from_tb const tcg: Use Error with alloc_code_gen_buffer tcg: Add --accel tcg,split-wx property accel/tcg: Support split-wx for linux with memfd accel/tcg: Support split-wx for darwin/iOS with vm_remap tcg: Return the TB pointer from the rx region from exit_tb tcg/i386: Support split-wx code generation tcg/aarch64: Use B not BL for tcg_out_goto_long tcg/aarch64: Support split-wx code generation disas: Push const down through host disasassembly tcg/tci: Push const down through bytecode reading tcg: Introduce tcg_tbrel_diff tcg/ppc: Use tcg_tbrel_diff tcg/ppc: Use tcg_out_mem_long to reset TCG_REG_TB tcg/ppc: Support split-wx code generation tcg/sparc: Use tcg_tbrel_diff tcg/sparc: Support split-wx code generation tcg/s390: Use tcg_tbrel_diff tcg/s390: Support split-wx code generation tcg/riscv: Fix branch range checks tcg/riscv: Remove branch-over-branch fallback tcg/riscv: Support split-wx code generation accel/tcg: Add mips support to alloc_code_gen_buffer_splitwx_memfd tcg/mips: Do not assert on relocation overflow tcg/mips: Support split-wx code generation tcg/arm: Support split-wx code generation tcg: Remove TCG_TARGET_SUPPORT_MIRROR tcg: Constify tcg_code_gen_epilogue tcg: Constify TCGLabelQemuLdst.raddr accel/tcg/tcg-runtime.h | 2 +- include/disas/dis-asm.h | 4 +- include/disas/disas.h | 2 +- include/exec/exec-all.h | 2 +- include/exec/gen-icount.h | 4 +- include/exec/log.h | 2 +- include/exec/translator.h | 2 +- include/hw/core/cpu.h | 3 +- include/qemu/cacheflush.h | 35 ++++ include/sysemu/tcg.h | 3 +- include/tcg/tcg-op.h | 2 +- include/tcg/tcg.h | 56 +++++-- tcg/aarch64/tcg-target.h | 7 +- tcg/arm/tcg-target.h | 7 +- tcg/i386/tcg-target.h | 10 +- tcg/mips/tcg-target.h | 13 +- tcg/ppc/tcg-target.h | 3 +- tcg/riscv/tcg-target.h | 7 +- tcg/s390/tcg-target.h | 12 +- tcg/sparc/tcg-target.h | 10 +- tcg/tci/tcg-target.h | 10 +- accel/tcg/cpu-exec.c | 41 +++-- accel/tcg/tcg-all.c | 26 ++- accel/tcg/tcg-runtime.c | 4 +- accel/tcg/translate-all.c | 309 +++++++++++++++++++++++++++-------- accel/tcg/translator.c | 4 +- bsd-user/main.c | 2 +- disas.c | 2 +- disas/capstone.c | 2 +- linux-user/main.c | 2 +- softmmu/physmem.c | 3 +- target/arm/cpu.c | 3 +- target/arm/translate-a64.c | 2 +- target/avr/cpu.c | 3 +- target/hppa/cpu.c | 3 +- target/i386/cpu.c | 3 +- target/microblaze/cpu.c | 3 +- target/mips/cpu.c | 3 +- target/riscv/cpu.c | 3 +- target/rx/cpu.c | 3 +- target/sh4/cpu.c | 3 +- target/sparc/cpu.c | 3 +- target/tricore/cpu.c | 2 +- tcg/tcg-op.c | 15 +- tcg/tcg.c | 91 +++++++++-- tcg/tci.c | 60 ++++--- util/cacheflush.c | 146 +++++++++++++++++ util/cacheinfo.c | 8 +- MAINTAINERS | 2 + accel/tcg/trace-events | 2 +- tcg/aarch64/tcg-target.c.inc | 75 +++++---- tcg/arm/tcg-target.c.inc | 41 ++--- tcg/i386/tcg-target.c.inc | 36 ++-- tcg/mips/tcg-target.c.inc | 97 +++++------ tcg/ppc/tcg-target.c.inc | 110 ++++++------- tcg/riscv/tcg-target.c.inc | 125 +++++--------- tcg/s390/tcg-target.c.inc | 91 +++++------ tcg/sparc/tcg-target.c.inc | 58 +++---- tcg/tcg-ldst.c.inc | 2 +- tcg/tcg-pool.c.inc | 6 +- tcg/tci/tcg-target.c.inc | 2 +- util/meson.build | 2 +- 62 files changed, 1003 insertions(+), 591 deletions(-) create mode 100644 include/qemu/cacheflush.h create mode 100644 util/cacheflush.c -- 2.25.1