| Message ID | 20201103142306.71782-1-mst@redhat.com |
|---|---|
| Headers | show |
| Series | pc,pci,vhost,virtio: fixes | expand |
On Tue, 3 Nov 2020 at 14:34, Michael S. Tsirkin <mst@redhat.com> wrote: > > The following changes since commit c7a7a877b716cf14848f1fd5c754d293e2f8d852: > > Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20201102' into staging (2020-11-03 10:38:05 +0000) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream > > for you to fetch changes up to cf0bdd0a703911f80fc645dec97f17c4415af267: > > vhost-user-blk-test: fix races by using fd passing (2020-11-03 09:19:12 -0500) > > ---------------------------------------------------------------- > pc,pci,vhost,virtio: fixes > > Lots of fixes all over the place. > virtio-mem and virtio-iommu patches are kind of fixes but > it seems better to just make them behave sanely than > try to educate users about the limitations ... > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > ---------------------------------------------------------------- Fails to compile on 32-bit host: ../../hw/vfio/common.c: In function 'vfio_listener_region_del': ../../hw/vfio/common.c:953:20: error: invalid operands to binary == (have 'Int128 {aka struct Int128}' and 'Int128 {aka struct Int128}') if (llsize == int128_2_64()) { ^~ ~~~~~~~~~~~~~ This needs to use int128_eq() to do the comparison. thanks -- PMM
On Tue, Nov 03, 2020 at 03:59:26PM +0000, Peter Maydell wrote: > On Tue, 3 Nov 2020 at 14:34, Michael S. Tsirkin <mst@redhat.com> wrote: > > > > The following changes since commit c7a7a877b716cf14848f1fd5c754d293e2f8d852: > > > > Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20201102' into staging (2020-11-03 10:38:05 +0000) > > > > are available in the Git repository at: > > > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream > > > > for you to fetch changes up to cf0bdd0a703911f80fc645dec97f17c4415af267: > > > > vhost-user-blk-test: fix races by using fd passing (2020-11-03 09:19:12 -0500) > > > > ---------------------------------------------------------------- > > pc,pci,vhost,virtio: fixes > > > > Lots of fixes all over the place. > > virtio-mem and virtio-iommu patches are kind of fixes but > > it seems better to just make them behave sanely than > > try to educate users about the limitations ... > > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > > > ---------------------------------------------------------------- > > Fails to compile on 32-bit host: > > ../../hw/vfio/common.c: In function 'vfio_listener_region_del': > ../../hw/vfio/common.c:953:20: error: invalid operands to binary == > (have 'Int128 {aka struct Int128}' and 'Int128 {aka struct Int128}') > if (llsize == int128_2_64()) { > ^~ ~~~~~~~~~~~~~ > > This needs to use int128_eq() to do the comparison. > > thanks > -- PMM Pushed same tag again. -- MST
The following changes since commit c7a7a877b716cf14848f1fd5c754d293e2f8d852: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20201102' into staging (2020-11-03 10:38:05 +0000) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to cf0bdd0a703911f80fc645dec97f17c4415af267: vhost-user-blk-test: fix races by using fd passing (2020-11-03 09:19:12 -0500) ---------------------------------------------------------------- pc,pci,vhost,virtio: fixes Lots of fixes all over the place. virtio-mem and virtio-iommu patches are kind of fixes but it seems better to just make them behave sanely than try to educate users about the limitations ... Signed-off-by: Michael S. Tsirkin <mst@redhat.com> ---------------------------------------------------------------- Bharat Bhushan (7): virtio-iommu: Add memory notifiers for map/unmap virtio-iommu: Call memory notifiers in attach/detach virtio-iommu: Add replay() memory region callback virtio-iommu: Add notify_flag_changed() memory region callback memory: Add interface to set iommu page size mask vfio: Set IOMMU page size as per host supported page size virtio-iommu: Set supported page size mask Cindy Lu (2): vhost-vdpa: Add qemu_close in vhost_vdpa_cleanup net: Add vhost-vdpa in show_netdevs() Coiby Xu (1): test: new qTest case to test the vhost-user-blk-server David Hildenbrand (6): virtio-mem: Make sure "addr" is always multiples of the block size virtio-mem: Make sure "usable_region_size" is always multiples of the block size virtio-mem: Probe THP size to determine default block size memory-device: Support big alignment requirements memory-device: Add get_min_alignment() callback virito-mem: Implement get_min_alignment() Jean-Philippe Brucker (3): virtio-iommu: Fix virtio_iommu_mr() virtio-iommu: Store memory region in endpoint struct vfio: Don't issue full 2^64 unmap Jin Yu (1): vhost-blk: set features before setting inflight feature Michael S. Tsirkin (1): pc: comment style fixup Philippe Mathieu-Daudé (2): hw/virtio/vhost-backend: Fix Coverity CID 1432871 hw/smbios: Fix leaked fd in save_opt_one() error path Stefan Hajnoczi (12): Revert "vhost-blk: set features before setting inflight feature" libvhost-user: follow QEMU comment style configure: introduce --enable-vhost-user-blk-server block/export: make vhost-user-blk config space little-endian block/export: fix vhost-user-blk get_config() information leak contrib/vhost-user-blk: fix get_config() information leak tests/qtest: add multi-queue test case to vhost-user-blk-test libqtest: add qtest_socket_server() vhost-user-blk-test: rename destroy_drive() to destroy_file() vhost-user-blk-test: close fork child file descriptors vhost-user-blk-test: drop unused return value vhost-user-blk-test: fix races by using fd passing Xinhao Zhang (3): hw/acpi : Don't use '#' flag of printf format hw/acpi : add space before the open parenthesis '(' hw/acpi : add spaces around operator configure | 15 + contrib/libvhost-user/libvhost-user.h | 15 +- include/exec/memory.h | 38 ++ include/hw/mem/memory-device.h | 10 + include/hw/virtio/vhost.h | 2 +- tests/qtest/libqos/libqtest.h | 25 + tests/qtest/libqos/vhost-user-blk.h | 48 ++ block/export/export.c | 4 +- block/export/vhost-user-blk-server.c | 28 +- contrib/vhost-user-blk/vhost-user-blk.c | 2 + hw/acpi/core.c | 2 +- hw/acpi/nvdimm.c | 20 +- hw/acpi/pcihp.c | 2 +- hw/block/vhost-user-blk.c | 2 +- hw/i386/pc.c | 9 +- hw/mem/memory-device.c | 20 +- hw/smbios/smbios.c | 4 +- hw/vfio/common.c | 19 + hw/virtio/vhost-backend.c | 4 +- hw/virtio/vhost.c | 8 +- hw/virtio/virtio-iommu.c | 205 +++++++- hw/virtio/virtio-mem-pci.c | 7 + hw/virtio/virtio-mem.c | 113 ++++- net/net.c | 3 + net/vhost-vdpa.c | 4 + softmmu/memory.c | 13 + tests/qtest/libqos/vhost-user-blk.c | 129 +++++ tests/qtest/libqtest.c | 76 ++- tests/qtest/vhost-user-blk-test.c | 843 ++++++++++++++++++++++++++++++++ block/export/meson.build | 2 +- hw/virtio/trace-events | 6 + tests/qtest/libqos/meson.build | 1 + tests/qtest/meson.build | 2 + util/meson.build | 2 +- 34 files changed, 1606 insertions(+), 77 deletions(-) create mode 100644 tests/qtest/libqos/vhost-user-blk.h create mode 100644 tests/qtest/libqos/vhost-user-blk.c create mode 100644 tests/qtest/vhost-user-blk-test.c