mbox series

[v7,0/3] hw/block/nvme: dulbe and dsm support

Message ID 20201027175725.586890-1-its@irrelevant.dk
Headers show
Series hw/block/nvme: dulbe and dsm support | expand

Message

Klaus Jensen Oct. 27, 2020, 5:57 p.m. UTC 
From: Klaus Jensen <k.jensen@samsung.com>


This adds support for the Deallocated or Unwritten Logical Block error
recovery feature as well as the Dataset Management command.

v7:
  - Handle negative return value from bdrv_block_status.
  - bdrv_get_info may not be supported on all block drivers, so do not
    consider it a fatal error.

v6:
  - Skip the allocation of the discards integer and just use the opaque
    value directly (Philippe)
  - Split changes to include/block/nvme.h into a separate patch
    (Philippe)
  - Clean up some convoluted checks on the discards value (Philippe)
  - Use unambiguous units in the commit messages (Philippe)
  - Stack allocate the range array (Keith)

v5:
  - Restore status code from callback (Keith)

v4:
  - Removed mixed declaration and code (Keith)
  - Set NPDG and NPDA and account for the blockdev cluster size.

Klaus Jensen (3):
  hw/block/nvme: add dulbe support
  nvme: add namespace I/O optimization fields to shared header
  hw/block/nvme: add the dataset management command

 hw/block/nvme-ns.h    |   4 +
 hw/block/nvme.h       |   2 +
 include/block/nvme.h  |  12 ++-
 hw/block/nvme-ns.c    |  34 ++++++--
 hw/block/nvme.c       | 193 +++++++++++++++++++++++++++++++++++++++++-
 hw/block/trace-events |   4 +
 6 files changed, 240 insertions(+), 9 deletions(-)

-- 
2.29.1

Comments

Klaus Jensen Oct. 30, 2020, 6:33 a.m. UTC | #1 
On Oct 27 18:57, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
> 
> This adds support for the Deallocated or Unwritten Logical Block error
> recovery feature as well as the Dataset Management command.
> 
> v7:
>   - Handle negative return value from bdrv_block_status.
>   - bdrv_get_info may not be supported on all block drivers, so do not
>     consider it a fatal error.
> 
> v6:
>   - Skip the allocation of the discards integer and just use the opaque
>     value directly (Philippe)
>   - Split changes to include/block/nvme.h into a separate patch
>     (Philippe)
>   - Clean up some convoluted checks on the discards value (Philippe)
>   - Use unambiguous units in the commit messages (Philippe)
>   - Stack allocate the range array (Keith)
> 
> v5:
>   - Restore status code from callback (Keith)
> 
> v4:
>   - Removed mixed declaration and code (Keith)
>   - Set NPDG and NPDA and account for the blockdev cluster size.
> 
> Klaus Jensen (3):
>   hw/block/nvme: add dulbe support
>   nvme: add namespace I/O optimization fields to shared header
>   hw/block/nvme: add the dataset management command
> 
>  hw/block/nvme-ns.h    |   4 +
>  hw/block/nvme.h       |   2 +
>  include/block/nvme.h  |  12 ++-
>  hw/block/nvme-ns.c    |  34 ++++++--
>  hw/block/nvme.c       | 193 +++++++++++++++++++++++++++++++++++++++++-
>  hw/block/trace-events |   4 +
>  6 files changed, 240 insertions(+), 9 deletions(-)
> 
> -- 
> 2.29.1
> 

Keith, I cleared your R-b's from both patch 1 and 3 - please re-review.
The diff from v6 is very small, but it does include functional changes.