mbox series

[0/4] qga: Fix several guest-get-devices issues

Message ID 20201021071520.2168877-1-armbru@redhat.com
Headers show
Series qga: Fix several guest-get-devices issues | expand

Message

Markus Armbruster Oct. 21, 2020, 7:15 a.m. UTC 
To be frank, I'm disappointed the code passed review in this state.
There are excuses for each of the issues addressed in this series
(PATCH 1 naming is hard, PATCH 2 recognizing non-local relations is
hard, PATCH 3 mistakes on error paths are easy to miss, PATCH 4 can't
expect all reviewers to know "no more simple unions, please").  Still,
having so many of them escape notice is disappointing.

Please review.

Markus Armbruster (4):
  qga: Rename guest-get-devices return member 'address' to 'id'
  qga: Use common time encoding for guest-get-devices 'driver-date'
  qga-win: Fix guest-get-devices error API violations
  qga: Flatten simple union GuestDeviceId

 qga/qapi-schema.json | 29 +++++++++++++++++++----------
 qga/commands-win32.c | 39 ++++++++++++++++++++-------------------
 2 files changed, 39 insertions(+), 29 deletions(-)

Comments

Markus Armbruster Oct. 27, 2020, 6:35 a.m. UTC | #1 
Mike,

This series addresses interface defects, and must go into 5.2.  It's
fully reviewed.  Pull request in time for soft freeze would be ideal.
If you can't make it, feel free to ask me.  I'll continue to push for
the series even if it misses the soft freeze.