| Message ID | 20201015194647.477252-1-f4bug@amsat.org |
|---|---|
| Headers | show |
| Series | hw/rtc/m48t59: Simplify m48t59_init() | expand |
On 15/10/2020 20:46, Philippe Mathieu-Daudé wrote: > Since v1: > - Do not remove mem_base in patch 1 (Laurent) > - Pass MemoryRegion* (new patch) > - Run check-qtest > > Philippe Mathieu-Daudé (2): > hw/rtc/m48t59: Simplify m48t59_init() removing 'io_base' argument > hw/rtc/m48t59: Simplify m48t59_init() passing MemoryRegion argument > > include/hw/rtc/m48t59.h | 5 ++--- > hw/ppc/ppc405_boards.c | 2 +- > hw/rtc/m48t59.c | 14 +++----------- > hw/sparc/sun4m.c | 3 ++- > hw/sparc64/sun4u.c | 7 ++----- > 5 files changed, 10 insertions(+), 21 deletions(-) This looks good, and from what you've done here it's only a little more work to remove m48t59_init() completely. Would you mind if I try this using these patches as a starting point? :) ATB, Mark.
Le ven. 16 oct. 2020 11:39, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> a écrit : > On 15/10/2020 20:46, Philippe Mathieu-Daudé wrote: > > > Since v1: > > - Do not remove mem_base in patch 1 (Laurent) > > - Pass MemoryRegion* (new patch) > > - Run check-qtest > > > > Philippe Mathieu-Daudé (2): > > hw/rtc/m48t59: Simplify m48t59_init() removing 'io_base' argument > > hw/rtc/m48t59: Simplify m48t59_init() passing MemoryRegion argument > > > > include/hw/rtc/m48t59.h | 5 ++--- > > hw/ppc/ppc405_boards.c | 2 +- > > hw/rtc/m48t59.c | 14 +++----------- > > hw/sparc/sun4m.c | 3 ++- > > hw/sparc64/sun4u.c | 7 ++----- > > 5 files changed, 10 insertions(+), 21 deletions(-) > > This looks good, and from what you've done here it's only a little more > work to > remove m48t59_init() completely. Would you mind if I try this using these > patches as > a starting point? :) > I had a look at your previous suggestion, but I have too many in flight series waiting for 5.2, so sure go ahead! > > ATB, > > Mark. > > <div dir="auto"><div><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Le ven. 16 oct. 2020 11:39, Mark Cave-Ayland <<a href="mailto:mark.cave-ayland@ilande.co.uk">mark.cave-ayland@ilande.co.uk</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 15/10/2020 20:46, Philippe Mathieu-Daudé wrote:<br> <br> > Since v1:<br> > - Do not remove mem_base in patch 1 (Laurent)<br> > - Pass MemoryRegion* (new patch)<br> > - Run check-qtest<br> > <br> > Philippe Mathieu-Daudé (2):<br> > hw/rtc/m48t59: Simplify m48t59_init() removing 'io_base' argument<br> > hw/rtc/m48t59: Simplify m48t59_init() passing MemoryRegion argument<br> > <br> > include/hw/rtc/m48t59.h | 5 ++---<br> > hw/ppc/ppc405_boards.c | 2 +-<br> > hw/rtc/m48t59.c | 14 +++-----------<br> > hw/sparc/sun4m.c | 3 ++-<br> > hw/sparc64/sun4u.c | 7 ++-----<br> > 5 files changed, 10 insertions(+), 21 deletions(-)<br> <br> This looks good, and from what you've done here it's only a little more work to <br> remove m48t59_init() completely. Would you mind if I try this using these patches as <br> a starting point? :)<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">I had a look at your previous suggestion, but I have too many in flight series waiting for 5.2, so sure go ahead! </div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br> <br> ATB,<br> <br> Mark.<br> <br> </blockquote></div></div></div>