From patchwork Tue Oct 13 14:38:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudio Fontana X-Patchwork-Id: 302951 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC9D0C43467 for ; Tue, 13 Oct 2020 14:39:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E0ED24863 for ; Tue, 13 Oct 2020 14:39:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E0ED24863 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46982 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSLSp-0006iv-UO for qemu-devel@archiver.kernel.org; Tue, 13 Oct 2020 10:39:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39104) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSLRS-0005MT-55 for qemu-devel@nongnu.org; Tue, 13 Oct 2020 10:38:18 -0400 Received: from mx2.suse.de ([195.135.220.15]:33134) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSLRK-0002qs-Id for qemu-devel@nongnu.org; Tue, 13 Oct 2020 10:38:17 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DEE8BB184; Tue, 13 Oct 2020 14:38:08 +0000 (UTC) From: Claudio Fontana To: Paolo Bonzini Subject: [PATCH v3 0/3] unbreak non-tcg builds Date: Tue, 13 Oct 2020 16:38:03 +0200 Message-Id: <20201013143806.14321-1-cfontana@suse.de> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/12 01:21:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org, Pavel Dovgalyuk , Claudio Fontana , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?b?w6k=?= , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This series now unbreaks current non-tcg builds (!CONFIG_TCG). tests Makefiles need to avoid relying on all non-native archs binaries to be present, bios-tables-test needs to skip tests that are tcg-only, and notably the replay framework needs to consider that it might not be functional (or its code present at all) without TCG. Tested ok target x86_64-softmmu on x86_64 host with: ./configure --enable-tcg --disable-kvm ./configure --enable-kvm --disable-tcg ./configure --enable-tcg --enable-kvm running make check-qtest v2 => v3: * do not alter the replay api, provide a block wrapper instead to call into replay events handling or the normal call flow depending on whether replay events are enabled. v1: initial RFC Claudio Fontana (2): qtest: unbreak non-TCG builds in bios-tables-test replay: do not build if TCG is not available Paolo Bonzini (1): tests/Makefile.include: unbreak non-tcg builds block/block-backend.c | 9 ++-- block/io.c | 52 ++++++++++++------ block/iscsi.c | 5 +- block/meson.build | 3 +- block/nfs.c | 6 +-- block/null.c | 4 +- block/nvme.c | 6 +-- block/rbd.c | 5 +- hw/ide/core.c | 8 +-- hw/ide/ioport.c | 1 - include/block/block.h | 29 ++++++++++ migration/savevm.c | 11 ++-- net/meson.build | 3 +- replay/meson.build | 2 +- replay/replay-events.c | 20 +++---- replay/replay-input.c | 4 +- stubs/meson.build | 1 - stubs/replay-user.c | 9 ---- stubs/replay.c | 96 ++++++++++++++++++++++++++++++++++ tests/Makefile.include | 2 +- tests/ptimer-test-stubs.c | 5 -- tests/qtest/bios-tables-test.c | 10 ++++ tests/qtest/qmp-cmd-test.c | 3 ++ ui/input.c | 12 ++++- 24 files changed, 223 insertions(+), 83 deletions(-) delete mode 100644 stubs/replay-user.c