mbox series

[v2,0/3] unbreak non-tcg builds

Message ID 20201012214527.1780-1-cfontana@suse.de
Headers show
Series unbreak non-tcg builds | expand

Message

Claudio Fontana Oct. 12, 2020, 9:45 p.m. UTC 
This series now unbreaks current non-tcg builds
(!CONFIG_TCG).

tests Makefiles need to avoid relying on all non-native
archs binaries to be present,

bios-tables-test needs to skip tests that are tcg-only,

and notably the replay framework needs to consider that
it might not be functional (or its code present at all)
without TCG.

Tested ok target x86_64-softmmu on x86_64 host with:

./configure --enable-tcg --disable-kvm
./configure --enable-kvm --disable-tcg
./configure --enable-tcg --enable-kvm

running make check-qtest

Claudio Fontana (2):
  qtest: unbreak non-TCG builds in bios-tables-test
  replay: do not build if TCG is not available

Paolo Bonzini (1):
  tests/Makefile.include: unbreak non-tcg builds

 block/block-backend.c          |  17 ++++--
 block/io.c                     |  38 ++++++------
 block/iscsi.c                  |   9 ++-
 block/meson.build              |   3 +-
 block/nfs.c                    |  10 +++-
 block/null.c                   |   8 ++-
 block/nvme.c                   |  13 +++-
 block/rbd.c                    |   8 ++-
 hw/ide/core.c                  |  14 ++++-
 include/sysemu/replay.h        |   8 +--
 migration/savevm.c             |  11 ++--
 net/meson.build                |   3 +-
 replay/meson.build             |   2 +-
 replay/replay-events.c         |  20 +++++--
 replay/replay-input.c          |  20 +++++--
 stubs/meson.build              |   1 -
 stubs/replay-user.c            |   9 ---
 stubs/replay.c                 | 106 +++++++++++++++++++++++++++++++++
 tests/Makefile.include         |   2 +-
 tests/ptimer-test-stubs.c      |   5 --
 tests/qtest/bios-tables-test.c |  10 ++++
 tests/qtest/qmp-cmd-test.c     |   3 +
 ui/input.c                     |  10 +++-
 23 files changed, 256 insertions(+), 74 deletions(-)
 delete mode 100644 stubs/replay-user.c

Comments

Philippe Mathieu-Daudé Oct. 13, 2020, 8:25 a.m. UTC | #1 
On 10/12/20 11:45 PM, Claudio Fontana wrote:
> This series now unbreaks current non-tcg builds

> (!CONFIG_TCG).

> 

> tests Makefiles need to avoid relying on all non-native

> archs binaries to be present,

> 

> bios-tables-test needs to skip tests that are tcg-only,

> 

> and notably the replay framework needs to consider that

> it might not be functional (or its code present at all)

> without TCG.

> 

> Tested ok target x86_64-softmmu on x86_64 host with:

> 

> ./configure --enable-tcg --disable-kvm

> ./configure --enable-kvm --disable-tcg

> ./configure --enable-tcg --enable-kvm

> 

> running make check-qtest


If you want to avoid these configurations to bitrot,
please cover them adding Gitlab jobs.

Thanks,

Phil.
Claudio Fontana Oct. 13, 2020, 8:28 a.m. UTC | #2 
On 10/13/20 10:25 AM, Philippe Mathieu-Daudé wrote:
> On 10/12/20 11:45 PM, Claudio Fontana wrote:

>> This series now unbreaks current non-tcg builds

>> (!CONFIG_TCG).

>>

>> tests Makefiles need to avoid relying on all non-native

>> archs binaries to be present,

>>

>> bios-tables-test needs to skip tests that are tcg-only,

>>

>> and notably the replay framework needs to consider that

>> it might not be functional (or its code present at all)

>> without TCG.

>>

>> Tested ok target x86_64-softmmu on x86_64 host with:

>>

>> ./configure --enable-tcg --disable-kvm

>> ./configure --enable-kvm --disable-tcg

>> ./configure --enable-tcg --enable-kvm

>>

>> running make check-qtest

> 

> If you want to avoid these configurations to bitrot,

> please cover them adding Gitlab jobs.

> 

> Thanks,

> 

> Phil.

> 


Hi, yes I was about to ask :-) We have only minimal coverage of --disable-tcg and only for s390 IIRC.

Ciao,

Claudio
Philippe Mathieu-Daudé Oct. 13, 2020, 8:50 a.m. UTC | #3 
On 10/13/20 10:28 AM, Claudio Fontana wrote:
> On 10/13/20 10:25 AM, Philippe Mathieu-Daudé wrote:

>> On 10/12/20 11:45 PM, Claudio Fontana wrote:

>>> This series now unbreaks current non-tcg builds

>>> (!CONFIG_TCG).

>>>

>>> tests Makefiles need to avoid relying on all non-native

>>> archs binaries to be present,

>>>

>>> bios-tables-test needs to skip tests that are tcg-only,

>>>

>>> and notably the replay framework needs to consider that

>>> it might not be functional (or its code present at all)

>>> without TCG.

>>>

>>> Tested ok target x86_64-softmmu on x86_64 host with:

>>>

>>> ./configure --enable-tcg --disable-kvm

>>> ./configure --enable-kvm --disable-tcg

>>> ./configure --enable-tcg --enable-kvm

>>>

>>> running make check-qtest

>>

>> If you want to avoid these configurations to bitrot,

>> please cover them adding Gitlab jobs.

>>

>> Thanks,

>>

>> Phil.

>>

> 

> Hi, yes I was about to ask :-) We have only minimal coverage of --disable-tcg and only for s390 IIRC.


Aarch64 is on his way:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg746053.html

> 

> Ciao,

> 

> Claudio

>