Message ID | 20201012203343.1105018-1-pbonzini@redhat.com |
---|---|
Headers | show |
Series | SCSI, qdev, qtest, meson patches for 2020-10-10 | expand |
Patchew URL: https://patchew.org/QEMU/20201012203343.1105018-1-pbonzini@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201012203343.1105018-1-pbonzini@redhat.com Subject: [PULL v2 00/38] SCSI, qdev, qtest, meson patches for 2020-10-10 === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20201012150356.79670-1-mcascell@redhat.com -> patchew/20201012150356.79670-1-mcascell@redhat.com - [tag update] patchew/20201012200725.64137-1-jandryuk@gmail.com -> patchew/20201012200725.64137-1-jandryuk@gmail.com * [new tag] patchew/20201012203343.1105018-1-pbonzini@redhat.com -> patchew/20201012203343.1105018-1-pbonzini@redhat.com Switched to a new branch 'test' e095da7 meson: identify more sections of meson.build cde63b2 scsi/scsi_bus: fix races in REPORT LUNS d2bb341 virtio-scsi: use scsi_device_get 4867d5d scsi/scsi_bus: Add scsi_device_get 1ee7caf scsi/scsi-bus: scsi_device_find: don't return unrealized devices dbbd9c7 device-core: use atomic_set on .realized property 266ed6b scsi: switch to bus->check_address 5e59a58 device-core: use RCU for list of children of a bus 1a2ccc7 device_core: use drain_call_rcu in in qmp_device_add a001ce1 scsi/scsi_bus: switch search direction in scsi_device_find 424e675 qdev: add "check if address free" callback for buses e1d9b34 qemu-iotests, qtest: rewrite test 067 as a qtest 75778e4 qtest: check that drives are really appearing and disappearing 1a4bbd0 qtest: switch users back to qtest_qmp_receive 9fdab1f device-plug-test: use qtest_qmp to send the device_del command f719f91 qtest: remove qtest_qmp_receive_success 97130a3 qtest: Reintroduce qtest_qmp_receive with QMP event buffering 166cf20 qtest: rename qtest_qmp_receive to qtest_qmp_receive_dict d137139 meson.build: Re-enable KVM support for MIPS fb14255 build-sys: fix git version from -version 7f7c035 docs/devel: update instruction on how to add new unit tests 2b71900 qtest: unify extra_qtest_srcs and extra_qtest_deps 215c4f1 docs/devel/qtest: Include libqtest API reference 4aec087 docs/devel/qtest: Include protocol spec in document a6c15d8 docs: Move QTest documentation to its own document f005a8c qom: fix objects with improper parent type cf02881 exec: split out non-softmmu-specific parts 0677165 softmmu: move more files to softmmu/ b2c601b hw/nvram: Always register FW_CFG_DATA_GENERATOR_INTERFACE 9aaab06 qom: Move the creation of the library to the main meson.build 8f82ff4 authz: Move the creation of the library to the main meson.build 4508951 crypto: Move the creation of the library to the main meson.build e97817f io: Move the creation of the library to the main meson.build da7c561 migration: Move the creation of the library to the main meson.build d417a02 chardev: Move the creation of the library to the main meson.build fbb89fc hw/core: Move the creation of the library to the main meson.build f2a20f9 meson.build: Sort sourcesets alphabetically c99c5bf meson.build: Add comments to clarify code organization === OUTPUT BEGIN === 1/38 Checking commit c99c5bf88fad (meson.build: Add comments to clarify code organization) 2/38 Checking commit f2a20f9b9f6e (meson.build: Sort sourcesets alphabetically) 3/38 Checking commit fbb89fc057ec (hw/core: Move the creation of the library to the main meson.build) 4/38 Checking commit d417a024b953 (chardev: Move the creation of the library to the main meson.build) 5/38 Checking commit da7c561d7c91 (migration: Move the creation of the library to the main meson.build) 6/38 Checking commit e97817f4d4cd (io: Move the creation of the library to the main meson.build) 7/38 Checking commit 4508951b37e9 (crypto: Move the creation of the library to the main meson.build) 8/38 Checking commit 8f82ff45fa37 (authz: Move the creation of the library to the main meson.build) 9/38 Checking commit 9aaab065cdf7 (qom: Move the creation of the library to the main meson.build) 10/38 Checking commit b2c601bfba37 (hw/nvram: Always register FW_CFG_DATA_GENERATOR_INTERFACE) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #52: new file mode 100644 total: 0 errors, 1 warnings, 55 lines checked Patch 10/38 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/38 Checking commit 0677165b3eea (softmmu: move more files to softmmu/) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #85: rename from bootdevice.c total: 0 errors, 1 warnings, 69 lines checked Patch 11/38 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/38 Checking commit cf028814349c (exec: split out non-softmmu-specific parts) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #52: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #104: FILE: cpu.c:48: + /* 0x01 was CPU_INTERRUPT_EXIT. This line can be removed when the WARNING: Block comments use * on subsequent lines #105: FILE: cpu.c:49: + /* 0x01 was CPU_INTERRUPT_EXIT. This line can be removed when the + version_id is increased. */ WARNING: Block comments use a trailing */ on a separate line #105: FILE: cpu.c:49: + version_id is increased. */ WARNING: Block comments use a leading /* on a separate line #109: FILE: cpu.c:53: + /* loadvm has just updated the content of RAM, bypassing the ERROR: spaces required around that '*' (ctx:VxV) #175: FILE: cpu.c:119: + .subsections = (const VMStateDescription*[]) { ^ WARNING: Block comments use a leading /* on a separate line #205: FILE: cpu.c:149: + /* Create a memory property for softmmu CPU object, WARNING: Block comments use a leading /* on a separate line #393: FILE: cpu.c:337: +/* enable or disable single step mode. EXCP_DEBUG is returned by the WARNING: Block comments use * on subsequent lines #394: FILE: cpu.c:338: +/* enable or disable single step mode. EXCP_DEBUG is returned by the + CPU loop after each instruction */ WARNING: Block comments use a trailing */ on a separate line #394: FILE: cpu.c:338: + CPU loop after each instruction */ ERROR: "foo * bar" should be "foo *bar" #452: FILE: cpu.c:396: + void * p; ERROR: braces {} are necessary for all arms of this statement #458: FILE: cpu.c:402: + if (l > len) [...] ERROR: braces {} are necessary for all arms of this statement #461: FILE: cpu.c:405: + if (!(flags & PAGE_VALID)) [...] ERROR: braces {} are necessary for all arms of this statement #464: FILE: cpu.c:408: + if (!(flags & PAGE_WRITE)) [...] ERROR: do not use assignment in if condition #467: FILE: cpu.c:411: + if (!(p = lock_user(VERIFY_WRITE, addr, l, 0))) ERROR: braces {} are necessary for all arms of this statement #467: FILE: cpu.c:411: + if (!(p = lock_user(VERIFY_WRITE, addr, l, 0))) [...] ERROR: braces {} are necessary for all arms of this statement #472: FILE: cpu.c:416: + if (!(flags & PAGE_READ)) [...] ERROR: do not use assignment in if condition #475: FILE: cpu.c:419: + if (!(p = lock_user(VERIFY_READ, addr, l, 1))) ERROR: braces {} are necessary for all arms of this statement #475: FILE: cpu.c:419: + if (!(p = lock_user(VERIFY_READ, addr, l, 1))) [...] WARNING: Block comments use a leading /* on a separate line #499: FILE: cpu.c:443: + /* NOTE: we can always suppose that qemu_host_page_size >= WARNING: Block comments use * on subsequent lines #500: FILE: cpu.c:444: + /* NOTE: we can always suppose that qemu_host_page_size >= + TARGET_PAGE_SIZE */ WARNING: Block comments use a trailing */ on a separate line #500: FILE: cpu.c:444: + TARGET_PAGE_SIZE */ total: 10 errors, 12 warnings, 1061 lines checked Patch 12/38 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/38 Checking commit f005a8cfb19a (qom: fix objects with improper parent type) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #69: new file mode 100644 total: 0 errors, 1 warnings, 57 lines checked Patch 13/38 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/38 Checking commit a6c15d8d8a01 (docs: Move QTest documentation to its own document) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 total: 0 errors, 1 warnings, 124 lines checked Patch 14/38 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/38 Checking commit 4aec087681f4 (docs/devel/qtest: Include protocol spec in document) 16/38 Checking commit 215c4f129955 (docs/devel/qtest: Include libqtest API reference) 17/38 Checking commit 2b7190029b86 (qtest: unify extra_qtest_srcs and extra_qtest_deps) 18/38 Checking commit 7f7c0357260c (docs/devel: update instruction on how to add new unit tests) 19/38 Checking commit fb14255c91ec (build-sys: fix git version from -version) 20/38 Checking commit d137139bc66e (meson.build: Re-enable KVM support for MIPS) 21/38 Checking commit 166cf20a57dc (qtest: rename qtest_qmp_receive to qtest_qmp_receive_dict) 22/38 Checking commit 97130a3405fb (qtest: Reintroduce qtest_qmp_receive with QMP event buffering) 23/38 Checking commit f719f91c233f (qtest: remove qtest_qmp_receive_success) 24/38 Checking commit 9fdab1f51d7d (device-plug-test: use qtest_qmp to send the device_del command) WARNING: line over 80 characters #33: FILE: tests/qtest/device-plug-test.c:23: + "{'execute': 'device_del', 'arguments': { 'id': %s } }", id); total: 0 errors, 1 warnings, 76 lines checked Patch 24/38 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 25/38 Checking commit 1a4bbd042bfb (qtest: switch users back to qtest_qmp_receive) 26/38 Checking commit 75778e4772dc (qtest: check that drives are really appearing and disappearing) 27/38 Checking commit e1d9b343e2b2 (qemu-iotests, qtest: rewrite test 067 as a qtest) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #46: deleted file mode 100755 WARNING: line over 80 characters #650: FILE: tests/qtest/drive_del-test.c:19: +static bool look_for_drive0(QTestState *qts, const char *command, const char *key) total: 0 errors, 2 warnings, 309 lines checked Patch 27/38 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 28/38 Checking commit 424e675dda68 (qdev: add "check if address free" callback for buses) 29/38 Checking commit a001ce1554a7 (scsi/scsi_bus: switch search direction in scsi_device_find) 30/38 Checking commit 1a2ccc728392 (device_core: use drain_call_rcu in in qmp_device_add) 31/38 Checking commit 5e59a588de67 (device-core: use RCU for list of children of a bus) 32/38 Checking commit 266ed6bf0dd5 (scsi: switch to bus->check_address) ERROR: code indent should never use tabs #55: FILE: hw/scsi/scsi-bus.c:137: +^I^I^I^I int channel, int target, int lun,$ ERROR: code indent should never use tabs #56: FILE: hw/scsi/scsi-bus.c:138: +^I^I^I^I SCSIDevice **p_dev)$ WARNING: line over 80 characters #71: FILE: hw/scsi/scsi-bus.c:153: +static bool scsi_bus_check_address(BusState *qbus, DeviceState *qdev, Error **errp) WARNING: line over 80 characters #91: FILE: hw/scsi/scsi-bus.c:173: + if (!scsi_bus_is_address_free(bus, dev->channel, dev->id, dev->lun, &d)) { WARNING: line over 80 characters #130: FILE: hw/scsi/scsi-bus.c:195: + is_free = scsi_bus_is_address_free(bus, dev->channel, ++id, dev->lun, NULL); WARNING: line over 80 characters #143: FILE: hw/scsi/scsi-bus.c:205: + is_free = scsi_bus_is_address_free(bus, dev->channel, dev->id, ++lun, NULL); total: 2 errors, 4 warnings, 182 lines checked Patch 32/38 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/38 Checking commit dbbd9c7ce2fb (device-core: use atomic_set on .realized property) 34/38 Checking commit 1ee7caff2baa (scsi/scsi-bus: scsi_device_find: don't return unrealized devices) 35/38 Checking commit 4867d5dd8c85 (scsi/scsi_bus: Add scsi_device_get) 36/38 Checking commit d2bb341ac299 (virtio-scsi: use scsi_device_get) 37/38 Checking commit cde63b207e2b (scsi/scsi_bus: fix races in REPORT LUNS) 38/38 Checking commit e095da701611 (meson: identify more sections of meson.build) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20201012203343.1105018-1-pbonzini@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On Mon, 12 Oct 2020 at 21:36, Paolo Bonzini <pbonzini@redhat.com> wrote: > > The following changes since commit a0bdf866873467271eff9a92f179ab0f77d735cb: > > Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20201012a' into staging (2020-10-12 13:12:04 +0100) > > are available in the Git repository at: > > https://gitlab.com/bonzini/qemu.git tags/for-upstream > > for you to fetch changes up to a0c9162c8250e121af438aee5ef93e64ec62dae1: > > meson: identify more sections of meson.build (2020-10-12 11:50:52 -0400) > > ---------------------------------------------------------------- > * qtest documentation improvements (Eduardo, myself) > * libqtest event buffering (Maxim) > * use RCU for list of children of a bus (Maxim) > * move more files to softmmu/ (myself) > * meson.build cleanups, qemu-storage-daemon fix (Philippe) > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.2 for any user-visible changes. -- PMM