From patchwork Sat Oct 10 20:41:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Patchwork-Id: 271591 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 123B7C433DF for ; Sat, 10 Oct 2020 20:44:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4308B207C4 for ; Sat, 10 Oct 2020 20:44:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UYXBe3DS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4308B207C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34620 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kRLjW-0000vz-Of for qemu-devel@archiver.kernel.org; Sat, 10 Oct 2020 16:44:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51526) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kRLgE-0006pm-RM for qemu-devel@nongnu.org; Sat, 10 Oct 2020 16:41:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:31339) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kRLgB-000750-Sy for qemu-devel@nongnu.org; Sat, 10 Oct 2020 16:41:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602362482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3UCYv0FVNWsyZHc4ICsi3ke9X+MJ+ZKH7qO99s/UI+w=; b=UYXBe3DSqo/9Y2XX92LsnQKSs4oPMGoQ8eEtkKvu785shyYaTcDRpGwcWH0bo6cpM8U0gB /bduKfOD1zHjzh4LwiA4RLy4PGRFQLn8kfAthtCOVAA8h3xy3njpyWh9t8NvcDeakTzwlv 8X1lDeCD+LDAj70l9+egndWq1vOp4vU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-520-lRqmJ6e_OIiEQTFZ7BFIrg-1; Sat, 10 Oct 2020 16:41:20 -0400 X-MC-Unique: lRqmJ6e_OIiEQTFZ7BFIrg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 85441100746A for ; Sat, 10 Oct 2020 20:41:19 +0000 (UTC) Received: from localhost (unknown [10.36.110.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id CB2F876665; Sat, 10 Oct 2020 20:41:09 +0000 (UTC) From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Subject: [PATCH 0/3] console: make QMP screendump use coroutine Date: Sun, 11 Oct 2020 00:41:03 +0400 Message-Id: <20201010204106.1368710-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=63.128.21.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/10 16:30:21 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Markus Armbruster , "Dr. David Alan Gilbert" , Gerd Hoffmann , Stefan Hajnoczi , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Marc-André Lureau Hi, Thanks to recent work by Kevin, it becomes possible to run HMP/QMP commands i= n a coroutine. The screendump command is a good target, as it requires to re-enter the main-loop in ordre to flush the display, and write to file in a non-block= ing way. Despite the flush, the dump may still have glitches. The graphic device may perform some operations during the write on the same framebuffer. Doing a mem= ory copy could help, but it would also create a number of other issues. Keeping t= he BQL would defeat a number of advantages of using a coroutine. Afaik, there is= no mechanism to "freeze" the device either (and this could also have bad consequences anyway). Good enough? Marc-Andr=C3=A9 Lureau (3): coroutine: let CoQueue wake up outside a coroutine console: modify ppm_save to take a pixman image ref console: make QMP/HMP screendump run in coroutine hmp-commands.hx | 1 + monitor/hmp-cmds.c | 3 ++- qapi/ui.json | 3 ++- ui/console.c | 42 +++++++++++++++++++++++++++++--------- ui/trace-events | 2 +- util/qemu-coroutine-lock.c | 6 ++---- 6 files changed, 40 insertions(+), 17 deletions(-) --=20 2.28.0 Reviewed-by: Gerd Hoffmann Reviewed-by: Markus Armbruster