mbox series

[v2,0/9] meson: Move the creation of the library to the main meson.build

Message ID 20201006125602.2311423-1-philmd@redhat.com
Headers show
Series meson: Move the creation of the library to the main meson.build | expand

Message

Philippe Mathieu-Daudé Oct. 6, 2020, 12:55 p.m. UTC
Make Meson machinery more consistent, as requested by Paolo.

Since v1: addressed Paolo's review comments
- Drop migration RFC patch
- Move comment block

Series coded while listening to Brass Against songs:

  https://www.youtube.com/channel/UClJMqrWQJ8OYWJ4ZdfqZdeQ

and available in the Git repository at:

  https://gitlab.com/philmd/qemu.git branches/meson_libraries_consistency

Philippe Mathieu-Daudé (9):
  meson.build: Add comments to clarify code organization
  meson.build: Sort sourcesets alphabetically
  hw/core: Move the creation of the library to the main meson.build
  chardev: Move the creation of the library to the main meson.build
  migration: Move the creation of the library to the main meson.build
  io: Move the creation of the library to the main meson.build
  crypto: Move the creation of the library to the main meson.build
  authz: Move the creation of the library to the main meson.build
  qom: Move the creation of the library to the main meson.build

 meson.build           | 86 ++++++++++++++++++++++++++++++++++++++-----
 authz/meson.build     | 10 -----
 chardev/meson.build   |  6 ---
 crypto/meson.build    | 10 -----
 hw/core/meson.build   |  6 ---
 io/meson.build        | 10 -----
 migration/meson.build |  8 +---
 qom/meson.build       |  8 ----
 8 files changed, 77 insertions(+), 67 deletions(-)

Comments

no-reply@patchew.org Oct. 6, 2020, 1 p.m. UTC | #1
Patchew URL: https://patchew.org/QEMU/20201006125602.2311423-1-philmd@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

N/A. Internal error while reading log file



The full log is available at
http://patchew.org/logs/20201006125602.2311423-1-philmd@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Philippe Mathieu-Daudé Oct. 6, 2020, 1:04 p.m. UTC | #2
On 10/6/20 3:00 PM, no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20201006125602.2311423-1-philmd@redhat.com/

> 

> Hi,

> 

> This series seems to have some coding style problems. See output below for

> more information:

> 

> N/A. Internal error while reading log file


¯\_(ツ)_/¯
Paolo Bonzini Oct. 6, 2020, 1:09 p.m. UTC | #3
On 06/10/20 14:55, Philippe Mathieu-Daudé wrote:
> Make Meson machinery more consistent, as requested by Paolo.

> 

> Since v1: addressed Paolo's review comments

> - Drop migration RFC patch

> - Move comment block

> 

> Series coded while listening to Brass Against songs:

> 

>   https://www.youtube.com/channel/UClJMqrWQJ8OYWJ4ZdfqZdeQ

> 

> and available in the Git repository at:

> 

>   https://gitlab.com/philmd/qemu.git branches/meson_libraries_consistency

> 

> Philippe Mathieu-Daudé (9):

>   meson.build: Add comments to clarify code organization

>   meson.build: Sort sourcesets alphabetically

>   hw/core: Move the creation of the library to the main meson.build

>   chardev: Move the creation of the library to the main meson.build

>   migration: Move the creation of the library to the main meson.build

>   io: Move the creation of the library to the main meson.build

>   crypto: Move the creation of the library to the main meson.build

>   authz: Move the creation of the library to the main meson.build

>   qom: Move the creation of the library to the main meson.build

> 

>  meson.build           | 86 ++++++++++++++++++++++++++++++++++++++-----

>  authz/meson.build     | 10 -----

>  chardev/meson.build   |  6 ---

>  crypto/meson.build    | 10 -----

>  hw/core/meson.build   |  6 ---

>  io/meson.build        | 10 -----

>  migration/meson.build |  8 +---

>  qom/meson.build       |  8 ----

>  8 files changed, 77 insertions(+), 67 deletions(-)

> 


Queued, thanks.

Paolo