| Message ID | 20200922211313.4082880-1-jsnow@redhat.com |
|---|---|
| Headers | show |
| Series | qapi: static typing conversion, pt2 | expand |
On 9/22/20 5:12 PM, John Snow wrote: > based-on: <20200922210101.4081073-1-jsnow@redhat.com> > [PATCH v2 00/38] qapi: static typing conversion, pt1 > > Hi, this series adds static type hints to the QAPI module. > This is part two! > > Part 2: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt2 > Everything: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt6 > Thanks for reviews. I will not be re-spinning pt2 until pt1 is fully merged, but I have re-based on pt1-v3 and made some minor adjustments to accommodate new development in pt1. You can find that staged here: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt2 Here's the review status of pt2: [01] qapi-expr-py-remove-info # [SOB] JS [RB] CR,EH [02] qapi-expr-py-check-for-dict # [SOB] JS [RB] CR,EH [03] qapi-expr-py-constrain # [SOB] JS [RB] CR,EH [04] qapi-expr-py-add-assertion-for # [SOB] JS [RB] CR,EH [05] qapi-expr-py-move-string-check # [SOB] JS [RB] CR,EH [06] qapi-expr-py-check-type-of # [SOB] JS [RB] EH [07] qapi-expr-py-add-casts-in-a # [SOB] JS [RB] CR,EH [08] qapi-expr-py-add-notational # [SOB] JS [RB] CR,EH [09] qapi-expr-py-rewrite-check_if # [SOB] JS [RB] CR,EH [TB] CR [10] qapi-expr-py-remove-single # [SOB] JS [RB] CR,EH [11] pylint-enable # [SOB] JS [TB] CR,EH [RB] CR,EH [12] qapi-expr-py-add-docstrings # [SOB] JS [RB] CR [13] qapi-expr-modify-check_keys-to # [SOB] JS [RB] CR,EH [14] qapi-expr-use-tuples-instead # [SOB] JS [RB] CR,EH [15] qapi-expr-move-related-checks # [SOB] JS [RB] CR [16] qapi-expr-use-an-expression # [SOB] JS [RB] CR,EH As for the difflog so far: Patches 2, 3, 7, 8 change import orderings (isort) Patch 12 sees some docstrings rewritten to pass sphinx. Patch 15 addresses Eduardo's review comments. --js
based-on: <20200922210101.4081073-1-jsnow@redhat.com> [PATCH v2 00/38] qapi: static typing conversion, pt1 Hi, this series adds static type hints to the QAPI module. This is part two! Part 2: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt2 Everything: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt6 - Requires Python 3.6+ - Requires mypy 0.770 or newer (for type analysis only) - Requires pylint 2.6.0 or newer (for lint checking only) This part of the series focuses on just expr.py. Type hints are added in patches that add *only* type hints and change no other behavior. Any necessary changes to behavior to accommodate typing are split out into their own tiny patches. Every commit should pass with: - flake8 qapi/ - pylint --rcfile=qapi/pylintrc qapi/ - mypy --config-file=qapi/mypy.ini qapi/ John Snow (16): qapi/expr.py: Remove 'info' argument from nested check_if_str qapi/expr.py: Check for dict instead of OrderedDict qapi/expr.py: constrain incoming expression types qapi/expr.py: Add assertion for union type 'check_dict' qapi/expr.py: move string check upwards in check_type qapi/expr.py: Check type of 'data' member qapi/expr.py: Add casts in a few select cases qapi/expr.py: add type hint annotations qapi/expr.py: rewrite check_if qapi/expr.py: Remove single-letter variable qapi/expr.py: enable pylint checks qapi/expr.py: Add docstrings qapi/expr.py: Modify check_keys to accept any Iterable qapi/expr.py: Use tuples instead of lists for static data qapi/expr.py: move related checks inside check_xxx functions qapi/expr.py: Use an expression checker dispatch table scripts/qapi/expr.py | 440 +++++++++++++++++++++++++++++++----------- scripts/qapi/mypy.ini | 5 - scripts/qapi/pylintrc | 1 - 3 files changed, 327 insertions(+), 119 deletions(-) -- 2.26.2