mbox series

[0/3] configure: add missing CONFIG_FOO variables

Message ID 20200914095231.621068-1-stefanha@redhat.com
Headers show
Series configure: add missing CONFIG_FOO variables | expand

Message

Stefan Hajnoczi Sept. 14, 2020, 9:52 a.m. UTC 
The meson.build feature summary checks the presence of CONFIG_FOO variables.
Several of these variables are never emitted by ./configure so the feature
summary always shows these features as disabled.

Stefan Hajnoczi (3):
  configure: add missing CONFIG_TCMALLOC
  configure: add missing CONFIG_JEMALLOC
  configure: rename QEMU_GA_MSI_ENABLED to CONFIG_QGA_MSI

 configure   | 10 +++++++++-
 Makefile    |  2 +-
 meson.build |  2 +-
 3 files changed, 11 insertions(+), 3 deletions(-)

Comments

Paolo Bonzini Sept. 14, 2020, 10:50 a.m. UTC | #1 
On 14/09/20 11:52, Stefan Hajnoczi wrote:
> The meson.build feature summary checks the presence of CONFIG_FOO variables.
> Several of these variables are never emitted by ./configure so the feature
> summary always shows these features as disabled.
> 
> Stefan Hajnoczi (3):
>   configure: add missing CONFIG_TCMALLOC
>   configure: add missing CONFIG_JEMALLOC
>   configure: rename QEMU_GA_MSI_ENABLED to CONFIG_QGA_MSI
> 
>  configure   | 10 +++++++++-
>  Makefile    |  2 +-
>  meson.build |  2 +-
>  3 files changed, 11 insertions(+), 3 deletions(-)
> 

Thanks!

For 1 and 2 I think it's simpler to move the whole test to Meson.  I
already have a patch for that, though I was going to send it next week.

Paolo
Stefan Hajnoczi Sept. 15, 2020, 10:56 a.m. UTC | #2 
On Mon, Sep 14, 2020 at 12:50:23PM +0200, Paolo Bonzini wrote:
> On 14/09/20 11:52, Stefan Hajnoczi wrote:

> > The meson.build feature summary checks the presence of CONFIG_FOO variables.

> > Several of these variables are never emitted by ./configure so the feature

> > summary always shows these features as disabled.

> > 

> > Stefan Hajnoczi (3):

> >   configure: add missing CONFIG_TCMALLOC

> >   configure: add missing CONFIG_JEMALLOC

> >   configure: rename QEMU_GA_MSI_ENABLED to CONFIG_QGA_MSI

> > 

> >  configure   | 10 +++++++++-

> >  Makefile    |  2 +-

> >  meson.build |  2 +-

> >  3 files changed, 11 insertions(+), 3 deletions(-)

> > 

> 

> Thanks!

> 

> For 1 and 2 I think it's simpler to move the whole test to Meson.  I

> already have a patch for that, though I was going to send it next week.


Great, it's nice to do feature checks in meson instead of ./configure.

Stefan