From patchwork Thu Sep 3 15:22:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= X-Patchwork-Id: 274671 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96A3DC433E9 for ; Thu, 3 Sep 2020 15:23:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B06420786 for ; Thu, 3 Sep 2020 15:23:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QQ31iz4P" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B06420786 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42040 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDr5V-0001WU-8M for qemu-devel@archiver.kernel.org; Thu, 03 Sep 2020 11:23:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49176) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDr4B-00089S-8H for qemu-devel@nongnu.org; Thu, 03 Sep 2020 11:22:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:59646) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kDr47-0007yR-Up for qemu-devel@nongnu.org; Thu, 03 Sep 2020 11:22:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599146538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rgFR/slVNRf9dJyj5eonJUZShFgNWkxmMR7P1e/wpcA=; b=QQ31iz4PnEqg7rrzbhmpmKrNPtmOEM7qHEpK3BxLXfSOcxIQ8+ojktOcJO81cHGvq3C8AF aISfIEYYEll4fqOPauigtV6x95zzzp6WjjvcVkxdCxA/gRW4gDS7TuCVYsxIgMG+U2WYiF CWwq7hymagO55xy989Yzyh2PzstU3YI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-561-2sYt2AO-O6uMwT3yYQGiZg-1; Thu, 03 Sep 2020 11:22:14 -0400 X-MC-Unique: 2sYt2AO-O6uMwT3yYQGiZg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A73A3805EF2; Thu, 3 Sep 2020 15:22:13 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.36.110.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7AA782D07D; Thu, 3 Sep 2020 15:22:11 +0000 (UTC) From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v6 0/8] block: improve error reporting for unsupported O_DIRECT Date: Thu, 3 Sep 2020 16:22:02 +0100 Message-Id: <20200903152210.1917355-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=216.205.24.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/03 01:47:17 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , qemu-block@nongnu.org, Markus Armbruster , Max Reitz , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" v1: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg00269.html v2: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg00589.html v3: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg07098.html v4: https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg05334.html v5: https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg00947.html See patch commit messages for rationale Ideally we would convert other callers of qemu_open_old to use qemu_open, and eventually remove qemu_open_old entirely, so every caller gets use of Error **errp. Improved in v6: - Fix errno regression dup'ing FD - Move qapi header to correct patch - Fix whitespace and commit messages - Converted more use of qemu_open to qemu_open_old after rebase Improved in v5: - Drop reporting of flags in failed open call - Split O_CLOEXEC handling off into separate helper - Refactor monitor FD set APIs to simplify their use Improved in v4: - Use assert() for programmer mistakes - Split second patch into three distinct parts - Misc typos - Improve commit message Improved in v3: - Re-arrange the patches series, so that the conversion to Error takes place first, then the improve O_DIRECT reporting - Rename existing method to qemu_open_old - Use a pair of new methods qemu_open + qemu_create to improve arg checking Improved in v2: - Mention that qemu_open_err is preferred over qemu_open - Get rid of obsolete error_report call - Simplify O_DIRECT handling - Fixup iotests for changed error message text Daniel P. Berrangé (8): monitor: simplify functions for getting a dup'd fdset entry util: split off a helper for dealing with O_CLOEXEC flag util: rename qemu_open() to qemu_open_old() util: refactor qemu_open_old to split off variadic args handling util: add Error object for qemu_open_internal error reporting util: introduce qemu_open and qemu_create with error reporting util: give a specific error message when O_DIRECT doesn't work block/file: switch to use qemu_open/qemu_create for improved errors accel/kvm/kvm-all.c | 2 +- backends/rng-random.c | 2 +- backends/tpm/tpm_passthrough.c | 8 +-- block/file-posix.c | 16 ++--- block/file-win32.c | 5 +- block/vvfat.c | 5 +- chardev/char-fd.c | 2 +- chardev/char-pipe.c | 6 +- chardev/char.c | 2 +- dump/dump.c | 2 +- hw/s390x/s390-skeys.c | 2 +- hw/usb/host-libusb.c | 2 +- hw/usb/u2f-passthru.c | 4 +- hw/vfio/common.c | 4 +- include/monitor/monitor.h | 3 +- include/qemu/osdep.h | 9 ++- io/channel-file.c | 2 +- monitor/misc.c | 58 ++++++++---------- net/vhost-vdpa.c | 2 +- os-posix.c | 2 +- qga/channel-posix.c | 4 +- qga/commands-posix.c | 6 +- stubs/fdset.c | 8 +-- target/arm/kvm.c | 2 +- ui/console.c | 2 +- util/osdep.c | 104 +++++++++++++++++++++++---------- util/oslib-posix.c | 2 +- 27 files changed, 150 insertions(+), 116 deletions(-) -- 2.26.2 Reviewed-by: Richard Henderson Reviewed-by: Richard Henderson Reviewed-by: Richard Henderson Reviewed-by: Richard Henderson Reviewed-by: Markus Armbruster