From patchwork Fri Aug 14 09:23:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 276490 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2974AC433E3 for ; Fri, 14 Aug 2020 10:10:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DE48C2074D for ; Fri, 14 Aug 2020 10:10:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZKClri5d" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE48C2074D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40702 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6Wfe-0004Zn-2G for qemu-devel@archiver.kernel.org; Fri, 14 Aug 2020 06:10:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46712) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6VwH-0005Nr-4o; Fri, 14 Aug 2020 05:23:53 -0400 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:39015) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k6VwF-0004KC-EC; Fri, 14 Aug 2020 05:23:52 -0400 Received: by mail-wr1-x442.google.com with SMTP id a5so7730745wrm.6; Fri, 14 Aug 2020 02:23:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=b3tIdqOLTAFQUjEaio+gozzSgaZAGPhsq/Gr4fWRyyY=; b=ZKClri5dHqE26VrbHCuD7MSkbKm7LjSkUBk/svTUZFF69QmoKe2v9c289w1wU5wuEQ wfIqdL4V3UJqUU9vI7Ic5UNNNzxUL9Klyx4xqoXvWv42rdjfRqEyWEKdxhTPH+UpqQWt X0jbppj3iDy9pnbMwFr8qQPcCH/ngCivOJ/3Egio2PIF8hv9dBQEEz/FmMFIVlt0EnAE 6pvu4wVEVcAoco8t/EhPiQhHnsb9Mrs8vewzRO+ekB9YP6AbUZsyDe6CxjCeNT642iux aVoUg4rEH5GDsqjedTf/8MeQJfyuRRpCJ6kqTwqnS7ElSwy06xn9YTXTtnqS5SjulpHl 0gaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=b3tIdqOLTAFQUjEaio+gozzSgaZAGPhsq/Gr4fWRyyY=; b=kNhutieY5YwoFuhULx0wc4r1CsM12DVI8Mk66LhhgS4OV+bGq4iX2BV+x8VCW4BxfE 42e30pPrNBvP+SQuvNiS/xiKYM2iq7F2gBjTxOuiSAy3/G50FkgZXYnuSiPRwvA7akhb 5n49ILzyCeyyrCR43Ei1yS+alKGgTormFNI9ltuTTrY0SSsTavkyfOCnWpFp3ARmtt+G QZ9knxhwX0XGcsc03Y1PL9GL3dPW5WhJCgvNIK2t0EOiUwMRFsD1nyj1oRpWVAuKJb7S ++5Wt8ifg0YSeiQ8rbbCcpnSzBRbTW6zGkksNxxzwas7UTOAVEVzHpTlTJ8po4m4Z5CQ 9WaA== X-Gm-Message-State: AOAM5322ZNJyzj70PShHEDLCIK4YJ0LU2uohFCCPbWNYHsbWSjYpTNhR RqZz8n6bWmpTLQOG08trdezB7qNZWAs= X-Google-Smtp-Source: ABdhPJzSrk4FUdTFHOYe5gYIiNYcGEHASCMJMBumBfeRuCRfDdu0r5B5tP4wrwHozIsgJL8HLjsHLA== X-Received: by 2002:adf:ee06:: with SMTP id y6mr1877950wrn.225.1597397028624; Fri, 14 Aug 2020 02:23:48 -0700 (PDT) Received: from localhost.localdomain (121.red-81-40-121.staticip.rima-tde.net. [81.40.121.121]) by smtp.gmail.com with ESMTPSA id b11sm12889395wrq.32.2020.08.14.02.23.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2020 02:23:48 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 0/7] hw/sd: Use sdbus_read_data/sdbus_write_data for multiple bytes access Date: Fri, 14 Aug 2020 11:23:39 +0200 Message-Id: <20200814092346.21825-1-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::442; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x442.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-block@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Andrew Baumann , Beniamino Galvani , Michael Walle , qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Introduce sdbus_read_data() and sdbus_write_data() methods to access multiple bytes on the data line of a SD bus. I haven't named then sdbus_access_block() because I expect a block to be a power of 2, while there is no such restriction on the SD bus (think of SPI). We can also simplify the bcm2835_sdhost and pl181 models, but it is simpler to first let them use the Fifo32 API. Based-on: <20200705204630.4133-1-f4bug@amsat.org> "hw/sd: convert legacy SDHCI devices to the SDBus API" https://www.mail-archive.com/qemu-devel@nongnu.org/msg720136.html Philippe Mathieu-Daudé (7): hw/sd: Rename read/write_data() as read/write_byte() hw/sd: Rename sdbus_write_data() as sdbus_write_byte() hw/sd: Rename sdbus_read_data() as sdbus_read_byte() hw/sd: Add sdbus_write_data() to write multiples bytes on the data line hw/sd: Use sdbus_write_data() instead of sdbus_write_byte when possible hw/sd: Add sdbus_read_data() to read multiples bytes on the data line hw/sd: Use sdbus_read_data() instead of sdbus_read_byte() when possible include/hw/sd/sd.h | 56 ++++++++++++++++++++++++++++++++--- include/hw/sd/sdcard_legacy.h | 4 +-- hw/sd/allwinner-sdhost.c | 24 +++++---------- hw/sd/bcm2835_sdhost.c | 4 +-- hw/sd/core.c | 38 +++++++++++++++++++++--- hw/sd/milkymist-memcard.c | 14 ++++----- hw/sd/omap_mmc.c | 8 ++--- hw/sd/pl181.c | 4 +-- hw/sd/pxa2xx_mmci.c | 4 +-- hw/sd/sd.c | 16 +++++----- hw/sd/sdhci.c | 46 ++++++++-------------------- hw/sd/ssi-sd.c | 2 +- 12 files changed, 132 insertions(+), 88 deletions(-)