From patchwork Wed Aug 12 17:19:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 247640 Delivered-To: patch@linaro.org Received: by 2002:a92:cc90:0:0:0:0:0 with SMTP id x16csp551890ilo; Wed, 12 Aug 2020 10:22:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyDKuFSTziQDMQFdPoOa3dzyFN5eieb1CG0TjAOuB2a6D5GMirRXUX0yjgIJFhAT2UnpcE+ X-Received: by 2002:a25:bdc4:: with SMTP id g4mr560348ybk.187.1597252947643; Wed, 12 Aug 2020 10:22:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597252947; cv=none; d=google.com; s=arc-20160816; b=vZyKxoWrfFkauzg+RWF0Syr1pVjdXUU4lMOrtxVCgWcYYATtJGobyvBANAE6cPgVzz moos3fTvBiBYbqE1FSgZP/C4dOTtBs6psc6BQDfIACZpg8coQ2IW627pmKQjfpwztxVj XSDm3Cq7aoCNPwZoG5j57JpktKKzSRZOc6l/+XKz46B/CBTROdtnWbldV6bjx/ur428g WvKI45zQRPfyCkXHMRE5vFXXyTwdeDwhrvM8EHY3nvzgN0b5QTBnMh/ItRqy9m+BFI0o OrsVuvJBrGqTiA6HzSFYJkqUPrl3drHCmnrlK6MZmxx0t782crKI1y9rdi2PLpvqurYX 4MnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:dkim-signature; bh=LLtRMDyuZBiRd8gTdg99mHl24bM/N9b6c5HKt7k9iXk=; b=eiX2LHFe/bQJaECNwkhqJXCsst36tjN4Ll0JWWhtqoJZHCAckFHKMpQQL0V7JVCosR 3BtZ1GW4AAhz1kkGllg3otwDpIDo86F0Cw+DLk57Y0w5O0nBNL5VGi70gJK7QaLYVWhE reBbCvW4kK1bvAQKY+J6icHtIXc0HwnNNM3TxOS7potUnjnReEB+OvDlXOmDN32NZ6Af 9XOgZNlpenJkAYWV8jbexu0yyHBhscOhjJDFsVmhY2NL0CoDRErjlyuIeKv2HpyVSfFt QAab9Rg7tuklf3tJexYgCVRKXnU1kixaCgvWXCS67FPUVV1/QxKT6h34Y0e6IxlgSHic EHfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qO0fly9Z; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id p132si2593291ybc.45.2020.08.12.10.22.27 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Aug 2020 10:22:27 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qO0fly9Z; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:52940 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5uSJ-0007FD-4D for patch@linaro.org; Wed, 12 Aug 2020 13:22:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56866) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5uPn-0003nH-R3 for qemu-devel@nongnu.org; Wed, 12 Aug 2020 13:19:51 -0400 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]:42743) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k5uPm-00017v-4P for qemu-devel@nongnu.org; Wed, 12 Aug 2020 13:19:51 -0400 Received: by mail-pl1-x62c.google.com with SMTP id f5so1400632plr.9 for ; Wed, 12 Aug 2020 10:19:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LLtRMDyuZBiRd8gTdg99mHl24bM/N9b6c5HKt7k9iXk=; b=qO0fly9Z/NZnbtfm/Djw3EjCfHBvuL+rHOYzZ4qspxrG+94xZqgq6UmiICjX8VqQeu Wts5twrbrvfWlsMYCLrtGzJG65aEfehrm4ZYXU362UnY+jMYGmpJkIb7cqtGoJgWVdq2 r0oSOjKii3FjYBbQQ2rCQpXR4GYjVYri4WBZRVIfXW3sjUq7HOlLgIPGuX3nAqyoJV6R 2XpT6TYY4v2onT30CrAyZWEJOOtPWJpNOlTn3WvtWKGaUXXiOKolc1s8p3bT4USJl24J 2+y9K43Dyj2uYsY6GGUirHRMP1yzOxyj5owiDSfRZW6APC+oCkowRtbC4VuXe0zmeXv6 C9oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LLtRMDyuZBiRd8gTdg99mHl24bM/N9b6c5HKt7k9iXk=; b=OIQUkqrV+uP/tDoa/O7slHJXydR6uvJM4iOl9cDPKIw0+ZI5SC4iXwgWVVZN6VFDa0 +MhYQUr0KFNCGPC4OUlrK/hQlRszMtGH0sasgPxU7/CxlhBnQyPI7edGd6wqqm04iaK1 dZOwwa7ZfMAb96zbYy69rpPm3iXqSVUYPB7lOaOSQQ/nFIhUoy3Dt4ncug6eFTZhE/Cg BrXKWMGeK5g//hXgU2147jBJzdNMbcVZ/iyiX7WCqEZCG524AhulXRChbh1Eq1FyWKFi 07wufAG1K21fMMXboiY921Y2AN+KrwSx9REDjj1/VJWj2iaxB2cS6QeE8xizvZlrdwg6 5lQg== X-Gm-Message-State: AOAM533nqeBO5JOJSYtnzssn4wIiFGsyPR8FZeWdXUH68BUhVv/UyAID ymBc61TuMBquxwQcnQXKFL3rAv8vkfw= X-Received: by 2002:a17:90a:8c8f:: with SMTP id b15mr1091982pjo.84.1597252788175; Wed, 12 Aug 2020 10:19:48 -0700 (PDT) Received: from localhost.localdomain ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id y79sm3097206pfb.65.2020.08.12.10.19.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2020 10:19:47 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 0/3] target/arm: Complete ISS for MTE tag check fail Date: Wed, 12 Aug 2020 10:19:43 -0700 Message-Id: <20200812171946.2044791-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::62c; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62c.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Konovalov , Vincenzo Frascino , alex.bennee@linaro.org, peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" As reported by Andrey, I was missing the complete ISS info for the Data Abort raised upon a synchronous tag check fail. The following should fix that. All the twisty little rules for the ISS.ISV bit are already handled by merge_syn_data_abort. Probably the most important bit that was missing was ISS.WnR, as that is independent of ISS.ISV. Andrey, will you please test? r~ Richard Henderson (3): target/arm: Export merge_syn_data_abort from tlb_helper.c target/arm: Pass the entire mte descriptor to mte_check_fail target/arm: Merge ISS for data abort from tag check fail target/arm/internals.h | 4 ++++ target/arm/mte_helper.c | 24 ++++++++++++++---------- target/arm/tlb_helper.c | 8 +++----- 3 files changed, 21 insertions(+), 15 deletions(-) -- 2.25.1 Tested-by: Andrey Konovalov