mbox series

[0/7] IDE: SRST and other fixes

Message ID 20200724052300.1163728-1-jsnow@redhat.com
Headers show
Series IDE: SRST and other fixes | expand

Message

John Snow July 24, 2020, 5:22 a.m. UTC 
The goal of this series is to fix the Software Reset (SRST) routine.
That said, the first six patches are almost entirely unrelated...

Patches 2, 3, and 6 fix extremely minor deviations from the spec I
noticed while researching SRST. (One of them gets rid of a FIXME from
2003.)

Patches 1, 4, and 5 are very small code cleanups that don't cause any
functional changes that should make patches 2, 3, and 6 more obvious to
review.

Patch 7 fixes SRST; it depends on the other patches only for a changed
constant name. With a small rebase, it could be suitable for 5.1.

John Snow (7):
  ide: rename cmd_write to ctrl_write
  ide: don't tamper with the device register
  ide: model HOB correctly
  ide: reorder set/get sector functions
  ide: remove magic constants from the device register
  ide: clear interrupt on command write
  ide: cancel pending callbacks on SRST

 include/hw/ide/internal.h |  21 +++++--
 hw/ide/core.c             | 124 +++++++++++++++++++++++---------------
 hw/ide/ioport.c           |   2 +-
 hw/ide/macio.c            |   2 +-
 hw/ide/mmio.c             |   8 +--
 hw/ide/pci.c              |  12 ++--
 hw/ide/trace-events       |   2 +-
 7 files changed, 106 insertions(+), 65 deletions(-)

-- 
2.26.2