From patchwork Tue Jun 23 07:27:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 279754 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66034C433E1 for ; Tue, 23 Jun 2020 07:28:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2949B20772 for ; Tue, 23 Jun 2020 07:28:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n4E3QgzZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2949B20772 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42332 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jndM2-0000HR-Cc for qemu-devel@archiver.kernel.org; Tue, 23 Jun 2020 03:28:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34538) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jndL7-00070v-3Q; Tue, 23 Jun 2020 03:27:29 -0400 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:37940) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jndL5-0004y5-Bq; Tue, 23 Jun 2020 03:27:28 -0400 Received: by mail-wm1-x341.google.com with SMTP id f18so2064169wml.3; Tue, 23 Jun 2020 00:27:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SySumNVS446KqKTX/VdE1PboXiC+09lFD/1qHTIdXY4=; b=n4E3QgzZB2U1z4gjT9RXlayWWqgPIk2FaFVfR1RqbGUq7hl6VpgIbEacIBfAPnT4eh Cmc1vYpPYwrhBefUsagfHLmSa6K5+xbbbIkrsmkep90GmdQEmDGhCXAGNVQvrERzrRoG fbvd89QkCKy+/MyqT8taAq7xWgheb9Vc4dEuiBeXzJ2k90ldO4W8BPWC9SIJlQzSYdbw ANtVdcjwmnkjQn8IMGk+8ns1zTOuxjG7FXDScgnD0UaKpJxiv5ZRvI5qhX8fndBll9xh NJQDFam7VU7cS4Tp6QwDltgdTi+jUv6W+tvV8rFgxaItMUPTOU3oDxwM7DD6NE2UHyY2 J/ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=SySumNVS446KqKTX/VdE1PboXiC+09lFD/1qHTIdXY4=; b=Yy1bWC3yHJFf7EIlcDoAqyi7pDuz1rRQWIxSsjAkxpUVev5yCAZXToTmEKYBpL8IbV 6IQlT1bOz4MG7wI9HSIpJjGJUG2hq6imj+sOrWwbKell3nDsKFPBeDlsbnIajZZrvUDb eExEbnJOXbQP1rzA23cY/6p+op4HWBGOIAIEN3EgpsUadD8XrY8nFVdpgUj9luUq0WQ4 mGfgUJLK/TfA11GddYxPPKzRol6E2unbCMxsf6tAk6VOMrVykuoF0znFYK6/iXXjNYVt Cq270QxFXmBMMW0EJzzAynyw3cOcvgbEidHqjvlj9d2x4aW0ZylIk4C4ECUm7DoojCOR LL6g== X-Gm-Message-State: AOAM532RIZMZ6Zi3u5EcxNl9MmR95N9fuDZM3ssQGWUITK/SCEGF7uRU B8i+1Cc7ayniRcqldFQvhexJsbp9 X-Google-Smtp-Source: ABdhPJzyk7NsMZkYlkT02j5gzRby3gPnRmXszv+hpI++/pzVuAZi3JFAzRBcZHIFsnuzSIJiEUlFww== X-Received: by 2002:a1c:b6c3:: with SMTP id g186mr6436311wmf.135.1592897245148; Tue, 23 Jun 2020 00:27:25 -0700 (PDT) Received: from localhost.localdomain (1.red-83-51-162.dynamicip.rima-tde.net. [83.51.162.1]) by smtp.gmail.com with ESMTPSA id l14sm4200059wrn.18.2020.06.23.00.27.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2020 00:27:24 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v6 0/9] hw/misc/pca9552: Trace GPIO change events Date: Tue, 23 Jun 2020 09:27:14 +0200 Message-Id: <20200623072723.6324-1-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::341; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x341.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Corey Minyard , Andrew Jeffery , =?utf-8?q?Ph?= =?utf-8?q?ilippe_Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, =?utf-8?q?C=C3=A9dric_Le_Goater?= , Joel Stanley Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This series add trace events to better display GPIO changes. We'll continue in the following series by connecting LEDs to these GPIOs. This helps me to work on a generic LED device, see: https://www.mail-archive.com/qemu-devel@nongnu.org/msg711917.html Since v5, addressed Cédric review comment: - Move pin_count check from realize() to instance_init() Since v4: Addressed Cédric review comments - Extract PCA955xClass - Add/use pca955x_pins_get_status() method instead of keeping cached value in PCA955xState Example when booting an obmc-phosphor-image, we can see the LED #14 (front-power LED) starting to blink. - ASCII LED bar view: $ qemu-system-arm -M witherspoon-bmc -trace pca955x_gpio_status 1592689902.327837:pca955x_gpio_status pca-unspecified GPIOs 0-15 [*...............] 1592689902.329934:pca955x_gpio_status pca-unspecified GPIOs 0-15 [**..............] 1592689902.330717:pca955x_gpio_status pca-unspecified GPIOs 0-15 [***.............] 1592689902.331431:pca955x_gpio_status pca-unspecified GPIOs 0-15 [****............] 1592689902.332163:pca955x_gpio_status pca-unspecified GPIOs 0-15 [****.........*..] 1592689902.332888:pca955x_gpio_status pca-unspecified GPIOs 0-15 [****.........**.] 1592689902.333629:pca955x_gpio_status pca-unspecified GPIOs 0-15 [****.........***] 1592690032.793289:pca955x_gpio_status pca-unspecified GPIOs 0-15 [****.........*.*] 1592690033.303163:pca955x_gpio_status pca-unspecified GPIOs 0-15 [****.........***] 1592690033.812962:pca955x_gpio_status pca-unspecified GPIOs 0-15 [****.........*.*] 1592690034.323234:pca955x_gpio_status pca-unspecified GPIOs 0-15 [****.........***] 1592690034.832922:pca955x_gpio_status pca-unspecified GPIOs 0-15 [****.........*.*] - Only display GPIOs which status changes: $ qemu-system-arm -M witherspoon-bmc -trace pca955x_gpio_change 1592690552.687372:pca955x_gpio_change pca1 GPIO id:0 status: 0 -> 1 1592690552.690169:pca955x_gpio_change pca1 GPIO id:1 status: 0 -> 1 1592690552.691673:pca955x_gpio_change pca1 GPIO id:2 status: 0 -> 1 1592690552.696886:pca955x_gpio_change pca1 GPIO id:3 status: 0 -> 1 1592690552.698614:pca955x_gpio_change pca1 GPIO id:13 status: 0 -> 1 1592690552.699833:pca955x_gpio_change pca1 GPIO id:14 status: 0 -> 1 1592690552.700842:pca955x_gpio_change pca1 GPIO id:15 status: 0 -> 1 1592690683.841921:pca955x_gpio_change pca1 GPIO id:14 status: 1 -> 0 1592690683.861660:pca955x_gpio_change pca1 GPIO id:14 status: 0 -> 1 1592690684.371460:pca955x_gpio_change pca1 GPIO id:14 status: 1 -> 0 1592690684.882115:pca955x_gpio_change pca1 GPIO id:14 status: 0 -> 1 1592690685.391411:pca955x_gpio_change pca1 GPIO id:14 status: 1 -> 0 1592690685.901391:pca955x_gpio_change pca1 GPIO id:14 status: 0 -> 1 For information about how to test the obmc-phosphor-image, see: https://www.mail-archive.com/qemu-devel@nongnu.org/msg712911.html $ git backport-diff -u v5 Key: [----] : patches are identical [####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively 001/9:[----] [--] 'hw/i2c/core: Add i2c_try_create_slave() and i2c_realize_and_unref()' 002/9:[----] [--] 'hw/misc/pca9552: Rename 'nr_leds' as 'pin_count'' 003/9:[----] [--] 'hw/misc/pca9552: Rename generic code as pca955x' 004/9:[0010] [FC] 'hw/misc/pca9552: Add generic PCA955xClass, parent of TYPE_PCA9552' 005/9:[0007] [FC] 'hw/misc/pca9552: Add a 'description' property for debugging purpose' 006/9:[----] [--] 'hw/misc/pca9552: Trace GPIO High/Low events' 007/9:[----] [-C] 'hw/arm/aspeed: Describe each PCA9552 device' 008/9:[----] [--] 'hw/misc/pca9552: Trace GPIO change events' 009/9:[0003] [FC] 'hw/misc/pca9552: Model qdev output GPIOs' Based-on: <20200623072132.2868-1-f4bug@amsat.org> Philippe Mathieu-Daudé (9): hw/i2c/core: Add i2c_try_create_slave() and i2c_realize_and_unref() hw/misc/pca9552: Rename 'nr_leds' as 'pin_count' hw/misc/pca9552: Rename generic code as pca955x hw/misc/pca9552: Add generic PCA955xClass, parent of TYPE_PCA9552 hw/misc/pca9552: Add a 'description' property for debugging purpose hw/misc/pca9552: Trace GPIO High/Low events hw/arm/aspeed: Describe each PCA9552 device hw/misc/pca9552: Trace GPIO change events hw/misc/pca9552: Model qdev output GPIOs include/hw/i2c/i2c.h | 2 + include/hw/misc/pca9552.h | 16 +-- hw/arm/aspeed.c | 13 ++- hw/i2c/core.c | 18 +++- hw/misc/pca9552.c | 216 ++++++++++++++++++++++++++++---------- hw/misc/trace-events | 4 + 6 files changed, 202 insertions(+), 67 deletions(-)