mbox series

[RISU,0/9] risu cleanups and improvements

Message ID 20200513180953.20376-1-richard.henderson@linaro.org
Headers show
Series risu cleanups and improvements | expand

Message

Richard Henderson May 13, 2020, 6:09 p.m. UTC 
This patch set does alter the format of the trace files, and thus
means we'll have to re-generate these.  However, the space saved
for sve trace files is significant, so I consider it worthwhile.

In addition, the new --dump option allows one to inspect the
contents of the trace file.


r~


Richard Henderson (9):
  Use bool for tracing variables
  Unify master_fd and apprentice_fd to comm_fd
  Hoist trace file opening
  Adjust tracefile open for write
  Use EXIT_FAILURE, EXIT_SUCCESS
  Add magic and size to the trace header
  Compute reginfo_size based on the reginfo
  aarch64: Reorg sve reginfo to save space
  Add --dump option to inspect trace files

 risu.h                 |  12 ++-
 risu_reginfo_aarch64.h |  16 +---
 comms.c                |  26 +++---
 reginfo.c              |  45 ++++++---
 risu.c                 | 208 ++++++++++++++++++++++++++++++-----------
 risu_reginfo_aarch64.c | 192 ++++++++++++++++++++-----------------
 risu_reginfo_arm.c     |   6 +-
 risu_reginfo_i386.c    |   8 +-
 risu_reginfo_m68k.c    |   6 +-
 risu_reginfo_ppc64.c   |   6 +-
 10 files changed, 342 insertions(+), 183 deletions(-)

-- 
2.20.1

Comments

Peter Maydell May 18, 2020, 6:39 p.m. UTC | #1 
On Wed, 13 May 2020 at 19:09, Richard Henderson
<richard.henderson@linaro.org> wrote:
>

> This patch set does alter the format of the trace files, and thus

> means we'll have to re-generate these.  However, the space saved

> for sve trace files is significant, so I consider it worthwhile.

>

> In addition, the new --dump option allows one to inspect the

> contents of the trace file.


Alex, would you mind reviewing these risu patches, given that they're
mostly trace related? (Also you're the one who'll have to regenerate
a lot of trace files :-))

Richard: if you feed an old trace file to the new risu, what
error message does it give?

thanks
-- PMM
Alex Bennée May 18, 2020, 7:14 p.m. UTC | #2 
Peter Maydell <peter.maydell@linaro.org> writes:

> On Wed, 13 May 2020 at 19:09, Richard Henderson

> <richard.henderson@linaro.org> wrote:

>>

>> This patch set does alter the format of the trace files, and thus

>> means we'll have to re-generate these.  However, the space saved

>> for sve trace files is significant, so I consider it worthwhile.

>>

>> In addition, the new --dump option allows one to inspect the

>> contents of the trace file.

>

> Alex, would you mind reviewing these risu patches, given that they're

> mostly trace related? (Also you're the one who'll have to regenerate

> a lot of trace files :-))


Sure. I'll have a look in the morning.

>

> Richard: if you feed an old trace file to the new risu, what

> error message does it give?

>

> thanks

> -- PMM



-- 
Alex Bennée
Richard Henderson May 18, 2020, 7:33 p.m. UTC | #3 
On 5/18/20 11:39 AM, Peter Maydell wrote:
> On Wed, 13 May 2020 at 19:09, Richard Henderson

> <richard.henderson@linaro.org> wrote:

>>

>> This patch set does alter the format of the trace files, and thus

>> means we'll have to re-generate these.  However, the space saved

>> for sve trace files is significant, so I consider it worthwhile.

>>

>> In addition, the new --dump option allows one to inspect the

>> contents of the trace file.

> 

> Alex, would you mind reviewing these risu patches, given that they're

> mostly trace related? (Also you're the one who'll have to regenerate

> a lot of trace files :-))

> 

> Richard: if you feed an old trace file to the new risu, what

> error message does it give?


Bah, it should have generated an error vs the magic number, but doesn't -- it
silently exits with success.  Alex, expect a v2.


r~
Richard Henderson May 18, 2020, 7:43 p.m. UTC | #4 
On 5/18/20 12:33 PM, Richard Henderson wrote:
> On 5/18/20 11:39 AM, Peter Maydell wrote:

>> Richard: if you feed an old trace file to the new risu, what

>> error message does it give?

> 

> Bah, it should have generated an error vs the magic number, but doesn't -- it

> silently exits with success.  Alex, expect a v2.


Double bah.  Typo in git checkout, so I didn't actually switch branches for the
test.  It does print an error, but not a useful one:

match status...
mismatch on regs!

I'll improve this.


r~