From patchwork Fri May 10 01:24:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 163789 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:142:0:0:0:0 with SMTP id j2csp1721554ilr; Thu, 9 May 2019 18:28:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqwv838OVZOdFlvG/oNspeUo/rlhrtS6NlFtRe788AX/AuO3r/0IGQWfVKls+nk3m8lo1MXW X-Received: by 2002:a7b:cb16:: with SMTP id u22mr4952488wmj.60.1557451687084; Thu, 09 May 2019 18:28:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557451687; cv=none; d=google.com; s=arc-20160816; b=SFPOQHUce0Mfs82nj0PRix54SJeM/niLfOH2FqHRas0UKWHrcRh7ymFlOrAAffffrJ wgCpeMjhwkGj++abVqng7/H1bn5uxVmy6ejAw3F4jF4wojzFAsC/7slsHYvZVhqAcesC Tk3rNPjtBaU6J7qAD7hQ8sr+pIz6j+FVgbrLSqyp9T4JUSlLqDMq4SLzQYyDgK2zWmAu Xeok9r7KEm3QCCYYtOcId4xqfTd+8b6Oi+4fSqrXVjp7N1SZhJL4rntHN+PFARWsNyYw WnevAvqEGev4eZbl3zZRMTnXKa07gtkpGi4ofhnVwL2mMXXmwZh72/P68e3ovHkEuXHy zl0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:message-id:date:to:from :dkim-signature; bh=2u+WrSd8xo/S0FMY/ihl1INQm5pe2wd8l2cCz5+JKpI=; b=UuF0PnN6FznrEr+ZhP7O1wQZikPadkv8UnkPGPgpgES0YC/NcdmP0JHJjpwwO8M7RL e+BkUHTupiglJRDiod9N1eJ02HD5SVeMt79cjkpw95V7YxHAK4c0CpvNhEhYBpEBoAD6 aEOXaBiA51Xek24YWHx8U/a0rhpDOcsmDnBmOmviZ2cdeR5M5ZUGWG3pfCP9FfsV9YsW GDN681NblHeGnnPZYH1/e53FgQcFwlbinsq0XiM+hB28NIjLBFARQGSdCm1xgYCq9ZRI D5sC9f16dFa9ldbYHyiDTE1X95dwGAy+7U2MvsQ6HhckLEmzjld49rlPhhvVwOmjXkJB e8+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=bPaTt2Yx; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id r1si2661303wmc.75.2019.05.09.18.28.06 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 09 May 2019 18:28:07 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=bPaTt2Yx; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:35024 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOuKT-0000nr-V7 for patch@linaro.org; Thu, 09 May 2019 21:28:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58565) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOuHi-0006Ij-SZ for qemu-devel@nongnu.org; Thu, 09 May 2019 21:25:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOuHg-00012Z-VN for qemu-devel@nongnu.org; Thu, 09 May 2019 21:25:14 -0400 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]:40647) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hOuHZ-0000sZ-DD for qemu-devel@nongnu.org; Thu, 09 May 2019 21:25:07 -0400 Received: by mail-pg1-x534.google.com with SMTP id d31so2124713pgl.7 for ; Thu, 09 May 2019 18:25:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=2u+WrSd8xo/S0FMY/ihl1INQm5pe2wd8l2cCz5+JKpI=; b=bPaTt2YxNyEJiKkcuoRwBwJ0sMKu17PEx8mDImj/dNM5FOpMIAFhMDVipkB2K7YrwC n/xvvTEqXL2+IuPmEPRYS15r9JFg/zIsscSrWY4NUOHFbaAZQTG00QVp75ehPFKdjCoA IIjHM27tThbJUz1Z4dsTFM6z42q+6zBdaPd2mN8odbRUFjdA+ikCagWzsGQaBG/mGPDc Ju1Wyq753ODGy8k1+JD9+jlTbTDZeqklzCEfyNi+/GPfvRHKgWKqKvXnDeYedg4cI5lW TGBUOmhce2igCHNKUH5hCgMOuhmQR7WW9PYLzrRc0LoGqXfrMqM2t8oM57ldU4vh7HFk JVaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=2u+WrSd8xo/S0FMY/ihl1INQm5pe2wd8l2cCz5+JKpI=; b=GzXly/U5JimO9FiQ8rgzoxgp1DbWiOUHjwKeunooAL9Vq4qOndUOqaU18BBLPQYTCU sBOb9l4E8SG/mwnrOsr1B3rQRmSKBa3qOmizbjUhJHTmR3GQd6sckaEHeqb0RUE6Yccm Yd+Vz39mVcG9eWfuzesCGK4tvcVGk8SjVDYvmR8V9jSl44Lr6dcMSN1LvkkMc1zkMGNQ jA8AUMzvrPm+70aKAV64k+g6l8VWU7mFUwf8yqUVUC4lFexs9732bqJVHB+WOLUJRgmQ 6r+luDuwmolR30v+y06atjNycDF1D64kSj9J/JFL5XTn1h5GSSMZs9ZL5kH4PeYhTCZE EIvA== X-Gm-Message-State: APjAAAUCZD6PLm82FcuOAKARR9HN5Fnyw2cEgEG1JxkDfLCFAEOteZLB zIxhyEmSsjw0kogSPAYgIgJSFPWrlXA= X-Received: by 2002:a63:a849:: with SMTP id i9mr9918831pgp.205.1557451500206; Thu, 09 May 2019 18:25:00 -0700 (PDT) Received: from localhost.localdomain (97-113-13-231.tukw.qwest.net. [97.113.13.231]) by smtp.gmail.com with ESMTPSA id n18sm8252700pfi.48.2019.05.09.18.24.59 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 May 2019 18:24:59 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 9 May 2019 18:24:34 -0700 Message-Id: <20190510012458.22706-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::534 Subject: [Qemu-devel] [PATCH v5 00/24] Add qemu_getrandom and ARMv8.5-RNG etc X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Patches without review/ack: 0001-configure-Link-test-before-auto-enabling-crypto-l.patch 0002-crypto-Merge-crypto-obj-y-into-libqemuutil.a.patch 0022-target-arm-Implement-ARMv8.5-RNG.patch Changes since v4: * Do not autoenable nettle or gcrypt if linking is broken. Fixes --static on fedora 30. * Delay removal of srand() for -seed. * Do not loop for -1 result for ppc64 DARN. Changes since v3: * Do not autoenable gnutls if linking is broken. Fixes --static on ubuntu 18.04. Changes since v2: * Changes from review. - getrandom is not exclusive of /dev/urandom fallback. - vnc fails gracefully on crypto failure. - a great renaming. * Drop the "nonblock" argument, as it's not deliverable from the backend. * Propagate Error back through qemu_guest_getrandom. * Add qemu_guest_getrandom_nofail to centralize "Argh! Death!". * Convert hw/misc/ * Implement ppc darn. * Implement x86 rdrand. Changes since v1: * Build crypto-obj-y for linux-user as well. * Several patches to tidy crypto/random-platform.c. * Use getrandom(2) in crypto/random-platform.c. * Use qcrypto_random_bytes in ui/vnc.c. * In qemu_getrandom: - Use g_rand_int instead of srand48. - Use qcrypto_random_bytes instead of getrandom directly. Richard Henderson (24): configure: Link test before auto-enabling crypto libraries crypto: Merge crypto-obj-y into libqemuutil.a crypto: Reverse code blocks in random-platform.c crypto: Do not fail for EINTR during qcrypto_random_bytes crypto: Use O_CLOEXEC in qcrypto_random_init crypto: Use getrandom for qcrypto_random_bytes crypto: Change the qcrypto_random_bytes buffer type to void* ui/vnc: Split out authentication_failed ui/vnc: Use gcrypto_random_bytes for start_auth_vnc util: Add qemu_guest_getrandom and associated routines cpus: Initialize pseudo-random seeds for all guest cpus linux-user: Initialize pseudo-random seeds for all guest cpus linux-user: Call qcrypto_init if not using -seed linux-user: Use qemu_guest_getrandom_nofail for AT_RANDOM linux-user/aarch64: Use qemu_guest_getrandom for PAUTH keys linux-user: Remove srand call aspeed/scu: Use qemu_guest_getrandom_nofail hw/misc/nrf51_rng: Use qemu_guest_getrandom_nofail hw/misc/bcm2835_rng: Use qemu_guest_getrandom_nofail hw/misc/exynos4210_rng: Use qemu_guest_getrandom target/arm: Put all PAC keys into a structure target/arm: Implement ARMv8.5-RNG target/ppc: Use qemu_guest_getrandom for DARN target/i386: Implement CPUID_EXT_RDRAND Makefile | 12 ++-- Makefile.objs | 8 +-- Makefile.target | 4 -- include/crypto/random.h | 2 +- include/qemu/guest-random.h | 68 ++++++++++++++++++ include/qom/cpu.h | 1 + linux-user/aarch64/target_syscall.h | 2 - target/arm/cpu.h | 17 +++-- target/i386/helper.h | 2 + cpus.c | 9 +++ crypto/random-gcrypt.c | 2 +- crypto/random-gnutls.c | 2 +- crypto/random-platform.c | 104 +++++++++++++++++----------- hw/misc/aspeed_scu.c | 10 +-- hw/misc/bcm2835_rng.c | 32 ++++----- hw/misc/exynos4210_rng.c | 11 ++- hw/misc/nrf51_rng.c | 4 +- linux-user/aarch64/cpu_loop.c | 25 +------ linux-user/elfload.c | 8 +-- linux-user/main.c | 34 +++++---- linux-user/syscall.c | 34 +++++++-- target/arm/cpu64.c | 1 + target/arm/helper.c | 64 ++++++++++++++--- target/arm/pauth_helper.c | 18 ++--- target/i386/cpu.c | 5 +- target/i386/int_helper.c | 21 ++++++ target/i386/translate.c | 55 +++++++++++---- target/ppc/int_helper.c | 39 +++++++---- ui/vnc.c | 53 ++++++-------- util/guest-random.c | 93 +++++++++++++++++++++++++ vl.c | 4 ++ configure | 87 +++++++++++++++-------- crypto/Makefile.objs | 5 +- qemu-options.hx | 10 +++ util/Makefile.objs | 1 + 35 files changed, 586 insertions(+), 261 deletions(-) create mode 100644 include/qemu/guest-random.h create mode 100644 util/guest-random.c -- 2.17.1