| Message ID | 20190219233421.388-1-richard.henderson@linaro.org |
|---|---|
| Headers | show |
| Series | target/arm: Reduce overhead of cpu_get_tb_cpu_state | expand |
Patchew URL: https://patchew.org/QEMU/20190219233421.388-1-richard.henderson@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190219233421.388-1-richard.henderson@linaro.org Subject: [Qemu-devel] [PATCH v2 0/3] target/arm: Reduce overhead of cpu_get_tb_cpu_state Type: series === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20190219233421.388-1-richard.henderson@linaro.org -> patchew/20190219233421.388-1-richard.henderson@linaro.org Switched to a new branch 'test' fdca6b67d3 target/arm: Rely on hflags correct in cpu_get_tb_cpu_state 8615480629 target/arm: Rebuild hflags at el changes and MSR writes 0d2a83ccfd target/arm: Split out recompute_hflags et al === OUTPUT BEGIN === 1/3 Checking commit 0d2a83ccfd5e (target/arm: Split out recompute_hflags et al) WARNING: Block comments use a leading /* on a separate line #277: FILE: target/arm/helper.c:13972: + /* If SVE is disabled, but FP is enabled, WARNING: Block comments use a leading /* on a separate line #358: FILE: target/arm/helper.c:14053: + /* The SS_ACTIVE and PSTATE_SS bits correspond to the state machine total: 0 errors, 2 warnings, 363 lines checked Patch 1/3 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/3 Checking commit 86154806299c (target/arm: Rebuild hflags at el changes and MSR writes) 3/3 Checking commit fdca6b67d324 (target/arm: Rely on hflags correct in cpu_get_tb_cpu_state) ERROR: Use g_assert or g_assert_not_reached #73: FILE: target/arm/helper.c:14049: + g_assert_cmphex(flags, ==, check_flags); total: 1 errors, 0 warnings, 34 lines checked Patch 3/3 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190219233421.388-1-richard.henderson@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190219233421.388-1-richard.henderson@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190219233421.388-1-richard.henderson@linaro.org Subject: [Qemu-devel] [PATCH v2 0/3] target/arm: Reduce overhead of cpu_get_tb_cpu_state Type: series === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20190219233421.388-1-richard.henderson@linaro.org -> patchew/20190219233421.388-1-richard.henderson@linaro.org Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone' Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc' Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers' Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF' Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe' Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios' Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware' Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode' Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios' Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa' Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios' Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot' Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot' Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex' Submodule 'tests/fp/berkeley-softfloat-3' (https://github.com/cota/berkeley-softfloat-3) registered for path 'tests/fp/berkeley-softfloat-3' Submodule 'tests/fp/berkeley-testfloat-3' (https://github.com/cota/berkeley-testfloat-3) registered for path 'tests/fp/berkeley-testfloat-3' Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb' Cloning into 'capstone'... Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf' Cloning into 'dtc'... Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536' Cloning into 'roms/QemuMacDrivers'... Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266' Cloning into 'roms/SLOF'... Submodule path 'roms/SLOF': checked out 'a5b428e1c1eae703bdd62a3f527223c291ee3fdc' Cloning into 'roms/ipxe'... Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17' Cloning into 'roms/openbios'... Submodule path 'roms/openbios': checked out '3464681b2b5983df80086a40179d324102347da3' Cloning into 'roms/openhackware'... Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5' Cloning into 'roms/qemu-palcode'... Submodule path 'roms/qemu-palcode': checked out '51c237d7e20d05100eacadee2f61abc17e6bc097' Cloning into 'roms/seabios'... Submodule path 'roms/seabios': checked out 'a698c8995ffb2838296ec284fe3c4ad33dfca307' Cloning into 'roms/seabios-hppa'... Submodule path 'roms/seabios-hppa': checked out '1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0' Cloning into 'roms/sgabios'... Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a' Cloning into 'roms/skiboot'... Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc' Cloning into 'roms/u-boot'... Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943' Cloning into 'roms/u-boot-sam460ex'... Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588' Cloning into 'tests/fp/berkeley-softfloat-3'... Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037' Cloning into 'tests/fp/berkeley-testfloat-3'... Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3' Cloning into 'ui/keycodemapdb'... Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce' Switched to a new branch 'test' fdca6b6 target/arm: Rely on hflags correct in cpu_get_tb_cpu_state 8615480 target/arm: Rebuild hflags at el changes and MSR writes 0d2a83c target/arm: Split out recompute_hflags et al === OUTPUT BEGIN === 1/3 Checking commit 0d2a83ccfd5e (target/arm: Split out recompute_hflags et al) WARNING: Block comments use a leading /* on a separate line #277: FILE: target/arm/helper.c:13972: + /* If SVE is disabled, but FP is enabled, WARNING: Block comments use a leading /* on a separate line #358: FILE: target/arm/helper.c:14053: + /* The SS_ACTIVE and PSTATE_SS bits correspond to the state machine total: 0 errors, 2 warnings, 363 lines checked Patch 1/3 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/3 Checking commit 86154806299c (target/arm: Rebuild hflags at el changes and MSR writes) 3/3 Checking commit fdca6b67d324 (target/arm: Rely on hflags correct in cpu_get_tb_cpu_state) ERROR: Use g_assert or g_assert_not_reached #73: FILE: target/arm/helper.c:14049: + g_assert_cmphex(flags, ==, check_flags); total: 1 errors, 0 warnings, 34 lines checked Patch 3/3 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190219233421.388-1-richard.henderson@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On Tue, Feb 19, 2019 at 15:34:18 -0800, Richard Henderson wrote: > Changes since v1: > * Apparently I had started a last-minute API change, and failed to > covert all of the users, and also failed to re-test afterward. > * Retain assertions for --enable-debug-tcg. This brings my arm-softmmu bootup+shutdown test to an early death: [...] VFS: Mounted root (ext4 filesystem) readonly on device 254:1. devtmpfs: mounted Freeing unused kernel memory: 300K (80669000 - 806b4000) BUG: unsupported FP instruction in kernel mode Internal error: Oops - undefined instruction: 0 [#1] SMP ARM Modules linked in: CPU: 0 PID: 1 Comm: init Not tainted 4.5.0-ajb #10 Hardware name: Generic DT based system task: eec58000 ti: eec52000 task.ti: eec52000 PC is at vfp_reload_hw+0xc/0x44 LR is at __und_usr_fault_32+0x0/0x8 pc : [<8000ab94>] lr : [<800136c0>] psr: 000c0013 sp : eec53fb0 ip : 7eb88918 fp : 00000000 r10: eec520f8 r9 : 8001371c r8 : 00000b00 r7 : 00000001 r6 : eec5204c r5 : 40000000 r4 : 00000000 r3 : 806e1058 r2 : 76fc1362 r1 : 40000000 r0 : ecac8b10 Flags: nzcv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user Control: 30c5387d Table: ae4048c0 DAC: fffffffd Process init (pid: 1, stack limit = 0xeec52210) Stack: (0xeec53fb0 to 0xeec54000) 3fa0: 7eb888f0 00000000 003fb0d6 fffffd90 3fc0: 7eb888e0 76fd8050 00000000 7eb88ab0 00000000 0001223c 76fd8958 7eb88a90 3fe0: 7eb88918 7eb888c0 76fbb187 76fc1362 600c0030 ffffffff 00000000 00000000 [<8000ab94>] (vfp_reload_hw) from [<800136c0>] (__und_usr_fault_32+0x0/0x8) Code: 0a000010 e58ab110 eee85a10 e783a10b (ecba0b20) ---[ end trace 26acd422f5b3785f ]--- Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b Thanks, Emilio
Emilio G. Cota <cota@braap.org> writes: > On Tue, Feb 19, 2019 at 15:34:18 -0800, Richard Henderson wrote: >> Changes since v1: >> * Apparently I had started a last-minute API change, and failed to >> covert all of the users, and also failed to re-test afterward. >> * Retain assertions for --enable-debug-tcg. > > This brings my arm-softmmu bootup+shutdown test to an early death: Can you retry with --enable-tcg-debug? > > [...] > VFS: Mounted root (ext4 filesystem) readonly on device 254:1. > devtmpfs: mounted > Freeing unused kernel memory: 300K (80669000 - 806b4000) > BUG: unsupported FP instruction in kernel mode > Internal error: Oops - undefined instruction: 0 [#1] SMP ARM > Modules linked in: > CPU: 0 PID: 1 Comm: init Not tainted 4.5.0-ajb #10 > Hardware name: Generic DT based system > task: eec58000 ti: eec52000 task.ti: eec52000 > PC is at vfp_reload_hw+0xc/0x44 > LR is at __und_usr_fault_32+0x0/0x8 > pc : [<8000ab94>] lr : [<800136c0>] psr: 000c0013 > sp : eec53fb0 ip : 7eb88918 fp : 00000000 > r10: eec520f8 r9 : 8001371c r8 : 00000b00 > r7 : 00000001 r6 : eec5204c r5 : 40000000 r4 : 00000000 > r3 : 806e1058 r2 : 76fc1362 r1 : 40000000 r0 : ecac8b10 > Flags: nzcv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user > Control: 30c5387d Table: ae4048c0 DAC: fffffffd > Process init (pid: 1, stack limit = 0xeec52210) > Stack: (0xeec53fb0 to 0xeec54000) > 3fa0: 7eb888f0 00000000 003fb0d6 fffffd90 > 3fc0: 7eb888e0 76fd8050 00000000 7eb88ab0 00000000 0001223c 76fd8958 7eb88a90 > 3fe0: 7eb88918 7eb888c0 76fbb187 76fc1362 600c0030 ffffffff 00000000 00000000 > [<8000ab94>] (vfp_reload_hw) from [<800136c0>] (__und_usr_fault_32+0x0/0x8) > Code: 0a000010 e58ab110 eee85a10 e783a10b (ecba0b20) > ---[ end trace 26acd422f5b3785f ]--- > Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b > ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b > > Thanks, > > Emilio -- Alex Bennée
On Thu, Feb 21, 2019 at 22:36:25 +0000, Alex Bennée wrote: > Emilio G. Cota <cota@braap.org> writes: > > This brings my arm-softmmu bootup+shutdown test to an early death: > > Can you retry with --enable-tcg-debug? Should have done so the first time. Here it is: (gdb) r Starting program: /data/src/qemu/build/arm-softmmu/qemu-system-arm -machine type=virt -nographic -m 4096 -netdev user,id=unet,hostfwd=tcp::2222-:22 -d evice virtio-net-device,netdev=unet -drive file=../img/arm/jessie-arm32-die-on-boot.qcow2,id=myblock,index=0,if=none -device virtio-blk-device,drive=m yblock -kernel ../img/arm/aarch32-current-linux-kernel-only.img -append console=ttyAMA0\ root=/dev/vda1 -name arm,debug-threads=on -smp 1 [...] VFS: Mounted root (ext4 filesystem) readonly on device 254:1. devtmpfs: mounted Freeing unused kernel memory: 300K (80669000 - 806b4000) ** ERROR:/data/src/qemu/target/arm/helper.c:14049:cpu_get_tb_cpu_state: assertion failed (flags == check_flags): (0x10080000 == 0x10080080) Thread 4 "CPU 0/TCG" received signal SIGABRT, Aborted. [Switching to Thread 0x7fffee2aa700 (LWP 14033)] __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51 51 ../sysdeps/unix/sysv/linux/raise.c: No such file or directory. (gdb) bt #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51 #1 0x00007ffff4585801 in __GI_abort () at abort.c:79 #2 0x00007ffff570f2a5 in g_assertion_message () from /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0 #3 0x00007ffff570f652 in g_assertion_message_cmpnum () from /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0 #4 0x00005555559a339b in cpu_get_tb_cpu_state (env=0x5555565af060, pc=pc@entry=0x7fffee2a98fc, cs_base=cs_base@entry=0x7fffee2a98f8, pflags=pflags@entry=0x7fffee2a9900) at /data/src/qemu/target/arm/helper.c:14049 #5 0x000055555588fbdb in tb_lookup__cpu_state (cf_mask=524288, flags=0x7fffee2a9900, cs_base=0x7fffee2a98f8, pc=0x7fffee2a98fc, cpu=0x0) at /data/src/qemu/include/exec/tb-lookup.h:28 #6 tb_find (cf_mask=524288, tb_exit=0, last_tb=0x0, cpu=0x0) at /data/src/qemu/accel/tcg/cpu-exec.c:404 #7 cpu_exec (cpu=cpu@entry=0x5555565a6db0) at /data/src/qemu/accel/tcg/cpu-exec.c:728 #8 0x000055555584e49f in tcg_cpu_exec (cpu=0x5555565a6db0) at /data/src/qemu/cpus.c:1429 #9 0x0000555555850623 in qemu_tcg_cpu_thread_fn (arg=arg@entry=0x5555565a6db0) at /data/src/qemu/cpus.c:1733 #10 0x0000555555c83416 in qemu_thread_start (args=<optimized out>) at /data/src/qemu/util/qemu-thread-posix.c:502 #11 0x00007ffff493d6db in start_thread (arg=0x7fffee2aa700) at pthread_create.c:463 #12 0x00007ffff466688f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95 (gdb) Thanks, Emilio
On 2/21/19 2:59 PM, Emilio G. Cota wrote: > Should have done so the first time. Here it is: > > (gdb) r > Starting program: /data/src/qemu/build/arm-softmmu/qemu-system-arm -machine type=virt -nographic -m 4096 -netdev user,id=unet,hostfwd=tcp::2222-:22 -d > evice virtio-net-device,netdev=unet -drive file=../img/arm/jessie-arm32-die-on-boot.qcow2,id=myblock,index=0,if=none -device virtio-blk-device,drive=m > yblock -kernel ../img/arm/aarch32-current-linux-kernel-only.img -append console=ttyAMA0\ root=/dev/vda1 -name arm,debug-threads=on -smp 1 > [...] > VFS: Mounted root (ext4 filesystem) readonly on device 254:1. > devtmpfs: mounted > Freeing unused kernel memory: 300K (80669000 - 806b4000) > ** > ERROR:/data/src/qemu/target/arm/helper.c:14049:cpu_get_tb_cpu_state: assertion failed (flags == check_flags): (0x10080000 == 0x10080080) Thanks, I've now reproduced this. r~
Patchew URL: https://patchew.org/QEMU/20190219233421.388-1-richard.henderson@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190219233421.388-1-richard.henderson@linaro.org Subject: [Qemu-devel] [PATCH v2 0/3] target/arm: Reduce overhead of cpu_get_tb_cpu_state Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' f6e7ff3298 target/arm: Rely on hflags correct in cpu_get_tb_cpu_state 2ccfa3184b target/arm: Rebuild hflags at el changes and MSR writes eed68828e4 target/arm: Split out recompute_hflags et al === OUTPUT BEGIN === 1/3 Checking commit eed68828e48e (target/arm: Split out recompute_hflags et al) WARNING: Block comments use a leading /* on a separate line #277: FILE: target/arm/helper.c:12912: + /* If SVE is disabled, but FP is enabled, WARNING: Block comments use a leading /* on a separate line #358: FILE: target/arm/helper.c:12993: + /* The SS_ACTIVE and PSTATE_SS bits correspond to the state machine total: 0 errors, 2 warnings, 363 lines checked Patch 1/3 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/3 Checking commit 2ccfa3184bd5 (target/arm: Rebuild hflags at el changes and MSR writes) 3/3 Checking commit f6e7ff32983e (target/arm: Rely on hflags correct in cpu_get_tb_cpu_state) ERROR: Use g_assert or g_assert_not_reached #75: FILE: target/arm/helper.c:12989: + g_assert_cmphex(flags, ==, check_flags); total: 1 errors, 0 warnings, 34 lines checked Patch 3/3 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190219233421.388-1-richard.henderson@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Changes since v1: * Apparently I had started a last-minute API change, and failed to covert all of the users, and also failed to re-test afterward. * Retain assertions for --enable-debug-tcg. r~ Richard Henderson (3): target/arm: Split out recompute_hflags et al target/arm: Rebuild hflags at el changes and MSR writes target/arm: Rely on hflags correct in cpu_get_tb_cpu_state target/arm/cpu.h | 22 ++- target/arm/helper.h | 3 + target/arm/internals.h | 4 + linux-user/syscall.c | 1 + target/arm/cpu.c | 1 + target/arm/helper-a64.c | 3 + target/arm/helper.c | 279 ++++++++++++++++++++++--------------- target/arm/machine.c | 1 + target/arm/op_helper.c | 1 + target/arm/translate-a64.c | 6 +- target/arm/translate.c | 14 +- 11 files changed, 216 insertions(+), 119 deletions(-) -- 2.17.1