| Message ID | 20190215192302.27855-1-richard.henderson@linaro.org |
|---|---|
| Headers | show |
| Series | target/arm: Implement ARMv8.3-JSConv & ARMv8.2-FHM | expand |
Patchew URL: https://patchew.org/QEMU/20190215192302.27855-1-richard.henderson@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190215192302.27855-1-richard.henderson@linaro.org
Subject: [Qemu-devel] [PATCH v4 0/8] target/arm: Implement ARMv8.3-JSConv & ARMv8.2-FHM
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/20190123103323.4516-1-stefanha@redhat.com -> patchew/20190123103323.4516-1-stefanha@redhat.com
* [new tag] patchew/20190215192302.27855-1-richard.henderson@linaro.org -> patchew/20190215192302.27855-1-richard.henderson@linaro.org
Switched to a new branch 'test'
48aad41d17 target/arm: Enable ARMv8.2-FHM for -cpu max
386bd84229 target/arm: Implement VFMAL and VFMSL for aarch32
bd511444da target/arm: Implement FMLAL and FMLSL for aarch64
320923b415 target/arm: Add helpers for FMLAL
5f16dc5cd4 target/arm: Implement ARMv8.3-JSConv
4e880a6881 target/arm: Rearrange Floating-point data-processing (2 regs)
ec64414896 target/arm: Split out vfp_helper.c
537337ef14 target/arm: Restructure disas_fp_int_conv
=== OUTPUT BEGIN ===
1/8 Checking commit 537337ef142f (target/arm: Restructure disas_fp_int_conv)
2/8 Checking commit ec64414896da (target/arm: Split out vfp_helper.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#1101:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#1133: FILE: target/arm/vfp_helper.c:28:
+/* VFP support. We follow the convention used for VFP instructions:
WARNING: Block comments use * on subsequent lines
#1134: FILE: target/arm/vfp_helper.c:29:
+/* VFP support. We follow the convention used for VFP instructions:
+ Single precision routines have a "s" suffix, double precision a
WARNING: Block comments use a trailing */ on a separate line
#1135: FILE: target/arm/vfp_helper.c:30:
+ "d" suffix. */
ERROR: braces {} are necessary for all arms of this statement
#1142: FILE: target/arm/vfp_helper.c:37:
+ if (host_bits & float_flag_invalid)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1144: FILE: target/arm/vfp_helper.c:39:
+ if (host_bits & float_flag_divbyzero)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1146: FILE: target/arm/vfp_helper.c:41:
+ if (host_bits & float_flag_overflow)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1148: FILE: target/arm/vfp_helper.c:43:
+ if (host_bits & (float_flag_underflow | float_flag_output_denormal))
[...]
ERROR: braces {} are necessary for all arms of this statement
#1150: FILE: target/arm/vfp_helper.c:45:
+ if (host_bits & float_flag_inexact)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1152: FILE: target/arm/vfp_helper.c:47:
+ if (host_bits & float_flag_input_denormal)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1188: FILE: target/arm/vfp_helper.c:83:
+ if (target_bits & 1)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1190: FILE: target/arm/vfp_helper.c:85:
+ if (target_bits & 2)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1192: FILE: target/arm/vfp_helper.c:87:
+ if (target_bits & 4)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1194: FILE: target/arm/vfp_helper.c:89:
+ if (target_bits & 8)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1196: FILE: target/arm/vfp_helper.c:91:
+ if (target_bits & 0x10)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1198: FILE: target/arm/vfp_helper.c:93:
+ if (target_bits & 0x80)
[...]
WARNING: Block comments use a leading /* on a separate line
#1270: FILE: target/arm/vfp_helper.c:165:
+ /* The exception flags are ORed together when we read fpscr so we
ERROR: space required after that ',' (ctx:VxV)
#1285: FILE: target/arm/vfp_helper.c:180:
+#define VFP_HELPER(name, p) HELPER(glue(glue(vfp_,name),p))
^
ERROR: space required after that ',' (ctx:VxV)
#1285: FILE: target/arm/vfp_helper.c:180:
+#define VFP_HELPER(name, p) HELPER(glue(glue(vfp_,name),p))
^
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#1287: FILE: target/arm/vfp_helper.c:182:
+#define VFP_BINOP(name) \
+float32 VFP_HELPER(name, s)(float32 a, float32 b, void *fpstp) \
+{ \
+ float_status *fpst = fpstp; \
+ return float32_ ## name(a, b, fpst); \
+} \
+float64 VFP_HELPER(name, d)(float64 a, float64 b, void *fpstp) \
+{ \
+ float_status *fpst = fpstp; \
+ return float64_ ## name(a, b, fpst); \
+}
ERROR: space prohibited before that close parenthesis ')'
#1399: FILE: target/arm/vfp_helper.c:294:
+ CONV_FTOI(vfp_to##name##p, ftype, fsz, sign, ) \
ERROR: space prohibited before that close parenthesis ')'
#1402: FILE: target/arm/vfp_helper.c:297:
+FLOAT_CONVS(si, h, uint32_t, 16, )
ERROR: space prohibited before that close parenthesis ')'
#1403: FILE: target/arm/vfp_helper.c:298:
+FLOAT_CONVS(si, s, float32, 32, )
ERROR: space prohibited before that close parenthesis ')'
#1404: FILE: target/arm/vfp_helper.c:299:
+FLOAT_CONVS(si, d, float64, 64, )
ERROR: space prohibited before that close parenthesis ')'
#1446: FILE: target/arm/vfp_helper.c:341:
+ get_float_rounding_mode(fpst), )
ERROR: space prohibited before that close parenthesis ')'
#1451: FILE: target/arm/vfp_helper.c:346:
+ get_float_rounding_mode(fpst), )
WARNING: Block comments use a leading /* on a separate line
#1551: FILE: target/arm/vfp_helper.c:446:
+/* Set the current fp rounding mode and return the old one.
WARNING: Block comments use a leading /* on a separate line
#1564: FILE: target/arm/vfp_helper.c:459:
+/* Set the current fp rounding mode in the standard fp status and return
WARNING: Block comments use a leading /* on a separate line
#1584: FILE: target/arm/vfp_helper.c:479:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1597: FILE: target/arm/vfp_helper.c:492:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1610: FILE: target/arm/vfp_helper.c:505:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1623: FILE: target/arm/vfp_helper.c:518:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1668: FILE: target/arm/vfp_helper.c:563:
+/* Constants 256 and 512 are used in some helpers; we avoid relying on
WARNING: Block comments use a trailing */ on a separate line
#1669: FILE: target/arm/vfp_helper.c:564:
+ * int->float conversions at run-time. */
WARNING: Block comments use a leading /* on a separate line
#1676: FILE: target/arm/vfp_helper.c:571:
+/* Reciprocal functions
WARNING: Block comments use a leading /* on a separate line
#1682: FILE: target/arm/vfp_helper.c:577:
+/* See RecipEstimate()
WARNING: Block comments use a leading /* on a separate line
#1902: FILE: target/arm/vfp_helper.c:797:
+/* The algorithm that must be used to calculate the estimate
WARNING: Block comments use a leading /* on a separate line
#1984: FILE: target/arm/vfp_helper.c:879:
+ /* Scale and normalize to a double-precision value between 0.25 and 1.0,
WARNING: Block comments use a trailing */ on a separate line
#1985: FILE: target/arm/vfp_helper.c:880:
+ * preserving the parity of the exponent. */
WARNING: Block comments use a leading /* on a separate line
#2028: FILE: target/arm/vfp_helper.c:923:
+ /* Scale and normalize to a double-precision value between 0.25 and 1.0,
WARNING: Block comments use a trailing */ on a separate line
#2029: FILE: target/arm/vfp_helper.c:924:
+ * preserving the parity of the exponent. */
total: 21 errors, 20 warnings, 2164 lines checked
Patch 2/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/8 Checking commit 4e880a68817d (target/arm: Rearrange Floating-point data-processing (2 regs))
4/8 Checking commit 5f16dc5cd4a4 (target/arm: Implement ARMv8.3-JSConv)
5/8 Checking commit 320923b41576 (target/arm: Add helpers for FMLAL)
6/8 Checking commit bd511444da88 (target/arm: Implement FMLAL and FMLSL for aarch64)
7/8 Checking commit 386bd8422967 (target/arm: Implement VFMAL and VFMSL for aarch32)
8/8 Checking commit 48aad41d17ed (target/arm: Enable ARMv8.2-FHM for -cpu max)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190215192302.27855-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190215192302.27855-1-richard.henderson@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190215192302.27855-1-richard.henderson@linaro.org
Subject: [Qemu-devel] [PATCH v4 0/8] target/arm: Implement ARMv8.3-JSConv & ARMv8.2-FHM
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20190123103323.4516-1-stefanha@redhat.com -> patchew/20190123103323.4516-1-stefanha@redhat.com
* [new tag] patchew/20190215192302.27855-1-richard.henderson@linaro.org -> patchew/20190215192302.27855-1-richard.henderson@linaro.org
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex'
Submodule 'tests/fp/berkeley-softfloat-3' (https://github.com/cota/berkeley-softfloat-3) registered for path 'tests/fp/berkeley-softfloat-3'
Submodule 'tests/fp/berkeley-testfloat-3' (https://github.com/cota/berkeley-testfloat-3) registered for path 'tests/fp/berkeley-testfloat-3'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out 'a5b428e1c1eae703bdd62a3f527223c291ee3fdc'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out '3464681b2b5983df80086a40179d324102347da3'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out '51c237d7e20d05100eacadee2f61abc17e6bc097'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 'a698c8995ffb2838296ec284fe3c4ad33dfca307'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out '1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
48aad41 target/arm: Enable ARMv8.2-FHM for -cpu max
386bd84 target/arm: Implement VFMAL and VFMSL for aarch32
bd51144 target/arm: Implement FMLAL and FMLSL for aarch64
320923b target/arm: Add helpers for FMLAL
5f16dc5 target/arm: Implement ARMv8.3-JSConv
4e880a6 target/arm: Rearrange Floating-point data-processing (2 regs)
ec64414 target/arm: Split out vfp_helper.c
537337e target/arm: Restructure disas_fp_int_conv
=== OUTPUT BEGIN ===
1/8 Checking commit 537337ef142f (target/arm: Restructure disas_fp_int_conv)
2/8 Checking commit ec64414896da (target/arm: Split out vfp_helper.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#1101:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#1133: FILE: target/arm/vfp_helper.c:28:
+/* VFP support. We follow the convention used for VFP instructions:
WARNING: Block comments use * on subsequent lines
#1134: FILE: target/arm/vfp_helper.c:29:
+/* VFP support. We follow the convention used for VFP instructions:
+ Single precision routines have a "s" suffix, double precision a
WARNING: Block comments use a trailing */ on a separate line
#1135: FILE: target/arm/vfp_helper.c:30:
+ "d" suffix. */
ERROR: braces {} are necessary for all arms of this statement
#1142: FILE: target/arm/vfp_helper.c:37:
+ if (host_bits & float_flag_invalid)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1144: FILE: target/arm/vfp_helper.c:39:
+ if (host_bits & float_flag_divbyzero)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1146: FILE: target/arm/vfp_helper.c:41:
+ if (host_bits & float_flag_overflow)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1148: FILE: target/arm/vfp_helper.c:43:
+ if (host_bits & (float_flag_underflow | float_flag_output_denormal))
[...]
ERROR: braces {} are necessary for all arms of this statement
#1150: FILE: target/arm/vfp_helper.c:45:
+ if (host_bits & float_flag_inexact)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1152: FILE: target/arm/vfp_helper.c:47:
+ if (host_bits & float_flag_input_denormal)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1188: FILE: target/arm/vfp_helper.c:83:
+ if (target_bits & 1)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1190: FILE: target/arm/vfp_helper.c:85:
+ if (target_bits & 2)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1192: FILE: target/arm/vfp_helper.c:87:
+ if (target_bits & 4)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1194: FILE: target/arm/vfp_helper.c:89:
+ if (target_bits & 8)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1196: FILE: target/arm/vfp_helper.c:91:
+ if (target_bits & 0x10)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1198: FILE: target/arm/vfp_helper.c:93:
+ if (target_bits & 0x80)
[...]
WARNING: Block comments use a leading /* on a separate line
#1270: FILE: target/arm/vfp_helper.c:165:
+ /* The exception flags are ORed together when we read fpscr so we
ERROR: space required after that ',' (ctx:VxV)
#1285: FILE: target/arm/vfp_helper.c:180:
+#define VFP_HELPER(name, p) HELPER(glue(glue(vfp_,name),p))
^
ERROR: space required after that ',' (ctx:VxV)
#1285: FILE: target/arm/vfp_helper.c:180:
+#define VFP_HELPER(name, p) HELPER(glue(glue(vfp_,name),p))
^
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#1287: FILE: target/arm/vfp_helper.c:182:
+#define VFP_BINOP(name) \
+float32 VFP_HELPER(name, s)(float32 a, float32 b, void *fpstp) \
+{ \
+ float_status *fpst = fpstp; \
+ return float32_ ## name(a, b, fpst); \
+} \
+float64 VFP_HELPER(name, d)(float64 a, float64 b, void *fpstp) \
+{ \
+ float_status *fpst = fpstp; \
+ return float64_ ## name(a, b, fpst); \
+}
ERROR: space prohibited before that close parenthesis ')'
#1399: FILE: target/arm/vfp_helper.c:294:
+ CONV_FTOI(vfp_to##name##p, ftype, fsz, sign, ) \
ERROR: space prohibited before that close parenthesis ')'
#1402: FILE: target/arm/vfp_helper.c:297:
+FLOAT_CONVS(si, h, uint32_t, 16, )
ERROR: space prohibited before that close parenthesis ')'
#1403: FILE: target/arm/vfp_helper.c:298:
+FLOAT_CONVS(si, s, float32, 32, )
ERROR: space prohibited before that close parenthesis ')'
#1404: FILE: target/arm/vfp_helper.c:299:
+FLOAT_CONVS(si, d, float64, 64, )
ERROR: space prohibited before that close parenthesis ')'
#1446: FILE: target/arm/vfp_helper.c:341:
+ get_float_rounding_mode(fpst), )
ERROR: space prohibited before that close parenthesis ')'
#1451: FILE: target/arm/vfp_helper.c:346:
+ get_float_rounding_mode(fpst), )
WARNING: Block comments use a leading /* on a separate line
#1551: FILE: target/arm/vfp_helper.c:446:
+/* Set the current fp rounding mode and return the old one.
WARNING: Block comments use a leading /* on a separate line
#1564: FILE: target/arm/vfp_helper.c:459:
+/* Set the current fp rounding mode in the standard fp status and return
WARNING: Block comments use a leading /* on a separate line
#1584: FILE: target/arm/vfp_helper.c:479:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1597: FILE: target/arm/vfp_helper.c:492:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1610: FILE: target/arm/vfp_helper.c:505:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1623: FILE: target/arm/vfp_helper.c:518:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1668: FILE: target/arm/vfp_helper.c:563:
+/* Constants 256 and 512 are used in some helpers; we avoid relying on
WARNING: Block comments use a trailing */ on a separate line
#1669: FILE: target/arm/vfp_helper.c:564:
+ * int->float conversions at run-time. */
WARNING: Block comments use a leading /* on a separate line
#1676: FILE: target/arm/vfp_helper.c:571:
+/* Reciprocal functions
WARNING: Block comments use a leading /* on a separate line
#1682: FILE: target/arm/vfp_helper.c:577:
+/* See RecipEstimate()
WARNING: Block comments use a leading /* on a separate line
#1902: FILE: target/arm/vfp_helper.c:797:
+/* The algorithm that must be used to calculate the estimate
WARNING: Block comments use a leading /* on a separate line
#1984: FILE: target/arm/vfp_helper.c:879:
+ /* Scale and normalize to a double-precision value between 0.25 and 1.0,
WARNING: Block comments use a trailing */ on a separate line
#1985: FILE: target/arm/vfp_helper.c:880:
+ * preserving the parity of the exponent. */
WARNING: Block comments use a leading /* on a separate line
#2028: FILE: target/arm/vfp_helper.c:923:
+ /* Scale and normalize to a double-precision value between 0.25 and 1.0,
WARNING: Block comments use a trailing */ on a separate line
#2029: FILE: target/arm/vfp_helper.c:924:
+ * preserving the parity of the exponent. */
total: 21 errors, 20 warnings, 2164 lines checked
Patch 2/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/8 Checking commit 4e880a68817d (target/arm: Rearrange Floating-point data-processing (2 regs))
4/8 Checking commit 5f16dc5cd4a4 (target/arm: Implement ARMv8.3-JSConv)
5/8 Checking commit 320923b41576 (target/arm: Add helpers for FMLAL)
6/8 Checking commit bd511444da88 (target/arm: Implement FMLAL and FMLSL for aarch64)
7/8 Checking commit 386bd8422967 (target/arm: Implement VFMAL and VFMSL for aarch32)
8/8 Checking commit 48aad41d17ed (target/arm: Enable ARMv8.2-FHM for -cpu max)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190215192302.27855-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190215192302.27855-1-richard.henderson@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190215192302.27855-1-richard.henderson@linaro.org
Subject: [Qemu-devel] [PATCH v4 0/8] target/arm: Implement ARMv8.3-JSConv & ARMv8.2-FHM
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
51dd832232 target/arm: Enable ARMv8.2-FHM for -cpu max
736c5e9e30 target/arm: Implement VFMAL and VFMSL for aarch32
b3f9f6a883 target/arm: Implement FMLAL and FMLSL for aarch64
cbf8a7e3d5 target/arm: Add helpers for FMLAL
4cb90fe69d target/arm: Implement ARMv8.3-JSConv
9cef9e67a2 target/arm: Rearrange Floating-point data-processing (2 regs)
6378838a3d target/arm: Split out vfp_helper.c
aead6fb4e1 target/arm: Restructure disas_fp_int_conv
=== OUTPUT BEGIN ===
1/8 Checking commit aead6fb4e175 (target/arm: Restructure disas_fp_int_conv)
2/8 Checking commit 6378838a3d44 (target/arm: Split out vfp_helper.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#1102:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#1134: FILE: target/arm/vfp_helper.c:28:
+/* VFP support. We follow the convention used for VFP instructions:
WARNING: Block comments use * on subsequent lines
#1135: FILE: target/arm/vfp_helper.c:29:
+/* VFP support. We follow the convention used for VFP instructions:
+ Single precision routines have a "s" suffix, double precision a
WARNING: Block comments use a trailing */ on a separate line
#1136: FILE: target/arm/vfp_helper.c:30:
+ "d" suffix. */
ERROR: braces {} are necessary for all arms of this statement
#1143: FILE: target/arm/vfp_helper.c:37:
+ if (host_bits & float_flag_invalid)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1145: FILE: target/arm/vfp_helper.c:39:
+ if (host_bits & float_flag_divbyzero)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1147: FILE: target/arm/vfp_helper.c:41:
+ if (host_bits & float_flag_overflow)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1149: FILE: target/arm/vfp_helper.c:43:
+ if (host_bits & (float_flag_underflow | float_flag_output_denormal))
[...]
ERROR: braces {} are necessary for all arms of this statement
#1151: FILE: target/arm/vfp_helper.c:45:
+ if (host_bits & float_flag_inexact)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1153: FILE: target/arm/vfp_helper.c:47:
+ if (host_bits & float_flag_input_denormal)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1189: FILE: target/arm/vfp_helper.c:83:
+ if (target_bits & 1)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1191: FILE: target/arm/vfp_helper.c:85:
+ if (target_bits & 2)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1193: FILE: target/arm/vfp_helper.c:87:
+ if (target_bits & 4)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1195: FILE: target/arm/vfp_helper.c:89:
+ if (target_bits & 8)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1197: FILE: target/arm/vfp_helper.c:91:
+ if (target_bits & 0x10)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1199: FILE: target/arm/vfp_helper.c:93:
+ if (target_bits & 0x80)
[...]
WARNING: Block comments use a leading /* on a separate line
#1271: FILE: target/arm/vfp_helper.c:165:
+ /* The exception flags are ORed together when we read fpscr so we
ERROR: space required after that ',' (ctx:VxV)
#1286: FILE: target/arm/vfp_helper.c:180:
+#define VFP_HELPER(name, p) HELPER(glue(glue(vfp_,name),p))
^
ERROR: space required after that ',' (ctx:VxV)
#1286: FILE: target/arm/vfp_helper.c:180:
+#define VFP_HELPER(name, p) HELPER(glue(glue(vfp_,name),p))
^
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#1288: FILE: target/arm/vfp_helper.c:182:
+#define VFP_BINOP(name) \
+float32 VFP_HELPER(name, s)(float32 a, float32 b, void *fpstp) \
+{ \
+ float_status *fpst = fpstp; \
+ return float32_ ## name(a, b, fpst); \
+} \
+float64 VFP_HELPER(name, d)(float64 a, float64 b, void *fpstp) \
+{ \
+ float_status *fpst = fpstp; \
+ return float64_ ## name(a, b, fpst); \
+}
ERROR: space prohibited before that close parenthesis ')'
#1400: FILE: target/arm/vfp_helper.c:294:
+ CONV_FTOI(vfp_to##name##p, ftype, fsz, sign, ) \
ERROR: space prohibited before that close parenthesis ')'
#1403: FILE: target/arm/vfp_helper.c:297:
+FLOAT_CONVS(si, h, uint32_t, 16, )
ERROR: space prohibited before that close parenthesis ')'
#1404: FILE: target/arm/vfp_helper.c:298:
+FLOAT_CONVS(si, s, float32, 32, )
ERROR: space prohibited before that close parenthesis ')'
#1405: FILE: target/arm/vfp_helper.c:299:
+FLOAT_CONVS(si, d, float64, 64, )
ERROR: space prohibited before that close parenthesis ')'
#1447: FILE: target/arm/vfp_helper.c:341:
+ get_float_rounding_mode(fpst), )
ERROR: space prohibited before that close parenthesis ')'
#1452: FILE: target/arm/vfp_helper.c:346:
+ get_float_rounding_mode(fpst), )
WARNING: Block comments use a leading /* on a separate line
#1552: FILE: target/arm/vfp_helper.c:446:
+/* Set the current fp rounding mode and return the old one.
WARNING: Block comments use a leading /* on a separate line
#1565: FILE: target/arm/vfp_helper.c:459:
+/* Set the current fp rounding mode in the standard fp status and return
WARNING: Block comments use a leading /* on a separate line
#1585: FILE: target/arm/vfp_helper.c:479:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1598: FILE: target/arm/vfp_helper.c:492:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1611: FILE: target/arm/vfp_helper.c:505:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1624: FILE: target/arm/vfp_helper.c:518:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1669: FILE: target/arm/vfp_helper.c:563:
+/* Constants 256 and 512 are used in some helpers; we avoid relying on
WARNING: Block comments use a trailing */ on a separate line
#1670: FILE: target/arm/vfp_helper.c:564:
+ * int->float conversions at run-time. */
WARNING: Block comments use a leading /* on a separate line
#1677: FILE: target/arm/vfp_helper.c:571:
+/* Reciprocal functions
WARNING: Block comments use a leading /* on a separate line
#1683: FILE: target/arm/vfp_helper.c:577:
+/* See RecipEstimate()
WARNING: Block comments use a leading /* on a separate line
#1903: FILE: target/arm/vfp_helper.c:797:
+/* The algorithm that must be used to calculate the estimate
WARNING: Block comments use a leading /* on a separate line
#1985: FILE: target/arm/vfp_helper.c:879:
+ /* Scale and normalize to a double-precision value between 0.25 and 1.0,
WARNING: Block comments use a trailing */ on a separate line
#1986: FILE: target/arm/vfp_helper.c:880:
+ * preserving the parity of the exponent. */
WARNING: Block comments use a leading /* on a separate line
#2029: FILE: target/arm/vfp_helper.c:923:
+ /* Scale and normalize to a double-precision value between 0.25 and 1.0,
WARNING: Block comments use a trailing */ on a separate line
#2030: FILE: target/arm/vfp_helper.c:924:
+ * preserving the parity of the exponent. */
total: 21 errors, 20 warnings, 2164 lines checked
Patch 2/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/8 Checking commit 9cef9e67a26e (target/arm: Rearrange Floating-point data-processing (2 regs))
4/8 Checking commit 4cb90fe69d5a (target/arm: Implement ARMv8.3-JSConv)
5/8 Checking commit cbf8a7e3d53f (target/arm: Add helpers for FMLAL)
6/8 Checking commit b3f9f6a883c6 (target/arm: Implement FMLAL and FMLSL for aarch64)
7/8 Checking commit 736c5e9e3077 (target/arm: Implement VFMAL and VFMSL for aarch32)
8/8 Checking commit 51dd832232a6 (target/arm: Enable ARMv8.2-FHM for -cpu max)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190215192302.27855-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190215192302.27855-1-richard.henderson@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190215192302.27855-1-richard.henderson@linaro.org
Subject: [Qemu-devel] [PATCH v4 0/8] target/arm: Implement ARMv8.3-JSConv & ARMv8.2-FHM
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20190215192302.27855-1-richard.henderson@linaro.org -> patchew/20190215192302.27855-1-richard.henderson@linaro.org
* [new tag] patchew/20190219153727.62279-1-stephen.checkoway@oberlin.edu -> patchew/20190219153727.62279-1-stephen.checkoway@oberlin.edu
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex'
Submodule 'tests/fp/berkeley-softfloat-3' (https://github.com/cota/berkeley-softfloat-3) registered for path 'tests/fp/berkeley-softfloat-3'
Submodule 'tests/fp/berkeley-testfloat-3' (https://github.com/cota/berkeley-testfloat-3) registered for path 'tests/fp/berkeley-testfloat-3'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out 'a5b428e1c1eae703bdd62a3f527223c291ee3fdc'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out '3464681b2b5983df80086a40179d324102347da3'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out '51c237d7e20d05100eacadee2f61abc17e6bc097'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 'a698c8995ffb2838296ec284fe3c4ad33dfca307'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out '1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
51dd832 target/arm: Enable ARMv8.2-FHM for -cpu max
736c5e9 target/arm: Implement VFMAL and VFMSL for aarch32
b3f9f6a target/arm: Implement FMLAL and FMLSL for aarch64
cbf8a7e target/arm: Add helpers for FMLAL
4cb90fe target/arm: Implement ARMv8.3-JSConv
9cef9e6 target/arm: Rearrange Floating-point data-processing (2 regs)
6378838 target/arm: Split out vfp_helper.c
aead6fb target/arm: Restructure disas_fp_int_conv
=== OUTPUT BEGIN ===
1/8 Checking commit aead6fb4e175 (target/arm: Restructure disas_fp_int_conv)
2/8 Checking commit 6378838a3d44 (target/arm: Split out vfp_helper.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#1102:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#1134: FILE: target/arm/vfp_helper.c:28:
+/* VFP support. We follow the convention used for VFP instructions:
WARNING: Block comments use * on subsequent lines
#1135: FILE: target/arm/vfp_helper.c:29:
+/* VFP support. We follow the convention used for VFP instructions:
+ Single precision routines have a "s" suffix, double precision a
WARNING: Block comments use a trailing */ on a separate line
#1136: FILE: target/arm/vfp_helper.c:30:
+ "d" suffix. */
ERROR: braces {} are necessary for all arms of this statement
#1143: FILE: target/arm/vfp_helper.c:37:
+ if (host_bits & float_flag_invalid)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1145: FILE: target/arm/vfp_helper.c:39:
+ if (host_bits & float_flag_divbyzero)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1147: FILE: target/arm/vfp_helper.c:41:
+ if (host_bits & float_flag_overflow)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1149: FILE: target/arm/vfp_helper.c:43:
+ if (host_bits & (float_flag_underflow | float_flag_output_denormal))
[...]
ERROR: braces {} are necessary for all arms of this statement
#1151: FILE: target/arm/vfp_helper.c:45:
+ if (host_bits & float_flag_inexact)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1153: FILE: target/arm/vfp_helper.c:47:
+ if (host_bits & float_flag_input_denormal)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1189: FILE: target/arm/vfp_helper.c:83:
+ if (target_bits & 1)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1191: FILE: target/arm/vfp_helper.c:85:
+ if (target_bits & 2)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1193: FILE: target/arm/vfp_helper.c:87:
+ if (target_bits & 4)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1195: FILE: target/arm/vfp_helper.c:89:
+ if (target_bits & 8)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1197: FILE: target/arm/vfp_helper.c:91:
+ if (target_bits & 0x10)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1199: FILE: target/arm/vfp_helper.c:93:
+ if (target_bits & 0x80)
[...]
WARNING: Block comments use a leading /* on a separate line
#1271: FILE: target/arm/vfp_helper.c:165:
+ /* The exception flags are ORed together when we read fpscr so we
ERROR: space required after that ',' (ctx:VxV)
#1286: FILE: target/arm/vfp_helper.c:180:
+#define VFP_HELPER(name, p) HELPER(glue(glue(vfp_,name),p))
^
ERROR: space required after that ',' (ctx:VxV)
#1286: FILE: target/arm/vfp_helper.c:180:
+#define VFP_HELPER(name, p) HELPER(glue(glue(vfp_,name),p))
^
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#1288: FILE: target/arm/vfp_helper.c:182:
+#define VFP_BINOP(name) \
+float32 VFP_HELPER(name, s)(float32 a, float32 b, void *fpstp) \
+{ \
+ float_status *fpst = fpstp; \
+ return float32_ ## name(a, b, fpst); \
+} \
+float64 VFP_HELPER(name, d)(float64 a, float64 b, void *fpstp) \
+{ \
+ float_status *fpst = fpstp; \
+ return float64_ ## name(a, b, fpst); \
+}
ERROR: space prohibited before that close parenthesis ')'
#1400: FILE: target/arm/vfp_helper.c:294:
+ CONV_FTOI(vfp_to##name##p, ftype, fsz, sign, ) \
ERROR: space prohibited before that close parenthesis ')'
#1403: FILE: target/arm/vfp_helper.c:297:
+FLOAT_CONVS(si, h, uint32_t, 16, )
ERROR: space prohibited before that close parenthesis ')'
#1404: FILE: target/arm/vfp_helper.c:298:
+FLOAT_CONVS(si, s, float32, 32, )
ERROR: space prohibited before that close parenthesis ')'
#1405: FILE: target/arm/vfp_helper.c:299:
+FLOAT_CONVS(si, d, float64, 64, )
ERROR: space prohibited before that close parenthesis ')'
#1447: FILE: target/arm/vfp_helper.c:341:
+ get_float_rounding_mode(fpst), )
ERROR: space prohibited before that close parenthesis ')'
#1452: FILE: target/arm/vfp_helper.c:346:
+ get_float_rounding_mode(fpst), )
WARNING: Block comments use a leading /* on a separate line
#1552: FILE: target/arm/vfp_helper.c:446:
+/* Set the current fp rounding mode and return the old one.
WARNING: Block comments use a leading /* on a separate line
#1565: FILE: target/arm/vfp_helper.c:459:
+/* Set the current fp rounding mode in the standard fp status and return
WARNING: Block comments use a leading /* on a separate line
#1585: FILE: target/arm/vfp_helper.c:479:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1598: FILE: target/arm/vfp_helper.c:492:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1611: FILE: target/arm/vfp_helper.c:505:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1624: FILE: target/arm/vfp_helper.c:518:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1669: FILE: target/arm/vfp_helper.c:563:
+/* Constants 256 and 512 are used in some helpers; we avoid relying on
WARNING: Block comments use a trailing */ on a separate line
#1670: FILE: target/arm/vfp_helper.c:564:
+ * int->float conversions at run-time. */
WARNING: Block comments use a leading /* on a separate line
#1677: FILE: target/arm/vfp_helper.c:571:
+/* Reciprocal functions
WARNING: Block comments use a leading /* on a separate line
#1683: FILE: target/arm/vfp_helper.c:577:
+/* See RecipEstimate()
WARNING: Block comments use a leading /* on a separate line
#1903: FILE: target/arm/vfp_helper.c:797:
+/* The algorithm that must be used to calculate the estimate
WARNING: Block comments use a leading /* on a separate line
#1985: FILE: target/arm/vfp_helper.c:879:
+ /* Scale and normalize to a double-precision value between 0.25 and 1.0,
WARNING: Block comments use a trailing */ on a separate line
#1986: FILE: target/arm/vfp_helper.c:880:
+ * preserving the parity of the exponent. */
WARNING: Block comments use a leading /* on a separate line
#2029: FILE: target/arm/vfp_helper.c:923:
+ /* Scale and normalize to a double-precision value between 0.25 and 1.0,
WARNING: Block comments use a trailing */ on a separate line
#2030: FILE: target/arm/vfp_helper.c:924:
+ * preserving the parity of the exponent. */
total: 21 errors, 20 warnings, 2164 lines checked
Patch 2/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/8 Checking commit 9cef9e67a26e (target/arm: Rearrange Floating-point data-processing (2 regs))
4/8 Checking commit 4cb90fe69d5a (target/arm: Implement ARMv8.3-JSConv)
5/8 Checking commit cbf8a7e3d53f (target/arm: Add helpers for FMLAL)
6/8 Checking commit b3f9f6a883c6 (target/arm: Implement FMLAL and FMLSL for aarch64)
7/8 Checking commit 736c5e9e3077 (target/arm: Implement VFMAL and VFMSL for aarch32)
8/8 Checking commit 51dd832232a6 (target/arm: Enable ARMv8.2-FHM for -cpu max)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190215192302.27855-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190215192302.27855-1-richard.henderson@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190215192302.27855-1-richard.henderson@linaro.org
Subject: [Qemu-devel] [PATCH v4 0/8] target/arm: Implement ARMv8.3-JSConv & ARMv8.2-FHM
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
eccbd527ca target/arm: Enable ARMv8.2-FHM for -cpu max
86326a505b target/arm: Implement VFMAL and VFMSL for aarch32
2ae450b769 target/arm: Implement FMLAL and FMLSL for aarch64
09e02de06d target/arm: Add helpers for FMLAL
ebc9d4e523 target/arm: Implement ARMv8.3-JSConv
f51742b4ab target/arm: Rearrange Floating-point data-processing (2 regs)
65a437834f target/arm: Split out vfp_helper.c
b83a695b43 target/arm: Restructure disas_fp_int_conv
=== OUTPUT BEGIN ===
1/8 Checking commit b83a695b4342 (target/arm: Restructure disas_fp_int_conv)
2/8 Checking commit 65a437834fac (target/arm: Split out vfp_helper.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#1102:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#1134: FILE: target/arm/vfp_helper.c:28:
+/* VFP support. We follow the convention used for VFP instructions:
WARNING: Block comments use * on subsequent lines
#1135: FILE: target/arm/vfp_helper.c:29:
+/* VFP support. We follow the convention used for VFP instructions:
+ Single precision routines have a "s" suffix, double precision a
WARNING: Block comments use a trailing */ on a separate line
#1136: FILE: target/arm/vfp_helper.c:30:
+ "d" suffix. */
ERROR: braces {} are necessary for all arms of this statement
#1143: FILE: target/arm/vfp_helper.c:37:
+ if (host_bits & float_flag_invalid)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1145: FILE: target/arm/vfp_helper.c:39:
+ if (host_bits & float_flag_divbyzero)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1147: FILE: target/arm/vfp_helper.c:41:
+ if (host_bits & float_flag_overflow)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1149: FILE: target/arm/vfp_helper.c:43:
+ if (host_bits & (float_flag_underflow | float_flag_output_denormal))
[...]
ERROR: braces {} are necessary for all arms of this statement
#1151: FILE: target/arm/vfp_helper.c:45:
+ if (host_bits & float_flag_inexact)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1153: FILE: target/arm/vfp_helper.c:47:
+ if (host_bits & float_flag_input_denormal)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1189: FILE: target/arm/vfp_helper.c:83:
+ if (target_bits & 1)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1191: FILE: target/arm/vfp_helper.c:85:
+ if (target_bits & 2)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1193: FILE: target/arm/vfp_helper.c:87:
+ if (target_bits & 4)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1195: FILE: target/arm/vfp_helper.c:89:
+ if (target_bits & 8)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1197: FILE: target/arm/vfp_helper.c:91:
+ if (target_bits & 0x10)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1199: FILE: target/arm/vfp_helper.c:93:
+ if (target_bits & 0x80)
[...]
WARNING: Block comments use a leading /* on a separate line
#1271: FILE: target/arm/vfp_helper.c:165:
+ /* The exception flags are ORed together when we read fpscr so we
ERROR: space required after that ',' (ctx:VxV)
#1286: FILE: target/arm/vfp_helper.c:180:
+#define VFP_HELPER(name, p) HELPER(glue(glue(vfp_,name),p))
^
ERROR: space required after that ',' (ctx:VxV)
#1286: FILE: target/arm/vfp_helper.c:180:
+#define VFP_HELPER(name, p) HELPER(glue(glue(vfp_,name),p))
^
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#1288: FILE: target/arm/vfp_helper.c:182:
+#define VFP_BINOP(name) \
+float32 VFP_HELPER(name, s)(float32 a, float32 b, void *fpstp) \
+{ \
+ float_status *fpst = fpstp; \
+ return float32_ ## name(a, b, fpst); \
+} \
+float64 VFP_HELPER(name, d)(float64 a, float64 b, void *fpstp) \
+{ \
+ float_status *fpst = fpstp; \
+ return float64_ ## name(a, b, fpst); \
+}
ERROR: space prohibited before that close parenthesis ')'
#1400: FILE: target/arm/vfp_helper.c:294:
+ CONV_FTOI(vfp_to##name##p, ftype, fsz, sign, ) \
ERROR: space prohibited before that close parenthesis ')'
#1403: FILE: target/arm/vfp_helper.c:297:
+FLOAT_CONVS(si, h, uint32_t, 16, )
ERROR: space prohibited before that close parenthesis ')'
#1404: FILE: target/arm/vfp_helper.c:298:
+FLOAT_CONVS(si, s, float32, 32, )
ERROR: space prohibited before that close parenthesis ')'
#1405: FILE: target/arm/vfp_helper.c:299:
+FLOAT_CONVS(si, d, float64, 64, )
ERROR: space prohibited before that close parenthesis ')'
#1447: FILE: target/arm/vfp_helper.c:341:
+ get_float_rounding_mode(fpst), )
ERROR: space prohibited before that close parenthesis ')'
#1452: FILE: target/arm/vfp_helper.c:346:
+ get_float_rounding_mode(fpst), )
WARNING: Block comments use a leading /* on a separate line
#1552: FILE: target/arm/vfp_helper.c:446:
+/* Set the current fp rounding mode and return the old one.
WARNING: Block comments use a leading /* on a separate line
#1565: FILE: target/arm/vfp_helper.c:459:
+/* Set the current fp rounding mode in the standard fp status and return
WARNING: Block comments use a leading /* on a separate line
#1585: FILE: target/arm/vfp_helper.c:479:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1598: FILE: target/arm/vfp_helper.c:492:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1611: FILE: target/arm/vfp_helper.c:505:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1624: FILE: target/arm/vfp_helper.c:518:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1669: FILE: target/arm/vfp_helper.c:563:
+/* Constants 256 and 512 are used in some helpers; we avoid relying on
WARNING: Block comments use a trailing */ on a separate line
#1670: FILE: target/arm/vfp_helper.c:564:
+ * int->float conversions at run-time. */
WARNING: Block comments use a leading /* on a separate line
#1677: FILE: target/arm/vfp_helper.c:571:
+/* Reciprocal functions
WARNING: Block comments use a leading /* on a separate line
#1683: FILE: target/arm/vfp_helper.c:577:
+/* See RecipEstimate()
WARNING: Block comments use a leading /* on a separate line
#1903: FILE: target/arm/vfp_helper.c:797:
+/* The algorithm that must be used to calculate the estimate
WARNING: Block comments use a leading /* on a separate line
#1985: FILE: target/arm/vfp_helper.c:879:
+ /* Scale and normalize to a double-precision value between 0.25 and 1.0,
WARNING: Block comments use a trailing */ on a separate line
#1986: FILE: target/arm/vfp_helper.c:880:
+ * preserving the parity of the exponent. */
WARNING: Block comments use a leading /* on a separate line
#2029: FILE: target/arm/vfp_helper.c:923:
+ /* Scale and normalize to a double-precision value between 0.25 and 1.0,
WARNING: Block comments use a trailing */ on a separate line
#2030: FILE: target/arm/vfp_helper.c:924:
+ * preserving the parity of the exponent. */
total: 21 errors, 20 warnings, 2164 lines checked
Patch 2/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/8 Checking commit f51742b4abf6 (target/arm: Rearrange Floating-point data-processing (2 regs))
4/8 Checking commit ebc9d4e5231b (target/arm: Implement ARMv8.3-JSConv)
5/8 Checking commit 09e02de06d1f (target/arm: Add helpers for FMLAL)
6/8 Checking commit 2ae450b76917 (target/arm: Implement FMLAL and FMLSL for aarch64)
7/8 Checking commit 86326a505b6d (target/arm: Implement VFMAL and VFMSL for aarch32)
8/8 Checking commit eccbd527cae1 (target/arm: Enable ARMv8.2-FHM for -cpu max)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190215192302.27855-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190215192302.27855-1-richard.henderson@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190215192302.27855-1-richard.henderson@linaro.org
Subject: [Qemu-devel] [PATCH v4 0/8] target/arm: Implement ARMv8.3-JSConv & ARMv8.2-FHM
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20190215192302.27855-1-richard.henderson@linaro.org -> patchew/20190215192302.27855-1-richard.henderson@linaro.org
- [tag update] patchew/20190219161321.15012-1-berrange@redhat.com -> patchew/20190219161321.15012-1-berrange@redhat.com
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex'
Submodule 'tests/fp/berkeley-softfloat-3' (https://github.com/cota/berkeley-softfloat-3) registered for path 'tests/fp/berkeley-softfloat-3'
Submodule 'tests/fp/berkeley-testfloat-3' (https://github.com/cota/berkeley-testfloat-3) registered for path 'tests/fp/berkeley-testfloat-3'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out 'a5b428e1c1eae703bdd62a3f527223c291ee3fdc'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out '3464681b2b5983df80086a40179d324102347da3'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out '51c237d7e20d05100eacadee2f61abc17e6bc097'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 'a698c8995ffb2838296ec284fe3c4ad33dfca307'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out '1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
eccbd52 target/arm: Enable ARMv8.2-FHM for -cpu max
86326a5 target/arm: Implement VFMAL and VFMSL for aarch32
2ae450b target/arm: Implement FMLAL and FMLSL for aarch64
09e02de target/arm: Add helpers for FMLAL
ebc9d4e target/arm: Implement ARMv8.3-JSConv
f51742b target/arm: Rearrange Floating-point data-processing (2 regs)
65a4378 target/arm: Split out vfp_helper.c
b83a695 target/arm: Restructure disas_fp_int_conv
=== OUTPUT BEGIN ===
1/8 Checking commit b83a695b4342 (target/arm: Restructure disas_fp_int_conv)
2/8 Checking commit 65a437834fac (target/arm: Split out vfp_helper.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#1102:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#1134: FILE: target/arm/vfp_helper.c:28:
+/* VFP support. We follow the convention used for VFP instructions:
WARNING: Block comments use * on subsequent lines
#1135: FILE: target/arm/vfp_helper.c:29:
+/* VFP support. We follow the convention used for VFP instructions:
+ Single precision routines have a "s" suffix, double precision a
WARNING: Block comments use a trailing */ on a separate line
#1136: FILE: target/arm/vfp_helper.c:30:
+ "d" suffix. */
ERROR: braces {} are necessary for all arms of this statement
#1143: FILE: target/arm/vfp_helper.c:37:
+ if (host_bits & float_flag_invalid)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1145: FILE: target/arm/vfp_helper.c:39:
+ if (host_bits & float_flag_divbyzero)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1147: FILE: target/arm/vfp_helper.c:41:
+ if (host_bits & float_flag_overflow)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1149: FILE: target/arm/vfp_helper.c:43:
+ if (host_bits & (float_flag_underflow | float_flag_output_denormal))
[...]
ERROR: braces {} are necessary for all arms of this statement
#1151: FILE: target/arm/vfp_helper.c:45:
+ if (host_bits & float_flag_inexact)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1153: FILE: target/arm/vfp_helper.c:47:
+ if (host_bits & float_flag_input_denormal)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1189: FILE: target/arm/vfp_helper.c:83:
+ if (target_bits & 1)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1191: FILE: target/arm/vfp_helper.c:85:
+ if (target_bits & 2)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1193: FILE: target/arm/vfp_helper.c:87:
+ if (target_bits & 4)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1195: FILE: target/arm/vfp_helper.c:89:
+ if (target_bits & 8)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1197: FILE: target/arm/vfp_helper.c:91:
+ if (target_bits & 0x10)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1199: FILE: target/arm/vfp_helper.c:93:
+ if (target_bits & 0x80)
[...]
WARNING: Block comments use a leading /* on a separate line
#1271: FILE: target/arm/vfp_helper.c:165:
+ /* The exception flags are ORed together when we read fpscr so we
ERROR: space required after that ',' (ctx:VxV)
#1286: FILE: target/arm/vfp_helper.c:180:
+#define VFP_HELPER(name, p) HELPER(glue(glue(vfp_,name),p))
^
ERROR: space required after that ',' (ctx:VxV)
#1286: FILE: target/arm/vfp_helper.c:180:
+#define VFP_HELPER(name, p) HELPER(glue(glue(vfp_,name),p))
^
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#1288: FILE: target/arm/vfp_helper.c:182:
+#define VFP_BINOP(name) \
+float32 VFP_HELPER(name, s)(float32 a, float32 b, void *fpstp) \
+{ \
+ float_status *fpst = fpstp; \
+ return float32_ ## name(a, b, fpst); \
+} \
+float64 VFP_HELPER(name, d)(float64 a, float64 b, void *fpstp) \
+{ \
+ float_status *fpst = fpstp; \
+ return float64_ ## name(a, b, fpst); \
+}
ERROR: space prohibited before that close parenthesis ')'
#1400: FILE: target/arm/vfp_helper.c:294:
+ CONV_FTOI(vfp_to##name##p, ftype, fsz, sign, ) \
ERROR: space prohibited before that close parenthesis ')'
#1403: FILE: target/arm/vfp_helper.c:297:
+FLOAT_CONVS(si, h, uint32_t, 16, )
ERROR: space prohibited before that close parenthesis ')'
#1404: FILE: target/arm/vfp_helper.c:298:
+FLOAT_CONVS(si, s, float32, 32, )
ERROR: space prohibited before that close parenthesis ')'
#1405: FILE: target/arm/vfp_helper.c:299:
+FLOAT_CONVS(si, d, float64, 64, )
ERROR: space prohibited before that close parenthesis ')'
#1447: FILE: target/arm/vfp_helper.c:341:
+ get_float_rounding_mode(fpst), )
ERROR: space prohibited before that close parenthesis ')'
#1452: FILE: target/arm/vfp_helper.c:346:
+ get_float_rounding_mode(fpst), )
WARNING: Block comments use a leading /* on a separate line
#1552: FILE: target/arm/vfp_helper.c:446:
+/* Set the current fp rounding mode and return the old one.
WARNING: Block comments use a leading /* on a separate line
#1565: FILE: target/arm/vfp_helper.c:459:
+/* Set the current fp rounding mode in the standard fp status and return
WARNING: Block comments use a leading /* on a separate line
#1585: FILE: target/arm/vfp_helper.c:479:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1598: FILE: target/arm/vfp_helper.c:492:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1611: FILE: target/arm/vfp_helper.c:505:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1624: FILE: target/arm/vfp_helper.c:518:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1669: FILE: target/arm/vfp_helper.c:563:
+/* Constants 256 and 512 are used in some helpers; we avoid relying on
WARNING: Block comments use a trailing */ on a separate line
#1670: FILE: target/arm/vfp_helper.c:564:
+ * int->float conversions at run-time. */
WARNING: Block comments use a leading /* on a separate line
#1677: FILE: target/arm/vfp_helper.c:571:
+/* Reciprocal functions
WARNING: Block comments use a leading /* on a separate line
#1683: FILE: target/arm/vfp_helper.c:577:
+/* See RecipEstimate()
WARNING: Block comments use a leading /* on a separate line
#1903: FILE: target/arm/vfp_helper.c:797:
+/* The algorithm that must be used to calculate the estimate
WARNING: Block comments use a leading /* on a separate line
#1985: FILE: target/arm/vfp_helper.c:879:
+ /* Scale and normalize to a double-precision value between 0.25 and 1.0,
WARNING: Block comments use a trailing */ on a separate line
#1986: FILE: target/arm/vfp_helper.c:880:
+ * preserving the parity of the exponent. */
WARNING: Block comments use a leading /* on a separate line
#2029: FILE: target/arm/vfp_helper.c:923:
+ /* Scale and normalize to a double-precision value between 0.25 and 1.0,
WARNING: Block comments use a trailing */ on a separate line
#2030: FILE: target/arm/vfp_helper.c:924:
+ * preserving the parity of the exponent. */
total: 21 errors, 20 warnings, 2164 lines checked
Patch 2/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/8 Checking commit f51742b4abf6 (target/arm: Rearrange Floating-point data-processing (2 regs))
4/8 Checking commit ebc9d4e5231b (target/arm: Implement ARMv8.3-JSConv)
5/8 Checking commit 09e02de06d1f (target/arm: Add helpers for FMLAL)
6/8 Checking commit 2ae450b76917 (target/arm: Implement FMLAL and FMLSL for aarch64)
7/8 Checking commit 86326a505b6d (target/arm: Implement VFMAL and VFMSL for aarch32)
8/8 Checking commit eccbd527cae1 (target/arm: Enable ARMv8.2-FHM for -cpu max)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190215192302.27855-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On Fri, 15 Feb 2019 at 19:23, Richard Henderson <richard.henderson@linaro.org> wrote: > > > Changes since v3: > > Rebased on master, and combined the JSConv and FHM patch sets. > There were a number of patch conflicts which needed fixing up. > > Changes since v2: > > Patch 2 splits out vfp_helper.c, which I wrote for something else. > But while rebasing it occured to me that helper_vjcvt is better placed > in vfp_helper.c than op_helper.c, so why not include it here and now. > > Patch 3 corresponds to the v2 patch 1, but totally rewritten. What > I missed the first time around is that register Sn is encoded differenly > than Dn, so merely setting dp = 0 doesn't help because we've already > decoded the register number incorrectly. Therefore, replace some really > ugly if conditions and set some variables as appropriate. > > Patch 4 is adjusted to match the change in decode from patch 2, and > putting the aa32 flags in the right place. I've applied patches 1-4 to target-arm.next; patches 5, 6, 8 I've commented on. 7 I'll leave until you've dealt with the fpstatus stuff in your next version of the patchset. thanks -- PMM
Patchew URL: https://patchew.org/QEMU/20190215192302.27855-1-richard.henderson@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190215192302.27855-1-richard.henderson@linaro.org
Subject: [Qemu-devel] [PATCH v4 0/8] target/arm: Implement ARMv8.3-JSConv & ARMv8.2-FHM
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/20190215192302.27855-1-richard.henderson@linaro.org -> patchew/20190215192302.27855-1-richard.henderson@linaro.org
Switched to a new branch 'test'
0ff65a844d target/arm: Enable ARMv8.2-FHM for -cpu max
ad1df52ee0 target/arm: Implement VFMAL and VFMSL for aarch32
5f63a9cb31 target/arm: Implement FMLAL and FMLSL for aarch64
b188cbbcba target/arm: Add helpers for FMLAL
e6e668123e target/arm: Implement ARMv8.3-JSConv
0234b531fe target/arm: Rearrange Floating-point data-processing (2 regs)
04c91ee51e target/arm: Split out vfp_helper.c
037d4059a2 target/arm: Restructure disas_fp_int_conv
=== OUTPUT BEGIN ===
1/8 Checking commit 037d4059a225 (target/arm: Restructure disas_fp_int_conv)
2/8 Checking commit 04c91ee51e3c (target/arm: Split out vfp_helper.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#1102:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#1134: FILE: target/arm/vfp_helper.c:28:
+/* VFP support. We follow the convention used for VFP instructions:
WARNING: Block comments use * on subsequent lines
#1135: FILE: target/arm/vfp_helper.c:29:
+/* VFP support. We follow the convention used for VFP instructions:
+ Single precision routines have a "s" suffix, double precision a
WARNING: Block comments use a trailing */ on a separate line
#1136: FILE: target/arm/vfp_helper.c:30:
+ "d" suffix. */
ERROR: braces {} are necessary for all arms of this statement
#1143: FILE: target/arm/vfp_helper.c:37:
+ if (host_bits & float_flag_invalid)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1145: FILE: target/arm/vfp_helper.c:39:
+ if (host_bits & float_flag_divbyzero)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1147: FILE: target/arm/vfp_helper.c:41:
+ if (host_bits & float_flag_overflow)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1149: FILE: target/arm/vfp_helper.c:43:
+ if (host_bits & (float_flag_underflow | float_flag_output_denormal))
[...]
ERROR: braces {} are necessary for all arms of this statement
#1151: FILE: target/arm/vfp_helper.c:45:
+ if (host_bits & float_flag_inexact)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1153: FILE: target/arm/vfp_helper.c:47:
+ if (host_bits & float_flag_input_denormal)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1189: FILE: target/arm/vfp_helper.c:83:
+ if (target_bits & 1)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1191: FILE: target/arm/vfp_helper.c:85:
+ if (target_bits & 2)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1193: FILE: target/arm/vfp_helper.c:87:
+ if (target_bits & 4)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1195: FILE: target/arm/vfp_helper.c:89:
+ if (target_bits & 8)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1197: FILE: target/arm/vfp_helper.c:91:
+ if (target_bits & 0x10)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1199: FILE: target/arm/vfp_helper.c:93:
+ if (target_bits & 0x80)
[...]
WARNING: Block comments use a leading /* on a separate line
#1271: FILE: target/arm/vfp_helper.c:165:
+ /* The exception flags are ORed together when we read fpscr so we
ERROR: space required after that ',' (ctx:VxV)
#1286: FILE: target/arm/vfp_helper.c:180:
+#define VFP_HELPER(name, p) HELPER(glue(glue(vfp_,name),p))
^
ERROR: space required after that ',' (ctx:VxV)
#1286: FILE: target/arm/vfp_helper.c:180:
+#define VFP_HELPER(name, p) HELPER(glue(glue(vfp_,name),p))
^
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#1288: FILE: target/arm/vfp_helper.c:182:
+#define VFP_BINOP(name) \
+float32 VFP_HELPER(name, s)(float32 a, float32 b, void *fpstp) \
+{ \
+ float_status *fpst = fpstp; \
+ return float32_ ## name(a, b, fpst); \
+} \
+float64 VFP_HELPER(name, d)(float64 a, float64 b, void *fpstp) \
+{ \
+ float_status *fpst = fpstp; \
+ return float64_ ## name(a, b, fpst); \
+}
ERROR: space prohibited before that close parenthesis ')'
#1400: FILE: target/arm/vfp_helper.c:294:
+ CONV_FTOI(vfp_to##name##p, ftype, fsz, sign, ) \
ERROR: space prohibited before that close parenthesis ')'
#1403: FILE: target/arm/vfp_helper.c:297:
+FLOAT_CONVS(si, h, uint32_t, 16, )
ERROR: space prohibited before that close parenthesis ')'
#1404: FILE: target/arm/vfp_helper.c:298:
+FLOAT_CONVS(si, s, float32, 32, )
ERROR: space prohibited before that close parenthesis ')'
#1405: FILE: target/arm/vfp_helper.c:299:
+FLOAT_CONVS(si, d, float64, 64, )
ERROR: space prohibited before that close parenthesis ')'
#1447: FILE: target/arm/vfp_helper.c:341:
+ get_float_rounding_mode(fpst), )
ERROR: space prohibited before that close parenthesis ')'
#1452: FILE: target/arm/vfp_helper.c:346:
+ get_float_rounding_mode(fpst), )
WARNING: Block comments use a leading /* on a separate line
#1552: FILE: target/arm/vfp_helper.c:446:
+/* Set the current fp rounding mode and return the old one.
WARNING: Block comments use a leading /* on a separate line
#1565: FILE: target/arm/vfp_helper.c:459:
+/* Set the current fp rounding mode in the standard fp status and return
WARNING: Block comments use a leading /* on a separate line
#1585: FILE: target/arm/vfp_helper.c:479:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1598: FILE: target/arm/vfp_helper.c:492:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1611: FILE: target/arm/vfp_helper.c:505:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1624: FILE: target/arm/vfp_helper.c:518:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1669: FILE: target/arm/vfp_helper.c:563:
+/* Constants 256 and 512 are used in some helpers; we avoid relying on
WARNING: Block comments use a trailing */ on a separate line
#1670: FILE: target/arm/vfp_helper.c:564:
+ * int->float conversions at run-time. */
WARNING: Block comments use a leading /* on a separate line
#1677: FILE: target/arm/vfp_helper.c:571:
+/* Reciprocal functions
WARNING: Block comments use a leading /* on a separate line
#1683: FILE: target/arm/vfp_helper.c:577:
+/* See RecipEstimate()
WARNING: Block comments use a leading /* on a separate line
#1903: FILE: target/arm/vfp_helper.c:797:
+/* The algorithm that must be used to calculate the estimate
WARNING: Block comments use a leading /* on a separate line
#1985: FILE: target/arm/vfp_helper.c:879:
+ /* Scale and normalize to a double-precision value between 0.25 and 1.0,
WARNING: Block comments use a trailing */ on a separate line
#1986: FILE: target/arm/vfp_helper.c:880:
+ * preserving the parity of the exponent. */
WARNING: Block comments use a leading /* on a separate line
#2029: FILE: target/arm/vfp_helper.c:923:
+ /* Scale and normalize to a double-precision value between 0.25 and 1.0,
WARNING: Block comments use a trailing */ on a separate line
#2030: FILE: target/arm/vfp_helper.c:924:
+ * preserving the parity of the exponent. */
total: 21 errors, 20 warnings, 2164 lines checked
Patch 2/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/8 Checking commit 0234b531feac (target/arm: Rearrange Floating-point data-processing (2 regs))
4/8 Checking commit e6e668123e72 (target/arm: Implement ARMv8.3-JSConv)
5/8 Checking commit b188cbbcba44 (target/arm: Add helpers for FMLAL)
6/8 Checking commit 5f63a9cb31aa (target/arm: Implement FMLAL and FMLSL for aarch64)
7/8 Checking commit ad1df52ee03e (target/arm: Implement VFMAL and VFMSL for aarch32)
8/8 Checking commit 0ff65a844d2c (target/arm: Enable ARMv8.2-FHM for -cpu max)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190215192302.27855-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190215192302.27855-1-richard.henderson@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190215192302.27855-1-richard.henderson@linaro.org
Subject: [Qemu-devel] [PATCH v4 0/8] target/arm: Implement ARMv8.3-JSConv & ARMv8.2-FHM
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20190215192302.27855-1-richard.henderson@linaro.org -> patchew/20190215192302.27855-1-richard.henderson@linaro.org
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex'
Submodule 'tests/fp/berkeley-softfloat-3' (https://github.com/cota/berkeley-softfloat-3) registered for path 'tests/fp/berkeley-softfloat-3'
Submodule 'tests/fp/berkeley-testfloat-3' (https://github.com/cota/berkeley-testfloat-3) registered for path 'tests/fp/berkeley-testfloat-3'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out 'a5b428e1c1eae703bdd62a3f527223c291ee3fdc'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out '3464681b2b5983df80086a40179d324102347da3'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out '51c237d7e20d05100eacadee2f61abc17e6bc097'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 'a698c8995ffb2838296ec284fe3c4ad33dfca307'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out '1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
0ff65a8 target/arm: Enable ARMv8.2-FHM for -cpu max
ad1df52 target/arm: Implement VFMAL and VFMSL for aarch32
5f63a9c target/arm: Implement FMLAL and FMLSL for aarch64
b188cbb target/arm: Add helpers for FMLAL
e6e6681 target/arm: Implement ARMv8.3-JSConv
0234b53 target/arm: Rearrange Floating-point data-processing (2 regs)
04c91ee target/arm: Split out vfp_helper.c
037d405 target/arm: Restructure disas_fp_int_conv
=== OUTPUT BEGIN ===
1/8 Checking commit 037d4059a225 (target/arm: Restructure disas_fp_int_conv)
2/8 Checking commit 04c91ee51e3c (target/arm: Split out vfp_helper.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#1102:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#1134: FILE: target/arm/vfp_helper.c:28:
+/* VFP support. We follow the convention used for VFP instructions:
WARNING: Block comments use * on subsequent lines
#1135: FILE: target/arm/vfp_helper.c:29:
+/* VFP support. We follow the convention used for VFP instructions:
+ Single precision routines have a "s" suffix, double precision a
WARNING: Block comments use a trailing */ on a separate line
#1136: FILE: target/arm/vfp_helper.c:30:
+ "d" suffix. */
ERROR: braces {} are necessary for all arms of this statement
#1143: FILE: target/arm/vfp_helper.c:37:
+ if (host_bits & float_flag_invalid)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1145: FILE: target/arm/vfp_helper.c:39:
+ if (host_bits & float_flag_divbyzero)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1147: FILE: target/arm/vfp_helper.c:41:
+ if (host_bits & float_flag_overflow)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1149: FILE: target/arm/vfp_helper.c:43:
+ if (host_bits & (float_flag_underflow | float_flag_output_denormal))
[...]
ERROR: braces {} are necessary for all arms of this statement
#1151: FILE: target/arm/vfp_helper.c:45:
+ if (host_bits & float_flag_inexact)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1153: FILE: target/arm/vfp_helper.c:47:
+ if (host_bits & float_flag_input_denormal)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1189: FILE: target/arm/vfp_helper.c:83:
+ if (target_bits & 1)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1191: FILE: target/arm/vfp_helper.c:85:
+ if (target_bits & 2)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1193: FILE: target/arm/vfp_helper.c:87:
+ if (target_bits & 4)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1195: FILE: target/arm/vfp_helper.c:89:
+ if (target_bits & 8)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1197: FILE: target/arm/vfp_helper.c:91:
+ if (target_bits & 0x10)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1199: FILE: target/arm/vfp_helper.c:93:
+ if (target_bits & 0x80)
[...]
WARNING: Block comments use a leading /* on a separate line
#1271: FILE: target/arm/vfp_helper.c:165:
+ /* The exception flags are ORed together when we read fpscr so we
ERROR: space required after that ',' (ctx:VxV)
#1286: FILE: target/arm/vfp_helper.c:180:
+#define VFP_HELPER(name, p) HELPER(glue(glue(vfp_,name),p))
^
ERROR: space required after that ',' (ctx:VxV)
#1286: FILE: target/arm/vfp_helper.c:180:
+#define VFP_HELPER(name, p) HELPER(glue(glue(vfp_,name),p))
^
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#1288: FILE: target/arm/vfp_helper.c:182:
+#define VFP_BINOP(name) \
+float32 VFP_HELPER(name, s)(float32 a, float32 b, void *fpstp) \
+{ \
+ float_status *fpst = fpstp; \
+ return float32_ ## name(a, b, fpst); \
+} \
+float64 VFP_HELPER(name, d)(float64 a, float64 b, void *fpstp) \
+{ \
+ float_status *fpst = fpstp; \
+ return float64_ ## name(a, b, fpst); \
+}
ERROR: space prohibited before that close parenthesis ')'
#1400: FILE: target/arm/vfp_helper.c:294:
+ CONV_FTOI(vfp_to##name##p, ftype, fsz, sign, ) \
ERROR: space prohibited before that close parenthesis ')'
#1403: FILE: target/arm/vfp_helper.c:297:
+FLOAT_CONVS(si, h, uint32_t, 16, )
ERROR: space prohibited before that close parenthesis ')'
#1404: FILE: target/arm/vfp_helper.c:298:
+FLOAT_CONVS(si, s, float32, 32, )
ERROR: space prohibited before that close parenthesis ')'
#1405: FILE: target/arm/vfp_helper.c:299:
+FLOAT_CONVS(si, d, float64, 64, )
ERROR: space prohibited before that close parenthesis ')'
#1447: FILE: target/arm/vfp_helper.c:341:
+ get_float_rounding_mode(fpst), )
ERROR: space prohibited before that close parenthesis ')'
#1452: FILE: target/arm/vfp_helper.c:346:
+ get_float_rounding_mode(fpst), )
WARNING: Block comments use a leading /* on a separate line
#1552: FILE: target/arm/vfp_helper.c:446:
+/* Set the current fp rounding mode and return the old one.
WARNING: Block comments use a leading /* on a separate line
#1565: FILE: target/arm/vfp_helper.c:459:
+/* Set the current fp rounding mode in the standard fp status and return
WARNING: Block comments use a leading /* on a separate line
#1585: FILE: target/arm/vfp_helper.c:479:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1598: FILE: target/arm/vfp_helper.c:492:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1611: FILE: target/arm/vfp_helper.c:505:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1624: FILE: target/arm/vfp_helper.c:518:
+ /* Squash FZ16 to 0 for the duration of conversion. In this case,
WARNING: Block comments use a leading /* on a separate line
#1669: FILE: target/arm/vfp_helper.c:563:
+/* Constants 256 and 512 are used in some helpers; we avoid relying on
WARNING: Block comments use a trailing */ on a separate line
#1670: FILE: target/arm/vfp_helper.c:564:
+ * int->float conversions at run-time. */
WARNING: Block comments use a leading /* on a separate line
#1677: FILE: target/arm/vfp_helper.c:571:
+/* Reciprocal functions
WARNING: Block comments use a leading /* on a separate line
#1683: FILE: target/arm/vfp_helper.c:577:
+/* See RecipEstimate()
WARNING: Block comments use a leading /* on a separate line
#1903: FILE: target/arm/vfp_helper.c:797:
+/* The algorithm that must be used to calculate the estimate
WARNING: Block comments use a leading /* on a separate line
#1985: FILE: target/arm/vfp_helper.c:879:
+ /* Scale and normalize to a double-precision value between 0.25 and 1.0,
WARNING: Block comments use a trailing */ on a separate line
#1986: FILE: target/arm/vfp_helper.c:880:
+ * preserving the parity of the exponent. */
WARNING: Block comments use a leading /* on a separate line
#2029: FILE: target/arm/vfp_helper.c:923:
+ /* Scale and normalize to a double-precision value between 0.25 and 1.0,
WARNING: Block comments use a trailing */ on a separate line
#2030: FILE: target/arm/vfp_helper.c:924:
+ * preserving the parity of the exponent. */
total: 21 errors, 20 warnings, 2164 lines checked
Patch 2/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/8 Checking commit 0234b531feac (target/arm: Rearrange Floating-point data-processing (2 regs))
4/8 Checking commit e6e668123e72 (target/arm: Implement ARMv8.3-JSConv)
5/8 Checking commit b188cbbcba44 (target/arm: Add helpers for FMLAL)
6/8 Checking commit 5f63a9cb31aa (target/arm: Implement FMLAL and FMLSL for aarch64)
7/8 Checking commit ad1df52ee03e (target/arm: Implement VFMAL and VFMSL for aarch32)
8/8 Checking commit 0ff65a844d2c (target/arm: Enable ARMv8.2-FHM for -cpu max)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190215192302.27855-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com