| Message ID | 20190212045721.28041-1-richard.henderson@linaro.org |
|---|---|
| Headers | show |
| Series | target/hppa patch queue | expand |
On Tue, 12 Feb 2019 at 04:57, Richard Henderson <richard.henderson@linaro.org> wrote: > > The following changes since commit 22c5f446514a2a4bb0dbe1fea26713da92fc85fa: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190211' into staging (2019-02-11 17:04:57 +0000) > > are available in the Git repository at: > > https://github.com/rth7680/qemu.git tags/pull-hppa-20190211 > > for you to fetch changes up to 23e76627deba013509b5f1a1e1c53e8e111145aa: > > hw/hppa: forward requests to CPU HPA (2019-02-11 20:49:06 -0800) > > ---------------------------------------------------------------- > Convert to decodetree. > Fix signed overflow conditions. > Fix dcor. > Add CPU MIE to PCI address space. Hi -- clang compiles fail with: In file included from /home/petmay01/linaro/qemu-for-merges/target/hppa/translate.c:337: target/hppa/decode.inc.c:471:16: error: redefinition of typedef 'arg_be' is a C11 feature [-Werror,-Wtypedef-redefinition] typedef arg_be arg_be; ^ target/hppa/decode.inc.c:9:3: note: previous definition is here } arg_be; ^ target/hppa/decode.inc.c:473:16: error: redefinition of typedef 'arg_bl' is a C11 feature [-Werror,-Wtypedef-redefinition] typedef arg_bl arg_bl; ^ target/hppa/decode.inc.c:15:3: note: previous definition is here } arg_bl; ^ thanks -- PMM
Patchew URL: https://patchew.org/QEMU/20190212045721.28041-1-richard.henderson@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PULL 00/24] target/hppa patch queue
Type: series
Message-id: 20190212045721.28041-1-richard.henderson@linaro.org
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/1550029560-30530-1-git-send-email-sandra@codesourcery.com -> patchew/1550029560-30530-1-git-send-email-sandra@codesourcery.com
* [new tag] patchew/20190211170136.18680-1-richard.henderson@linaro.org -> patchew/20190211170136.18680-1-richard.henderson@linaro.org
t [tag update] patchew/20190212025241.5330-1-stefanha@redhat.com -> patchew/20190212025241.5330-1-stefanha@redhat.com
* [new tag] patchew/20190212045721.28041-1-richard.henderson@linaro.org -> patchew/20190212045721.28041-1-richard.henderson@linaro.org
t [tag update] patchew/20190212145722.31891-1-philmd@redhat.com -> patchew/20190212145722.31891-1-philmd@redhat.com
Switched to a new branch 'test'
b5c5dfdaab hw/hppa: forward requests to CPU HPA
a48430e571 target/hppa: fix dcor instruction
b2d7de36d5 target/hppa: Fix addition '</<=' conditions
17311c79d0 target/hppa: Rearrange log conditions
ae9e01783f target/hppa: move GETPC to HELPER() functions
3b8707f153 target/hppa: Merge translate_one into hppa_tr_translate_insn
20fbaff776 target/hppa: Convert fp operate insns
4ca5b0d631 target/hppa: Convert fp fused multiply-add insns
d6841b65b3 target/hppa: Convert halt/reset insns
d9a029560f target/hppa: Convert fp indexed memory insns
55f466ba55 target/hppa: Convert offset memory insns
af0da59913 target/hppa: Convert arithmetic immediate insns
1df30dbecf target/hppa: Convert direct and indirect branches
758773e229 target/hppa: Convert shift, extract, deposit insns
612ad6b258 target/hppa: Convert conditional branches
d2cdb6e898 target/hppa: Convert fp multiply-add
ee9ae782f0 target/hppa: Convert indexed memory insns
0848256b5d target/hppa: Convert arithmetic/logical insns
76a314ee8a target/hppa: Convert memory management insns
0883ff944e target/hppa: Unify specializations of OR
7a5fb6d9b7 target/hppa: Convert remainder of system insns
1786cd8d4e target/hppa: Convert move to/from system registers
cd64b4ccf9 target/hppa: Begin using scripts/decodetree.py
568947bacd target/hppa: Use DisasContextBase.is_jmp
=== OUTPUT BEGIN ===
1/24 Checking commit 568947bacdff (target/hppa: Use DisasContextBase.is_jmp)
2/24 Checking commit cd64b4ccf907 (target/hppa: Begin using scripts/decodetree.py)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31:
new file mode 100644
WARNING: Block comments use a trailing */ on a separate line
#80: FILE: target/hppa/translate.c:668:
+ it may be tail-called from a translate function. */
total: 0 errors, 2 warnings, 101 lines checked
Patch 2/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/24 Checking commit 1786cd8d4e2b (target/hppa: Convert move to/from system registers)
4/24 Checking commit 7a5fb6d9b7eb (target/hppa: Convert remainder of system insns)
5/24 Checking commit 0883ff944ef7 (target/hppa: Unify specializations of OR)
WARNING: Block comments use a leading /* on a separate line
#56: FILE: target/hppa/translate.c:2650:
+ /* These are QEMU extensions and are nops in the real architecture:
WARNING: Block comments use a leading /* on a separate line
#65: FILE: target/hppa/translate.c:2659:
+ /* No need to check for supervisor, as userland can only pause
WARNING: Block comments use * on subsequent lines
#66: FILE: target/hppa/translate.c:2660:
+ /* No need to check for supervisor, as userland can only pause
+ until the next timer interrupt. */
WARNING: Block comments use a trailing */ on a separate line
#66: FILE: target/hppa/translate.c:2660:
+ until the next timer interrupt. */
total: 0 errors, 4 warnings, 128 lines checked
Patch 5/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/24 Checking commit 76a314ee8ad5 (target/hppa: Convert memory management insns)
7/24 Checking commit 0848256b5d0b (target/hppa: Convert arithmetic/logical insns)
8/24 Checking commit ee9ae782f0e4 (target/hppa: Convert indexed memory insns)
WARNING: Block comments use a leading /* on a separate line
#59: FILE: target/hppa/translate.c:299:
+/* Convert the M:A bits within a memory insn to the tri-state value
WARNING: Block comments use * on subsequent lines
#60: FILE: target/hppa/translate.c:300:
+/* Convert the M:A bits within a memory insn to the tri-state value
+ we use for the final M. */
WARNING: Block comments use a trailing */ on a separate line
#60: FILE: target/hppa/translate.c:300:
+ we use for the final M. */
total: 0 errors, 3 warnings, 305 lines checked
Patch 8/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/24 Checking commit d2cdb6e8983d (target/hppa: Convert fp multiply-add)
10/24 Checking commit 612ad6b25869 (target/hppa: Convert conditional branches)
11/24 Checking commit 758773e22930 (target/hppa: Convert shift, extract, deposit insns)
12/24 Checking commit 1df30dbecfa7 (target/hppa: Convert direct and indirect branches)
13/24 Checking commit af0da59913e5 (target/hppa: Convert arithmetic immediate insns)
14/24 Checking commit 55f466ba5585 (target/hppa: Convert offset memory insns)
15/24 Checking commit d9a029560fc8 (target/hppa: Convert fp indexed memory insns)
16/24 Checking commit d6841b65b327 (target/hppa: Convert halt/reset insns)
17/24 Checking commit 4ca5b0d63107 (target/hppa: Convert fp fused multiply-add insns)
18/24 Checking commit 20fbaff77686 (target/hppa: Convert fp operate insns)
19/24 Checking commit 3b8707f153aa (target/hppa: Merge translate_one into hppa_tr_translate_insn)
20/24 Checking commit ae9e01783f8e (target/hppa: move GETPC to HELPER() functions)
21/24 Checking commit 17311c79d00f (target/hppa: Rearrange log conditions)
22/24 Checking commit b2d7de36d5ec (target/hppa: Fix addition '</<=' conditions)
ERROR: space prohibited between function name and open parenthesis '('
#25: FILE: target/hppa/translate.c:457:
+ assert (c != TCG_COND_NEVER && c != TCG_COND_ALWAYS);
total: 1 errors, 0 warnings, 186 lines checked
Patch 22/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
23/24 Checking commit a48430e5710f (target/hppa: fix dcor instruction)
24/24 Checking commit b5c5dfdaab59 (hw/hppa: forward requests to CPU HPA)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190212045721.28041-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Hi Peter, On 2/12/19 2:15 PM, Peter Maydell wrote: > On Tue, 12 Feb 2019 at 04:57, Richard Henderson > <richard.henderson@linaro.org> wrote: >> >> The following changes since commit 22c5f446514a2a4bb0dbe1fea26713da92fc85fa: >> >> Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190211' into staging (2019-02-11 17:04:57 +0000) >> >> are available in the Git repository at: >> >> https://github.com/rth7680/qemu.git tags/pull-hppa-20190211 >> >> for you to fetch changes up to 23e76627deba013509b5f1a1e1c53e8e111145aa: >> >> hw/hppa: forward requests to CPU HPA (2019-02-11 20:49:06 -0800) >> >> ---------------------------------------------------------------- >> Convert to decodetree. >> Fix signed overflow conditions. >> Fix dcor. >> Add CPU MIE to PCI address space. > > Hi -- clang compiles fail with: > > In file included from > /home/petmay01/linaro/qemu-for-merges/target/hppa/translate.c:337: > target/hppa/decode.inc.c:471:16: error: redefinition of typedef > 'arg_be' is a C11 feature [-Werror,-Wtypedef-redefinition] > typedef arg_be arg_be; > ^ > target/hppa/decode.inc.c:9:3: note: previous definition is here > } arg_be; > ^ > target/hppa/decode.inc.c:473:16: error: redefinition of typedef > 'arg_bl' is a C11 feature [-Werror,-Wtypedef-redefinition] > typedef arg_bl arg_bl; > ^ > target/hppa/decode.inc.c:15:3: note: previous definition is here > } arg_bl; > ^ What Clang version is that? I can not reproduce using: clang version 7.0.1 (Fedora 7.0.1-1.fc29) > > thanks > -- PMM >
On Wed, 13 Feb 2019 at 18:40, Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > What Clang version is that? > > I can not reproduce using: > > clang version 7.0.1 (Fedora 7.0.1-1.fc29) OSX: Apple LLVM version 10.0.0 (clang-1000.11.45.5) and Ubuntu bionic: clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final) thanks -- PMM
Hi Peter, On 2/14/19 11:04 AM, Peter Maydell wrote: > On Wed, 13 Feb 2019 at 18:40, Philippe Mathieu-Daudé <philmd@redhat.com> wrote: >> What Clang version is that? >> >> I can not reproduce using: >> >> clang version 7.0.1 (Fedora 7.0.1-1.fc29) > > OSX: Apple LLVM version 10.0.0 (clang-1000.11.45.5)> and Ubuntu bionic: clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final) I can not reproduce on Bionic: $ clang --version clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final) Target: x86_64-pc-linux-gnu ./configure --host-cc=clang \ --cxx=clang++ \ --cc=clang \ --extra-cflags=-Werror=typedef-redefinition Host C compiler clang C++ compiler clang++ Objective-C compiler clang QEMU_CFLAGS -I/usr/include/pixman-1 -I$(SRC_PATH)/dtc/libfdt -Werror -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -fPIE -DPIE -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -Werror=typedef-redefinition -Wno-error=address-of-packed-member -Wno-string-plus-int -Wno-initializer-overrides -Wexpansion-to-defined -Wendif-labels -Wno-shift-negative-value -Wno-missing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-definition -Wtype-limits -fstack-protector-strong -I/usr/include/p11-kit-1 -I/usr/include/libpng16 -I/usr/include/spice-server -I/usr/include/spice-1 -I$(SRC_PATH)/capstone/include [...] $ make subdir-hppa-softmmu [...] $ hppa-softmmu/qemu-system-hppa --version QEMU emulator version 3.1.50 (v3.1.0-1733-gcb82c5728c-dirty) I don't have handy OSX setup except Travis, I'll see what I can do. Regards, Phil.
The following changes since commit 22c5f446514a2a4bb0dbe1fea26713da92fc85fa: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190211' into staging (2019-02-11 17:04:57 +0000) are available in the Git repository at: https://github.com/rth7680/qemu.git tags/pull-hppa-20190211 for you to fetch changes up to 23e76627deba013509b5f1a1e1c53e8e111145aa: hw/hppa: forward requests to CPU HPA (2019-02-11 20:49:06 -0800) ---------------------------------------------------------------- Convert to decodetree. Fix signed overflow conditions. Fix dcor. Add CPU MIE to PCI address space. ---------------------------------------------------------------- Richard Henderson (20): target/hppa: Use DisasContextBase.is_jmp target/hppa: Begin using scripts/decodetree.py target/hppa: Convert move to/from system registers target/hppa: Convert remainder of system insns target/hppa: Unify specializations of OR target/hppa: Convert memory management insns target/hppa: Convert arithmetic/logical insns target/hppa: Convert indexed memory insns target/hppa: Convert fp multiply-add target/hppa: Convert conditional branches target/hppa: Convert shift, extract, deposit insns target/hppa: Convert direct and indirect branches target/hppa: Convert arithmetic immediate insns target/hppa: Convert offset memory insns target/hppa: Convert fp indexed memory insns target/hppa: Convert halt/reset insns target/hppa: Convert fp fused multiply-add insns target/hppa: Convert fp operate insns target/hppa: Merge translate_one into hppa_tr_translate_insn target/hppa: Rearrange log conditions Sven Schnelle (4): target/hppa: move GETPC to HELPER() functions target/hppa: Fix addition '</<=' conditions target/hppa: fix dcor instruction hw/hppa: forward requests to CPU HPA hw/hppa/dino.c | 8 +- target/hppa/op_helper.c | 16 +- target/hppa/translate.c | 3355 ++++++++++++++++++--------------------------- target/hppa/Makefile.objs | 8 + target/hppa/insns.decode | 527 +++++++ 5 files changed, 1915 insertions(+), 1999 deletions(-) create mode 100644 target/hppa/insns.decode