mbox series

[v4,00/11] target/arm: Fixups for ARM_FEATURE_V8_FP16

Message ID 20180512003217.9105-1-richard.henderson@linaro.org
Headers show
Series target/arm: Fixups for ARM_FEATURE_V8_FP16 | expand

Message

Richard Henderson May 12, 2018, 12:32 a.m. UTC
Changes since v3:
  * Fixup rebase vs target-arm.next.  One of the middle
    patches had conflicts resolved incorrectly, so the
    patch set was non-bisectable.

Changes since v2:
  * Rebased vs target-arm.next.
  * Merged Peter's review.
  * Split out return fix as a separate patch.

Changes since v1:
  * Rebased vs master instead of tgt-arm-sve-9.
  * Alex did some additional digging through the ARM xhtml
    and came up with some additional missing instructions.
  * Everything cc'd to qemu-stable.


r~


Alex Bennée (4):
  target/arm: Implement FCMP for fp16
  target/arm: Implement FCSEL for fp16
  target/arm: Implement FMOV (immediate) for fp16
  target/arm: Fix sqrt_f16 exception raising

Richard Henderson (7):
  target/arm: Implement FMOV (general) for fp16
  target/arm: Early exit after unallocated_encoding in disas_fp_int_conv
  target/arm: Implement FCVT (scalar,integer) for fp16
  target/arm: Implement FCVT (scalar,fixed-point) for fp16
  target/arm: Introduce and use read_fp_hreg
  target/arm: Implement FP data-processing (2 source) for fp16
  target/arm: Implement FP data-processing (3 source) for fp16

 target/arm/helper-a64.h    |   2 +
 target/arm/helper.h        |   6 +
 target/arm/helper-a64.c    |  10 +
 target/arm/helper.c        |  38 +++-
 target/arm/translate-a64.c | 421 +++++++++++++++++++++++++++++++------
 5 files changed, 413 insertions(+), 64 deletions(-)

-- 
2.17.0

Comments

Alex Bennée May 13, 2018, 7:22 a.m. UTC | #1
Richard Henderson <richard.henderson@linaro.org> writes:

> Changes since v3:

>   * Fixup rebase vs target-arm.next.  One of the middle

>     patches had conflicts resolved incorrectly, so the

>     patch set was non-bisectable.


I've tested with the new RISU set:

 http://people.linaro.org/~alex.bennee/testcases/arm64.risu/testcases_aarch64_all_half.tar.xz

without any LD/ST opcodes on your rth/tgt-arm-fp16 branch

Tested-by: Alex Bennée <alex.bennee@linaro.org>


>

> Changes since v2:

>   * Rebased vs target-arm.next.

>   * Merged Peter's review.

>   * Split out return fix as a separate patch.

>

> Changes since v1:

>   * Rebased vs master instead of tgt-arm-sve-9.

>   * Alex did some additional digging through the ARM xhtml

>     and came up with some additional missing instructions.

>   * Everything cc'd to qemu-stable.

>

>

> r~

>

>

> Alex Bennée (4):

>   target/arm: Implement FCMP for fp16

>   target/arm: Implement FCSEL for fp16

>   target/arm: Implement FMOV (immediate) for fp16

>   target/arm: Fix sqrt_f16 exception raising

>

> Richard Henderson (7):

>   target/arm: Implement FMOV (general) for fp16

>   target/arm: Early exit after unallocated_encoding in disas_fp_int_conv

>   target/arm: Implement FCVT (scalar,integer) for fp16

>   target/arm: Implement FCVT (scalar,fixed-point) for fp16

>   target/arm: Introduce and use read_fp_hreg

>   target/arm: Implement FP data-processing (2 source) for fp16

>   target/arm: Implement FP data-processing (3 source) for fp16

>

>  target/arm/helper-a64.h    |   2 +

>  target/arm/helper.h        |   6 +

>  target/arm/helper-a64.c    |  10 +

>  target/arm/helper.c        |  38 +++-

>  target/arm/translate-a64.c | 421 +++++++++++++++++++++++++++++++------

>  5 files changed, 413 insertions(+), 64 deletions(-)



--
Alex Bennée
Peter Maydell May 14, 2018, 3:16 p.m. UTC | #2
On 12 May 2018 at 01:32, Richard Henderson <richard.henderson@linaro.org> wrote:
> Changes since v3:

>   * Fixup rebase vs target-arm.next.  One of the middle

>     patches had conflicts resolved incorrectly, so the

>     patch set was non-bisectable.

>

> Changes since v2:

>   * Rebased vs target-arm.next.

>   * Merged Peter's review.

>   * Split out return fix as a separate patch.

>

> Changes since v1:

>   * Rebased vs master instead of tgt-arm-sve-9.

>   * Alex did some additional digging through the ARM xhtml

>     and came up with some additional missing instructions.

>   * Everything cc'd to qemu-stable.

>

>

> r~

>


Applied all to target-arm.next, thanks.

-- PMM