From patchwork Sat Feb 17 16:40:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 128668 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp1738404ljc; Sat, 17 Feb 2018 08:41:11 -0800 (PST) X-Google-Smtp-Source: AH8x227Hd1LoDX3NFGi/LsZj304CWyA214Rll1aFA/1NtQaRqADMvfbNJ7w2k09e627aMIpq3391 X-Received: by 10.129.68.8 with SMTP id r8mr7006255ywa.252.1518885671060; Sat, 17 Feb 2018 08:41:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518885671; cv=none; d=google.com; s=arc-20160816; b=FWeHugGK2GnEUyTVU/pe13GrOE00p0U2HZhbtN7cTNl74LVMltBhLHahMpjFkZ3XYR nZrU6jQtvOF5uKoOlvprwnOBW6Z0kurQ/w+wvTn7XHTs42qGXu5Ev1Bzt2hvJzuUDMI8 qYC1Yj7TSRqybPCIVuqVRQSAkAOuysgutHzI89iE/7UDKe2eDxFyk5Sgg2svZ/rBVLoX LYKc8UX6smNNAcACe1vScN0vgj/AR9mzzWrHuzerkbJ+arhAv5s1Pnt0m56ReY0x/GWS aQHMlryJeaAObl389zrcSfnlhbFt1fRENnjeM7gDCviPuPn1zinsRZMHPcjyZD36CYnv FjPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:message-id:date:to:from :dkim-signature:arc-authentication-results; bh=Wg0vlsxkQ3TXnTL1xjSe/7in/F9N8Pal1dvTNZDHRkc=; b=akcdT64hhS3lLy50i17v9aGrp7CavaD6MJ48L5cwjhX/cDLebzvy8WtVv7U/RgYxiT X19zgDV+EFTidma/0tLTk216CknIa/ZvlQmXvhTOUVMvuTOTozCh6qB7CedGsNsawD2r G9/HUggPUBfJ+tqIsYS3aNUaftoeeX0sbT8+F3WWiPB/PXG+42NAfkVtMG7vSykAbi6V hlZAO+HZ7mFds7TdO9X1frv6SkzGe+uTljfb18/y0xBXTLyfialo/uhHaqUHytvaIH4b 2KV1hTGUyTW6w9QBWdxoaIixYDg98a0fYgCOXBwpxDHQCrUfWjbqhFQ3iPEpSHlCRvU0 NF9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=E4L9yodv; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id 84si2048276yba.27.2018.02.17.08.41.10 for (version=TLS1 cipher=AES128-SHA bits=128/128); Sat, 17 Feb 2018 08:41:11 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=E4L9yodv; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:39223 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1en5Xy-0005PB-HC for patch@linaro.org; Sat, 17 Feb 2018 11:41:10 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46176) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1en5Xa-0005OP-J5 for qemu-devel@nongnu.org; Sat, 17 Feb 2018 11:40:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1en5XX-0001j7-GC for qemu-devel@nongnu.org; Sat, 17 Feb 2018 11:40:46 -0500 Received: from mail-pl0-x244.google.com ([2607:f8b0:400e:c01::244]:34483) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1en5XX-0001ip-98 for qemu-devel@nongnu.org; Sat, 17 Feb 2018 11:40:43 -0500 Received: by mail-pl0-x244.google.com with SMTP id bd10so3365713plb.1 for ; Sat, 17 Feb 2018 08:40:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id; bh=Wg0vlsxkQ3TXnTL1xjSe/7in/F9N8Pal1dvTNZDHRkc=; b=E4L9yodvltmH1Oo5XIfE1o4M4fw4PkjHw9IjP2i+9KZmRTmtB/RfPgiBqt90GQYfF/ TgewSN2Kgra+mAJmYgI96ZMW0MKshzymbopXMVbJgn6oxmGwaYYGw9nrUXzdjkLssS2s +zN+SoKW2UneHu28/GU1Uei8+lS02p9aXEp4E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=Wg0vlsxkQ3TXnTL1xjSe/7in/F9N8Pal1dvTNZDHRkc=; b=W2fFX4T1CVN3iQIWVHmh6F/B9yRDwWJCM6+0r4UwYC3XExCnABsu96CPDRgbRsSKXz V527v2GuQLwSaimPA8G+CDLfRWXAAELrm1wJpOaTgdKARlQMubYrKP2Mg09EckMzD8eF rs1etmxJXm9yB/inn9pOFdOwk/oPpzg9+qlWbgYsoe5tdEGjqTnkWTCoxG/hW7LKnbQa f2aOYllT7j1+LcifmdkjMeOPNWipWcU+nvMsW4ToL5NJLmgLCFNjqDiYppWZrmIH4McS uvmHsDA3gUHdERInC60qh59biJJ8RhnswAYKXxqnM8/i1JPGkRLecmnEBxNKhC2IDCN1 4WJQ== X-Gm-Message-State: APf1xPADAEK/a1aTQtuM4rf/F6IT/9Fqkfsc9jQnqS/c91LcmcjrZqrG /aCxGSLjyvJoaSHTP9vekme3kY5+NOY= X-Received: by 2002:a17:902:8a98:: with SMTP id p24-v6mr2947368plo.147.1518885641713; Sat, 17 Feb 2018 08:40:41 -0800 (PST) Received: from cloudburst.twiddle.net ([50.0.192.64]) by smtp.gmail.com with ESMTPSA id a6sm29152324pfi.99.2018.02.17.08.40.39 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 17 Feb 2018 08:40:40 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Sat, 17 Feb 2018 08:40:35 -0800 Message-Id: <20180217164037.15727-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::244 Subject: [Qemu-devel] [PATCH 0/2] tcg: tcg_can_emit_vec_op cleanup+fix X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" While rearranging/rebasing my SVE patch set, I triggered an assert in tcg_gen_mul_vec. Turns out we should not have gone down that path, due to a missing tcg_can_emit_vec_op check. Tidy the usage of tcg_can_emit_vec_op to avoid code clutter. r~ Richard Henderson (2): tcg: Fold unspecified opcode test into tcg_can_emit_vec_op tcg: Add missing tcg_can_emit_vec_op check in tcg_gen_gvec_2s tcg/aarch64/tcg-target.inc.c | 4 ++++ tcg/i386/tcg-target.inc.c | 4 ++++ tcg/tcg-op-gvec.c | 37 ++++++++++++++++++------------------- 3 files changed, 26 insertions(+), 19 deletions(-) -- 2.14.3