| Message ID | 20171103084046.12821-1-richard.henderson@linaro.org |
|---|---|
| Headers | show |
| Series | TCG queued patches | expand |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PULL 0/3] TCG queued patches
Type: series
Message-id: 20171103084046.12821-1-richard.henderson@linaro.org
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/1509640536-32160-1-git-send-email-peter.maydell@linaro.org -> patchew/1509640536-32160-1-git-send-email-peter.maydell@linaro.org
t [tag update] patchew/20171102180310.24760-1-dgilbert@redhat.com -> patchew/20171102180310.24760-1-dgilbert@redhat.com
* [new tag] patchew/20171103084046.12821-1-richard.henderson@linaro.org -> patchew/20171103084046.12821-1-richard.henderson@linaro.org
Switched to a new branch 'test'
289026f1da cpu-exec: Exit exclusive region on longjmp from step_atomic
b0dafca64f tcg/s390x: Use constant pool for prologue
9beb4b93f1 tcg: Allow constant pool entries in the prologue
=== OUTPUT BEGIN ===
Checking PATCH 1/3: tcg: Allow constant pool entries in the prologue...
Checking PATCH 2/3: tcg/s390x: Use constant pool for prologue...
Checking PATCH 3/3: cpu-exec: Exit exclusive region on longjmp from step_atomic...
ERROR: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#45: FILE: accel/tcg/cpu-exec.c:237:
+ volatile bool in_exclusive_region = false;
total: 1 errors, 0 warnings, 38 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
On 3 November 2017 at 08:40, Richard Henderson <richard.henderson@linaro.org> wrote: > Two bug fixes this time. > > > r~ > > > The following changes since commit 094611b426b3b532a3ec72256cb4e958149269d3: > > oslib-posix: Use sysctl(2) call to resolve exec_dir on NetBSD (2017-11-02 16:19:34 +0000) > > are available in the git repository at: > > git://github.com/rth7680/qemu.git tags/pull-tcg-20171103 > > for you to fetch changes up to 426eeecdf5d9cf1695a53c08f46394f8e5351750: > > cpu-exec: Exit exclusive region on longjmp from step_atomic (2017-11-03 09:34:21 +0100) > > ---------------------------------------------------------------- > Queued tcg patches > > ---------------------------------------------------------------- > Peter Maydell (1): > cpu-exec: Exit exclusive region on longjmp from step_atomic > > Richard Henderson (2): > tcg: Allow constant pool entries in the prologue > tcg/s390x: Use constant pool for prologue Applied, thanks. -- PMM
Two bug fixes this time. r~ The following changes since commit 094611b426b3b532a3ec72256cb4e958149269d3: oslib-posix: Use sysctl(2) call to resolve exec_dir on NetBSD (2017-11-02 16:19:34 +0000) are available in the git repository at: git://github.com/rth7680/qemu.git tags/pull-tcg-20171103 for you to fetch changes up to 426eeecdf5d9cf1695a53c08f46394f8e5351750: cpu-exec: Exit exclusive region on longjmp from step_atomic (2017-11-03 09:34:21 +0100) ---------------------------------------------------------------- Queued tcg patches ---------------------------------------------------------------- Peter Maydell (1): cpu-exec: Exit exclusive region on longjmp from step_atomic Richard Henderson (2): tcg: Allow constant pool entries in the prologue tcg/s390x: Use constant pool for prologue accel/tcg/cpu-exec.c | 15 ++++++++++++--- tcg/s390/tcg-target.inc.c | 44 ++++++++++++------------------------------ tcg/tcg.c | 49 ++++++++++++++++++++++++++++++++++++++++------- 3 files changed, 66 insertions(+), 42 deletions(-)