From patchwork Mon Jul 10 19:21:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 107316 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp3836811qge; Mon, 10 Jul 2017 12:23:00 -0700 (PDT) X-Received: by 10.200.0.213 with SMTP id d21mr6054858qtg.28.1499714580341; Mon, 10 Jul 2017 12:23:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1499714580; cv=none; d=google.com; s=arc-20160816; b=UGPPyzlzUClOhjQre4SSl3I9gztwi4jL/8mGYxBtahO2ogxJWhtohVGrVQ/c/EXkBs uZiGgUAOA1uX3sE5ae6pTslVlSQVryFV0wOGwr4PAib5l/Xus0U2T32pFJpRv8Pwdmkc FAM2Q83FXDayMjQ7qpTa17P/rYXd3GePiGTn9+tejrjRUmcEusfGueYirnBh2l1e2Y4M irK9BmvbFBQj2t3kmKLV+bnI3g0VV1CGsJ+SuvVkkEG0kLCZaNwmItZUs95vyjp80Fb/ XawQ9dOt1mm5sawyWOowzgygjn4ZAA5oka+MaJGLRcFQIZ+VHh4kfs1/+jzwT2JahnWt iylQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:message-id:date:to:from :dkim-signature:arc-authentication-results; bh=MoJyMtsJtbp3hwniX6uIvkweGzw66u1bOCKCgQo8pg8=; b=hqQBZoBB7NO2/0smjkKuVs/noDYd9mNNj0gUurxlVoQd5rRDOldkOf1rFbr/VPZjKt 2rDPNmNxOFg23HJSeUDLXRfV+mQCnDIiyaPI795sIpJ6iyjHSiJ/bkGicncPCoRXQd+9 AHlpiN6wlkwywog0K5fiYj1xag8duTW386ikYrTkf5Tn6pZc4rPPAQ6YTOlT5cXHSApl mJn/drK1PnP/vLFZixWdbm2LTELcaGK8KLFxMD9Gy17O3Hn6z2bdHjFry5c2mdGUdz/y SPYp2YSZIl0HSYZBWxViXS1sM6tJAtRXHdHteMmiqyr3dJZhFl9Nlz4kjpYJ/IV+Fl4I 8eJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.b=UME/SkK4; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [208.118.235.17]) by mx.google.com with ESMTPS id h57si11692268qtb.385.2017.07.10.12.22.59 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 10 Jul 2017 12:23:00 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.b=UME/SkK4; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:42619 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUeGn-00087T-Mx for patch@linaro.org; Mon, 10 Jul 2017 15:22:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41533) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUeGQ-00086e-GJ for qemu-devel@nongnu.org; Mon, 10 Jul 2017 15:22:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUeGN-000760-DA for qemu-devel@nongnu.org; Mon, 10 Jul 2017 15:22:34 -0400 Received: from mail-wr0-f170.google.com ([209.85.128.170]:35194) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dUeGN-00075o-5r for qemu-devel@nongnu.org; Mon, 10 Jul 2017 15:22:31 -0400 Received: by mail-wr0-f170.google.com with SMTP id k67so151271253wrc.2 for ; Mon, 10 Jul 2017 12:22:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MoJyMtsJtbp3hwniX6uIvkweGzw66u1bOCKCgQo8pg8=; b=UME/SkK4t0iz+hir/XHXoyYtIK+JM3cIGHwAUAdezju6uuYixpdTMVPT7PlwpkDkzE 1nSpzbA5LHL2zP3UqzmGLnZHA/WDpN6872U2G8Y1yrmVOo/IAqrGmrbYkQqXuwL6Ykno bTaGYkX0aLMif1XX7DVRGKDmRaFidB2U6+SnM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MoJyMtsJtbp3hwniX6uIvkweGzw66u1bOCKCgQo8pg8=; b=nfMy1GBh8yYDRtiaQ8GbpmQerDSi1LvEtuD0bogB6Q/wp80S0vsokiTpCpHWT6yv/w HpJkBQkOycYy57dP7ccopsiAw2f6P0seYsYuNYSKuPfHNQiz0wTyeP6kEn7tppk/52VC JWxrWvtm5jwXVp5GhmwYCemKPBY7I6EXJ5OJmJ71kkvcwRuygKxCfRuoBRuWEP5lzDnI 4928wojWv2SvM2RtdFsZNOT2DHLOAul+syicCKgJJeOFKm5M7OtRmDslEs24P1OPdaVn fl4HPV8dO2oTWwOqu3NnzNjqJi0DvzQw/ld2vW+Z0qfYNEdZr0vsgucH90h3rhodmz2q hGZw== X-Gm-Message-State: AIVw113t8znBLhG88YpgDwtYznJ/IBOVRLujT76JszxazZ11t1roMLDA JLQYfPZxZngf440/ X-Received: by 10.223.173.83 with SMTP id p77mr8050810wrc.25.1499714489890; Mon, 10 Jul 2017 12:21:29 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id f21sm16294125wra.5.2017.07.10.12.21.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Jul 2017 12:21:28 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 6DBCF3E014F; Mon, 10 Jul 2017 20:21:28 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org, rth@twiddle.net, cota@braap.org Date: Mon, 10 Jul 2017 20:21:23 +0100 Message-Id: <20170710192128.9048-1-alex.bennee@linaro.org> X-Mailer: git-send-email 2.13.0 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.128.170 Subject: [Qemu-devel] [PATCH v2 0/5] arm: fixes for eret, isb and DISAS_UPDATE handling X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Hi, This is a quick iteration from the previous series: https://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg02371.html Which was born out of the fix: https://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg01831.html Following feedback I reverted the attempt to use DISAS_UPDATE for everything and just made it match the semantics of not-chaining. So patches 1 & 3 are purely documentation. Patch 2 should prevent any system change prompted by writing to a system register not exiting the loop. Patch 4 is a minor optimisation to ISB handling Patch 5 fixes the eret regression from the DISAS_JUMP optimisation I think now all users of DISAS_JUMP should be safe with respect to TB chaining. Please review. Alex Bennée (5): include/exec/exec-all: document common exit conditions target/arm/translate: make DISAS_UPDATE match declared semantics target/arm/translate.h: expand comment on DISAS_EXIT target/arm: use DISAS_JUMP for ISB handling target/arm: use DISAS_EXIT for eret handling include/exec/exec-all.h | 29 ++++++++++++++++++++++++++--- target/arm/translate-a64.c | 20 +++++++++++--------- target/arm/translate.c | 24 +++++++++++++++++------- target/arm/translate.h | 5 ++++- 4 files changed, 58 insertions(+), 20 deletions(-) -- 2.13.0