mbox series

[RISU,v6,00/10] Record/replay patches

Message ID 20170621154244.28309-1-alex.bennee@linaro.org
Headers show
Series Record/replay patches | expand

Message

Alex Bennée June 21, 2017, 3:42 p.m. UTC 
Hi Peter,

Re-based with review comments addressed and tags added where
appropriate.

Alex Bennée (10):
  README: document the coding style used for risu
  build-all-archs: support cross building via docker
  risu: a bit more verbosity when starting
  risu: paramterise send/receive functions
  risu: add header to trace stream
  risu: add simple trace and replay support
  risu: handle trace through stdin/stdout
  risu: add support compressed tracefiles
  new: record_traces.sh helper script
  new: run_risu.sh script

 .dir-locals.el           |   2 +
 Makefile                 |   4 +-
 README                   |   9 +++
 build-all-archs          |  46 ++++++++++--
 configure                |  55 +++++++++++++-
 contrib/record_traces.sh |  32 +++++++++
 contrib/run_risu.sh      |  66 +++++++++++++++++
 reginfo.c                | 120 ++++++++++++++++++-------------
 risu.c                   | 181 ++++++++++++++++++++++++++++++++++++++++++-----
 risu.h                   |  23 +++++-
 risu_aarch64.c           |   5 ++
 risu_arm.c               |   5 ++
 risu_m68k.c              |   5 ++
 risu_ppc64.c             |   5 ++
 14 files changed, 481 insertions(+), 77 deletions(-)
 create mode 100644 .dir-locals.el
 create mode 100755 contrib/record_traces.sh
 create mode 100755 contrib/run_risu.sh

-- 
2.13.0

Comments

Peter Maydell June 29, 2017, 11:15 a.m. UTC | #1 
On 21 June 2017 at 16:42, Alex Bennée <alex.bennee@linaro.org> wrote:
> Hi Peter,

>

> Re-based with review comments addressed and tags added where

> appropriate.

>

> Alex Bennée (10):

>   README: document the coding style used for risu

>   build-all-archs: support cross building via docker

>   risu: a bit more verbosity when starting

>   risu: paramterise send/receive functions

>   risu: add header to trace stream

>   risu: add simple trace and replay support

>   risu: handle trace through stdin/stdout

>   risu: add support compressed tracefiles

>   new: record_traces.sh helper script

>   new: run_risu.sh script


Hi -- these look OK to me so I have applied them to risu master
(I fixed up a few checkpatch style issues but nothing major).

I notice there's no documentation of the record/replay
feature, though -- could you send a patch which adds
discussion of how to use it to the README file, please?

The 'Building' section in the README should also mention that
we recommend having zlib available.

thanks
-- PMM