From patchwork Wed Apr 5 13:24:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 96849 Delivered-To: patch@linaro.org Received: by 10.182.246.10 with SMTP id xs10csp258869obc; Wed, 5 Apr 2017 06:26:44 -0700 (PDT) X-Received: by 10.237.60.65 with SMTP id u1mr27783842qte.176.1491398804594; Wed, 05 Apr 2017 06:26:44 -0700 (PDT) Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id h184si17786592qkf.178.2017.04.05.06.26.44 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 05 Apr 2017 06:26:44 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:40554 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvkxQ-0005T2-4v for patch@linaro.org; Wed, 05 Apr 2017 09:26:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54499) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvkvq-0004VS-Pw for qemu-devel@nongnu.org; Wed, 05 Apr 2017 09:25:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cvkvn-0000CV-LI for qemu-devel@nongnu.org; Wed, 05 Apr 2017 09:25:06 -0400 Received: from mail-wr0-x229.google.com ([2a00:1450:400c:c0c::229]:34132) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cvkvn-0000CH-DZ for qemu-devel@nongnu.org; Wed, 05 Apr 2017 09:25:03 -0400 Received: by mail-wr0-x229.google.com with SMTP id t20so14810844wra.1 for ; Wed, 05 Apr 2017 06:25:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=TyxJcTAgyoIOlInIgxw5KpowIrX2IJqvLIytwn80lQA=; b=eLtDKm1Y/ZStEGNMYZk6+bGQQwd5t2m1NKXVL+S4CoyOT947ol4OSFyR9fVo6VHuiG hURgV2yZ+IwpgsiU3I07umVAryxA5UMxRFdaUrNtDMlq5Ixz0bxJRk1QIG/oAt6a/P8R xQ/MnFID3/q8lfCYMOqxte4cj447A7baU5nyM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=TyxJcTAgyoIOlInIgxw5KpowIrX2IJqvLIytwn80lQA=; b=HYHdL3+kD2T6BRLngiMizgtmB23x5WanHSZMQ58kLhdjU1XZpYC+QF++8hu5RkDsRv gDG23InBCxtmXD12slKH+1ugRFM2T4R5o/tppANSrdNwZwWXE76xKGi5kLYNcF0Q3ews 0rGtqUKSBQA+MHpiUojU/iOatoCHUe6NGWKAPYACHq1gBBD4gdUg5thLhoBF50Deg1p7 ekARHv8dWifOjnCTIxeyTWFYDfk5XU6q7Dq52tSrfpzoixbxtj0DCtIPxyENRbKNUg+G 8nQ5ymWmtySsHY/3FE9mpCwoXVSPD7jc71XUlQTR7HtsjWjkdycUirqjldBYiUQqQdG1 BUJg== X-Gm-Message-State: AFeK/H2vqaGLeB26DQ7IBBR2XyMX0eEEtOKD3FTE5ND6HuYrQlO4t9Wng67CdyvZzh0VhnyS X-Received: by 10.28.220.212 with SMTP id t203mr19914777wmg.62.1491398701986; Wed, 05 Apr 2017 06:25:01 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id w186sm471135wme.26.2017.04.05.06.25.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Apr 2017 06:25:01 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 1E46E3E0178; Wed, 5 Apr 2017 14:25:03 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: dovgaluk@ispras.ru, rth@twiddle.net, pbonzini@redhat.com Date: Wed, 5 Apr 2017 14:24:51 +0100 Message-Id: <20170405132503.32125-1-alex.bennee@linaro.org> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::229 Subject: [Qemu-devel] [PATCH v2 00/12] icount and misc MTTCG fixes for 2.9-rc4 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mttcg@listserver.greensocs.com, peter.maydell@linaro.org, nikunj@linux.vnet.ibm.com, a.rigo@virtualopensystems.com, qemu-devel@nongnu.org, cota@braap.org, bobby.prani@gmail.com, =?utf-8?q?Alex_Benn=C3=A9e?= , fred.konrad@greensocs.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Hi, Here is my current queue for icount and miscellaneous MTTCG related fixes. The main difference from the RFC series is I have dropped the graceful handling of backward time events in the replay log in favour of updating the global qemu_icount more frequently. The graceful handling is now replaced with an assertion about the arrow of time. With these changes I was able to dispenses with additional BQL locking which I had been applying during cpu_handle_exception. It doesn't completely solve the problem of keeping the main-loop and vCPU events stream in sync but it works pretty reliably in my test case. Given the current release time-line I think this is the best solution for now. Options for post-2.9 include either replacing the BQL mediated sequencing with a new lock (pushing replay_lock up the tree?) or marshalling events through a single thread which can then keep things in order. Aside from that other patches have had various r-b and a-b tags applied from the original posting. I hope to roll a pull request with these fixes by the end of the week so we there isn't a rush for next Tuesday's rc4. Expedient comments and reviews are therefor gratefully received ;-) Regards, Alex Bennée (12): scripts/qemugdb/mtree.py: fix up mtree dump scripts/qemu-gdb/timers.py: new helper to dump timer state scripts/replay-dump.py: replay log dumper target/i386/misc_helper: wrap BQL around another IRQ generator cpus: remove icount handling from qemu_tcg_cpu_thread_fn cpus: check cpu->running in cpu_get_icount_raw() cpus: move icount preparation out of tcg_exec_cpu cpus: don't credit executed instructions before they have run cpus: introduce cpu_update_icount helper cpu-exec: update icount after each TB_EXIT cpus: call cpu_update_icount on read replay: assert time only goes forward cpu-exec.c | 14 +-- cpus.c | 98 ++++++++++++----- include/qemu/timer.h | 1 + include/qom/cpu.h | 1 + replay/replay-internal.c | 4 + replay/replay.c | 4 + scripts/qemu-gdb.py | 3 +- scripts/qemugdb/mtree.py | 12 +- scripts/qemugdb/timers.py | 54 +++++++++ scripts/replay-dump.py | 272 ++++++++++++++++++++++++++++++++++++++++++++++ target/i386/misc_helper.c | 3 + 11 files changed, 426 insertions(+), 40 deletions(-) create mode 100644 scripts/qemugdb/timers.py create mode 100755 scripts/replay-dump.py -- 2.11.0